Omer Frenkel has posted comments on this change. Change subject: core: add memory balloon device support ......................................................................
Patch Set 8: (1 inline comment) i think missing a check on update vm to block user from adding/removing balloon when vm is not down .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java Line 63: "vmPayload", "balloonEnabled" }); this is not needed now that this field is not in vm static -- To view, visit http://gerrit.ovirt.org/4993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2fed44feb3718b72f163755271ddc07b201265 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
