[Engine-patches] [oVirt Jenkins] ovirt_engine_purge_maven_repo - Build # 77 - Still Failing!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine_purge_maven_repo - Build # 77 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_purge_maven_repo/77/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Missing button on Template/Storage sub-tab (#80132...

2012-03-20 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Missing button on Template/Storage sub-tab (#801327) .. Patch Set 1: In consequence of 'Multiple Storage Domains' feature, removing a template from a si

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-20 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: Fix VmDAO.getForImage to return multiple VMs

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix VmDAO.getForImage to return multiple VMs .. Patch Set 4: (1 inline comment) Since Disk id is not image id, isn't it better to look by disk ID only (it

[Engine-patches] Change in ovirt-engine[master]: core: permission filtering for GetStorageDomainsByVmTemplate...

2012-03-20 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId .. core: permission filtering for GetStorageDomainsByVmTemplateId Change-Id: I136016e5b2a28c5a0ee4c1b

[Engine-patches] Change in ovirt-engine[master]: core: permission filtering for GetVdsCertificateSubjectByVds...

2012-03-20 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: permission filtering for GetVdsCertificateSubjectByVdsId .. core: permission filtering for GetVdsCertificateSubjectByVdsId Change-Id: I455e7cf746d7ec8efe1a480

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 577 - Fixed!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine - Build # 577 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/577/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: webadmin: Missing button on Template/Storage sub-tab (#80132...

2012-03-20 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Missing button on Template/Storage sub-tab (#801327) .. webadmin: Missing button on Template/Storage sub-tab (#801327) https://bugzilla.redhat.com/801

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 576 - Still Failing!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine - Build # 576 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/576/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patche

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 575 - Failure!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine - Build # 575 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/575/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: webadmin: adjust location of sub menu open in mouseover

2012-03-20 Thread danny . ran
Danny Rankevich has submitted this change and it was merged. Change subject: webadmin: adjust location of sub menu open in mouseover .. webadmin: adjust location of sub menu open in mouseover no bz In a previous commit I chang

[Engine-patches] Change in ovirt-engine[master]: webadmin: adjust location of sub menu open in mouseover

2012-03-20 Thread danny . ran
Danny Rankevich has posted comments on this change. Change subject: webadmin: adjust location of sub menu open in mouseover .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2962 To

[Engine-patches] Change in ovirt-engine[master]: webadmin: adjust location of sub menu open in mouseover

2012-03-20 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: adjust location of sub menu open in mouseover .. webadmin: adjust location of sub menu open in mouseover no bz In a previous commit I change the MenuB

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 574 - Fixed!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine - Build # 574 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/574/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: packaging: enable ovirt installation on ports lower than 102...

2012-03-20 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: packaging: enable ovirt installation on ports lower than 1024 .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/2961 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: packaging: enable ovirt installation on ports lower than 102...

2012-03-20 Thread bazulay
Barak Azulay has uploaded a new change for review. Change subject: packaging: enable ovirt installation on ports lower than 1024 .. packaging: enable ovirt installation on ports lower than 1024 This patch enables ovirt to utiliz

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup VmDAODbFacadeImpl

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Cleanup VmDAODbFacadeImpl .. Patch Set 4: (1 inline comment) File backend/manager/modules/dal/src/mai

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 573 - Still Failing!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine - Build # 573 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/573/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patche

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 572 - Failure!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine - Build # 572 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/572/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: core: Use new MultiValueMapUtils

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Use new MultiValueMapUtils .. Patch Set 6: (2 inline comments) File backend/manager/modules/vdsbroker

[Engine-patches] Change in ovirt-engine[master]: core: Fix update disk after image_vm_map removal

2012-03-20 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix update disk after image_vm_map removal .. core: Fix update disk after image_vm_map removal The check for old disk was not correct after remova

[Engine-patches] Change in ovirt-engine[master]: core: Fix update disk after image_vm_map removal

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix update disk after image_vm_map removal .. Patch Set 2: Verified; Looks good to me, approved Just rebased, ack (+2) by mlipchuk -- To view, visit http:

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 570 - Fixed!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine - Build # 570 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/570/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for snapshot while stateles

2012-03-20 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add validation for snapshot while stateles .. core: Add validation for snapshot while stateles Snapshot can't be taken while VM is running in stat

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for snapshot while stateles

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Add validation for snapshot while stateles .. Patch Set 3: Verified; Looks good to me, approved Just rebased, ack (+2) by ofrenkel -- To view, visit http:

[Engine-patches] Jenkins build is back to normal : ovirt_engine_create_rpms #59

2012-03-20 Thread Jenkins oVirt Server
See ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup and fix iNPE in HSMGetAllTasksStatusesVDSComma...

2012-03-20 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Cleanup and fix iNPE in HSMGetAllTasksStatusesVDSCommand .. Patch Set 1: (1 inline comment) File backen

[Engine-patches] Change in ovirt-engine[master]: core: rename upgreade script

2012-03-20 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: rename upgreade script .. core: rename upgreade script Change-Id: If754062280e1fe5cb2948e08f0e4cf61cd6c691a --- R backend/manager/dbscripts/upgrad

[Engine-patches] Change in ovirt-engine[master]: core: rename upgreade script

2012-03-20 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: rename upgreade script .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2960 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: rename upgreade script

2012-03-20 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: rename upgreade script .. core: rename upgreade script Change-Id: If754062280e1fe5cb2948e08f0e4cf61cd6c691a --- R backend/manager/dbscripts/upgrade/03_01_068

[Engine-patches] Change in ovirt-engine[master]: core: limit setupnetworks to cluster 3.1, and datacenter 3.0

2012-03-20 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: limit setupnetworks to cluster 3.1, and datacenter 3.0 .. core: limit setupnetworks to cluster 3.1, and datacenter 3.0 Change-Id: Iad1beef675fd07bf0bd

[Engine-patches] Change in ovirt-engine[master]: core: limit setupnetworks to cluster 3.1, and datacenter 3.0

2012-03-20 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: limit setupnetworks to cluster 3.1, and datacenter 3.0 .. Patch Set 3: Verified; Looks good to me, approved rebase already acked -- To view, visit http://gerr

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 569 - Failure!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine - Build # 569 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/569/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: core: limit setupnetworks to cluster 3.1, and datacenter 3.0

2012-03-20 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: limit setupnetworks to cluster 3.1, and datacenter 3.0 .. -- To view, visit http://gerrit.ovirt.org/2958 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: core: limit setupnetworks to cluster 3.1, and datacenter 3.0

2012-03-20 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: limit setupnetworks to cluster 3.1, and datacenter 3.0 .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/2958 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core : Fixing MoveOrCopyDiskCommand

2012-03-20 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: core : Fixing MoveOrCopyDiskCommand .. core : Fixing MoveOrCopyDiskCommand During copy we should set destinationImageId to origin imageId Change-Id: I62f

[Engine-patches] Change in ovirt-engine[master]: core : Fixing MoveOrCopyDiskCommand

2012-03-20 Thread derez
Daniel Erez has posted comments on this change. Change subject: core : Fixing MoveOrCopyDiskCommand .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2959 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core : Fixing MoveOrCopyDiskCommand

2012-03-20 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Fixing MoveOrCopyDiskCommand .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/2959 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: core : Fixing MoveOrCopyDiskCommand

2012-03-20 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: core : Fixing MoveOrCopyDiskCommand .. core : Fixing MoveOrCopyDiskCommand During copy we should set destinationImageId to origin imageId Change-Id: I62f0b178

[Engine-patches] Change in ovirt-engine[master]: core: Fix update disk after image_vm_map removal

2012-03-20 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fix update disk after image_vm_map removal .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2956 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for snapshot while stateles

2012-03-20 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Add validation for snapshot while stateles .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2942 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: limit setupnetworks to cluster 3.1, and datacenter 3.0

2012-03-20 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: limit setupnetworks to cluster 3.1, and datacenter 3.0 .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2958 To unsubscr

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #58

2012-03-20 Thread Jenkins oVirt Server
See Changes: [mkolesni] core: Enable live snapshot only for compatible DCs -- [...truncated 1903 lines...] [INFO] WEB-INF/web.xml already added, skipping [INFO] [install:install {execution:

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user-gwtp - Build # 361 - Failure!

2012-03-20 Thread Jenkins oVirt Server
ovirt_engine_gwt_user-gwtp - Build # 361 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user-gwtp/361/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] Change in ovirt-engine[master]: core : Adding support for multiple storage domains at AddVmP...

2012-03-20 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Adding support for multiple storage domains at AddVmPoolWithVmsCommand .. core : Adding support for multiple storage domains at AddVmPoolWithVms

[Engine-patches] Change in ovirt-engine[master]: core : Adding support for multiple storage domains at AddVmP...

2012-03-20 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Adding support for multiple storage domains at AddVmPoolWithVmsCommand .. Patch Set 4: Verified; Looks good to me, approved rebase -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: core : Adding support for multiple storage domains at AddVmP...

2012-03-20 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Adding support for multiple storage domains at AddVmPoolWithVmsCommand .. Patch Set 3: Looks good to me, approved rebase -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Error in serach jump to wrong tab

2012-03-20 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Error in serach jump to wrong tab .. webadmin: Error in serach jump to wrong tab no bz It happend because IsSearchStringMatch procedure wasn't

[Engine-patches] Change in ovirt-engine[master]: webadmin: Error in serach jump to wrong tab

2012-03-20 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Error in serach jump to wrong tab .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2954 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: webadmin: Error in serach jump to wrong tab

2012-03-20 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Error in serach jump to wrong tab .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2954 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: limit setupnetworks to cluster 3.1 version

2012-03-20 Thread rgolan
Hello Omer Frenkel, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/2958 to review the following change. Change subject: core: limit setupnetworks to cluster 3.1 version .. core: limit setupnetworks

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-20 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: engine-core: SyntaxCheckerFactory cleanup

2012-03-20 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine-core: SyntaxCheckerFactory cleanup .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2822 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core : Adding support for multiple storage domains at AddVmP...

2012-03-20 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Adding support for multiple storage domains at AddVmPoolWithVmsCommand .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/2894 To unsubs

[Engine-patches] Change in ovirt-engine[master]: core: Enable live snapshot only for compatible DCs

2012-03-20 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Enable live snapshot only for compatible DCs .. core: Enable live snapshot only for compatible DCs Live snapshot is an SPM operation, so need to ch

[Engine-patches] Change in ovirt-engine[master]: core: Enable live snapshot only for compatible DCs

2012-03-20 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Enable live snapshot only for compatible DCs .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2944 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core : Adding support for multiple storage domains at AddVmP...

2012-03-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Adding support for multiple storage domains at AddVmPoolWithVmsCommand .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for snapshot while stateles

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Add validation for snapshot while stateles .. Patch Set 2: Verified Also added message in case VM has stateless snapshot left-over -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Enable live snapshot only for compatible DCs

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Enable live snapshot only for compatible DCs .. Patch Set 2: Verified Now the correct value is sent -- To view, visit http://gerrit.ovirt.org/2944 To unsu

[Engine-patches] Change in ovirt-engine[master]: webadmin: Error in serach jump to wrong tab

2012-03-20 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Error in serach jump to wrong tab .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2954 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Fix update disk after image_vm_map removal

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix update disk after image_vm_map removal .. Patch Set 1: Verified Tested edit disk and activate/deactivate now doesn't fail can do action -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: core: Fix update disk after image_vm_map removal

2012-03-20 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Fix update disk after image_vm_map removal .. core: Fix update disk after image_vm_map removal The check for old disk was not correct after removal of ima

[Engine-patches] Change in ovirt-engine[master]: core: changeCD and changeFloppy API calls should support new...

2012-03-20 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: changeCD and changeFloppy API calls should support new devices layout .. core: changeCD and changeFloppy API calls should support new devices layout It was

[Engine-patches] Change in ovirt-engine[master]: core: Further generalize MultiValueMapUtils

2012-03-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Further generalize MultiValueMapUtils .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2900 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmsByImageGuidQuery

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: new GetVmsByImageGuidQuery .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/2934 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: Fix VmDAO.getForImage to return multiple VMs

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix VmDAO.getForImage to return multiple VMs .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/2933 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core : Fixing NullPointer at MoveOrCopyDiskCommand

2012-03-20 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Fixing NullPointer at MoveOrCopyDiskCommand .. Patch Set 2: Verified; Looks good to me, approved rebase -- To view, visit http://gerrit.ovirt.org/2935 T

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup RunVMParams

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup RunVMParams .. Patch Set 2: (1 inline comment) File backend/manager/modules/common/src/main/

[Engine-patches] Change in ovirt-engine[master]: core: Further generalize MultiValueMapUtils

2012-03-20 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Further generalize MultiValueMapUtils .. core: Further generalize MultiValueMapUtils Add support to MultiValueMapUtils for other collection types

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. Patch Set 4: I have another question - should the entities participate in our compensation mechanis

[Engine-patches] Change in ovirt-engine[master]: core: Further generalize MultiValueMapUtils

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Further generalize MultiValueMapUtils .. Patch Set 5: Verified Answered yzaslavs' review. -- To view, visit http://gerrit.ovirt.org/2900 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: Fixup NPEs

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fixup NPEs .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2914 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: Enable live snapshot only for compatible DCs

2012-03-20 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Enable live snapshot only for compatible DCs .. Patch Set 1: (1 inline comment) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup VmTemplateDAODbFacadeImpl

2012-03-20 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Cleanup VmTemplateDAODbFacadeImpl .. core: Cleanup VmTemplateDAODbFacadeImpl Clean up VmTemplateDAODbFacadeImpl. Use a static instance of the row mapper,

[Engine-patches] Change in ovirt-engine[master]: core : Adding support for multiple storage domains at AddVmP...

2012-03-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Adding support for multiple storage domains at AddVmPoolWithVmsCommand .. Patch Set 2: (3 inline comments) .

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-20 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. Patch Set 4: Gluster entities will not participate in compensation. -- To view, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in RemoveBondCommand

2012-03-20 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Fix potential NPE in RemoveBondCommand .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2907 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: engine: Adding test for VdcQueryType

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Adding test for VdcQueryType .. Patch Set 2: (1 inline comment) File backend/manager/modules/bll/sr

[Engine-patches] Change in ovirt-engine[master]: core: Fix illegal images handling

2012-03-20 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix illegal images handling .. Patch Set 2: Verified; Looks good to me, approved Just rebased, ack (+2) by yzaslavs -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Use new MultiValueMapUtils

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use new MultiValueMapUtils .. Patch Set 4: Verified rebased. -- To view, visit http://gerrit.ovirt.org/2901 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for snapshot while stateles

2012-03-20 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Add validation for snapshot while stateles .. core: Add validation for snapshot while stateles Snapshot can't be taken while VM is running in stateless mo

[Engine-patches] Change in ovirt-engine[master]: core: Fix illegal images handling

2012-03-20 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix illegal images handling .. core: Fix illegal images handling Illegal images should be deleted from DB each time we switch active snapshot sinc

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup VmDAODbFacadeImpl

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup VmDAODbFacadeImpl .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/2932 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core : Fixing NullPointer at MoveOrCopyDiskCommand

2012-03-20 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing NullPointer at MoveOrCopyDiskCommand .. core : Fixing NullPointer at MoveOrCopyDiskCommand The following patch will fix a NullPointerExce

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent exception on install dialog when no host o...

2012-03-20 Thread achub
Alexey Chub has uploaded a new change for review. Change subject: webadmin: Prevent exception on install dialog when no host os. .. webadmin: Prevent exception on install dialog when no host os. Change-Id: If6289272a7320933f629f

[Engine-patches] Change in ovirt-engine[master]: core: Fix VmDAO.getForImage to return multiple VMs

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix VmDAO.getForImage to return multiple VMs .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/2933 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Enable live snapshot only for compatible DCs

2012-03-20 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Enable live snapshot only for compatible DCs .. core: Enable live snapshot only for compatible DCs Live snapshot is an SPM operation, so need to check tha

[Engine-patches] Change in ovirt-engine[master]: core: Use new MultiValueMapUtils

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use new MultiValueMapUtils .. Patch Set 5: Verified Fixed merge conflicts with bd71516c1537230155b53b6e3a104122ba117e29 -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: userportal: Improve login process

2012-03-20 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: userportal: Improve login process .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/2843 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: userportal: Improve login process

2012-03-20 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: Improve login process .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2843 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmsByImageGuidQuery

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: new GetVmsByImageGuidQuery .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/2934 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: engine: Add quota name to handlers

2012-03-20 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Add quota name to handlers .. engine: Add quota name to handlers Add quota name to VM handler and VM template handlers since this is a transient

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup VmDAODbFacadeImpl

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup VmDAODbFacadeImpl .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/2932 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core : Fixing ImportVm

2012-03-20 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core : Fixing ImportVm .. core : Fixing ImportVm At importVm we should call endAction of imported images, the fix is adding a call for that Change-Id: I

[Engine-patches] Change in ovirt-engine[master]: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool

2012-03-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/2949 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool

2012-03-20 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool .. core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool Moved these constants from VmDAOTest to FixturesTool so

[Engine-patches] Change in ovirt-engine[master]: engine: Add quota name to handlers (BZ804940)

2012-03-20 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: engine: Add quota name to handlers (BZ804940) .. engine: Add quota name to handlers (BZ804940) https://bugzilla.redhat.com/show_bug.cgi?id=804940 Add quota name

[Engine-patches] Change in ovirt-engine[master]: core : Fixing ExportVmCommand

2012-03-20 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: core : Fixing ExportVmCommand .. core : Fixing ExportVmCommand Error is during coping one of the images we did not stop the whole operation at case of failure

[Engine-patches] Change in ovirt-engine[master]: core : Fixing ExportVmCommand

2012-03-20 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core : Fixing ExportVmCommand .. core : Fixing ExportVmCommand Error is during coping one of the images we did not stop the whole operation at case of fa

[Engine-patches] Change in ovirt-engine[master]: engine: Add quota name to handlers

2012-03-20 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Add quota name to handlers .. Patch Set 3: Verified; Looks good to me, approved Ack by emesika -- To view, visit http://gerrit.ovirt.org/2948 To unsubscr

  1   2   >