Mike Kolesnik has posted comments on this change. Change subject: engine: Adding test for VdcQueryType ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractQueryTest.java Line 83: assertNotSame(VdcQueryType.Unknown, TestHelperQueriesCommandType.getQueryTypeFieldValue(query)); Can you add a message stating that the query can't be found in the enum, so it's easier to understand what the failure means? -- To view, visit http://gerrit.ovirt.org/2438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6591190bc5f4a7d9445eea1ecd34da0c79564e25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
