Mike Kolesnik has posted comments on this change. Change subject: core: Fix VmDAO.getForImage to return multiple VMs ......................................................................
Patch Set 4: (1 inline comment) Since Disk id is not image id, isn't it better to look by disk ID only (it is actually not this method, but another one)? .................................................... File backend/manager/dbscripts/create_views.sql Line 418: INNER JOIN images ON images.image_group_id = vd.device_id AND images.active; Need to specify active = TRUE for better portability? -- To view, visit http://gerrit.ovirt.org/2933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7100a7aa15524d35f664b49248e5a37cbfb6a32c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
