Mike Kolesnik has posted comments on this change. Change subject: core: Use new MultiValueMapUtils ......................................................................
Patch Set 6: (2 inline comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java Line 84 Lovely piece of code indeed, this should be submitted to Darwin awards :) Line 84: MultiValueMapUtils.addToMap(new Guid(vm.getrun_on_vds().toString()), Perhaps instead of create new guid each time, it is better to change the map key signature to NGuid, or use NGuid's getValue() method (which i think is less good in this case, but better than creating it from string.. -- To view, visit http://gerrit.ovirt.org/2901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id13ee9515000a181fa756dbb1bfebc695079d150 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
