Yair Zaslavsky has posted comments on this change.
Change subject: core : Adding support for multiple storage domains at
AddVmPoolWithVmsCommand
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 49: public static void fillImagesMapBasedOnTemplate(VmTemplate
template,
I would appreciate some comments here on the two added methods.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 123: ACTION_TYPE_FAILED_MISSED_STORAGES_FOR_SOME_DISKS=Cannot ${action}
${type}. Provided destination storage domains doesn't match for provided disks.
should be don't , not doesn't.
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 248: ACTION_TYPE_FAILED_MISSED_STORAGES_FOR_SOME_DISKS=Cannot ${action}
${type}. Provided destination storage domains doesn't match for provided disks.
see previous comments.
--
To view, visit http://gerrit.ovirt.org/2894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d4992f9d7fc24569044c84b9d524683194d5461
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
