[Engine-patches] [oVirt Jenkins] ovirt_engine_purge_maven_repo - Build # 66 - Still Failing!

2012-03-11 Thread Jenkins oVirt Server
ovirt_engine_purge_maven_repo - Build # 66 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_purge_maven_repo/66/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.o

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 328 - Failure!

2012-03-11 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 328 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/328/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listi

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: Fixing MoveOrCopyImageGroup to support n...

2012-03-11 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: DO NOT SUBMIT core: Fixing MoveOrCopyImageGroup to support new param fields .. Patch Set 4: Please review after the local merge I had to perform. In addition,

[Engine-patches] Change in ovirt-engine[master]: core: adding containers to store VM device data mapping for ...

2012-03-11 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: adding containers to store VM device data mapping for import and export .. Patch Set 1: (2 inline comments)

[Engine-patches] Change in ovirt-engine[master]: core: Adding general OVF constants

2012-03-11 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Adding general OVF constants .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/2710 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core : Fixing RemoveVmTemplateCommand in order to work with ...

2012-03-11 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Fixing RemoveVmTemplateCommand in order to work with multiple storage domains .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view,

[Engine-patches] Change in ovirt-engine[master]: core : Fixing RemoveVmTemplateCommand in order to work with ...

2012-03-11 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing RemoveVmTemplateCommand in order to work with multiple storage domains .. core : Fixing RemoveVmTemplateCommand in order to work with mul

[Engine-patches] Change in ovirt-engine[master]: core: setting template interface with new Id only when exist...

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: setting template interface with new Id only when existing is null .. core: setting template interface with new Id only when existing is null Template interf

[Engine-patches] Change in ovirt-engine[master]: core: setting interface with new Id only when existing is nu...

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: setting interface with new Id only when existing is null .. core: setting interface with new Id only when existing is null Interface Id should be taken from

[Engine-patches] Change in ovirt-engine[master]: core: Adding vm interfaces to OVF references

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding vm interfaces to OVF references .. core: Adding vm interfaces to OVF references Interfaces should be passed in the same manner as images are passed in

[Engine-patches] Change in ovirt-engine[master]: core: set vm devices data on template creation

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: set vm devices data on template creation .. core: set vm devices data on template creation Sets vm device mapping data when a template is created. Change-Id

[Engine-patches] Change in ovirt-engine[master]: core: adding containers to store VM device data mapping for ...

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: adding containers to store VM device data mapping for import and export .. core: adding containers to store VM device data mapping for import and export Add

[Engine-patches] Change in ovirt-engine[master]: core: adding helper functions that handles vm device mapping...

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: adding helper functions that handles vm device mapping data .. core: adding helper functions that handles vm device mapping data Adding the basic functional

[Engine-patches] Change in ovirt-engine[master]: core: fixing specParams innitialization

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: fixing specParams innitialization .. core: fixing specParams innitialization Initialize specParams as an empty string rather than null. Change-Id: I39e66812

[Engine-patches] Change in ovirt-engine[master]: core: adding CD and OTHER types to OvfHardware enum

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: adding CD and OTHER types to OvfHardware enum .. core: adding CD and OTHER types to OvfHardware enum Extending the enum to represent CD and OTHER type. OTHER

[Engine-patches] Change in ovirt-engine[master]: core: setting vm devices data upon Export

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: setting vm devices data upon Export .. core: setting vm devices data upon Export Setting the vm device mapping data when export VM is called. Change-Id: Ibf

[Engine-patches] Change in ovirt-engine[master]: core: add needed classes to GWT

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: add needed classes to GWT .. core: add needed classes to GWT Add classes used by Stable Device Addresses feature to GWT. Change-Id: I222db66b537c4602ab91347

[Engine-patches] Change in ovirt-engine[master]: core: Adding general OVF constants

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Adding general OVF constants .. core: Adding general OVF constants Adding constants used by OVF generation. Change-Id: Id6f26cf23b009481495acc857f036faff6c1

[Engine-patches] Change in ovirt-engine[master]: core : Adding functionality for moving and coping disks of v...

2012-03-11 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Adding functionality for moving and coping disks of vm/templates .. core : Adding functionality for moving and coping disks of vm/templates The

[Engine-patches] Change in ovirt-engine[master]: core : Adding functionality for moving and coping disks of v...

2012-03-11 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Adding functionality for moving and coping disks of vm/templates .. Patch Set 8: Verified; Looks good to me, approved already acked -- To view, visit h

[Engine-patches] Change in ovirt-iso-uploader[master]: tools: Make system and REST API rebase

2012-03-11 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: tools: Make system and REST API rebase .. Patch Set 2: (9 inline comments) All comments shd be addressed including ws issues in next patch. ..

[Engine-patches] Change in ovirt-engine[master]: core: Add console reconnect permission

2012-03-11 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Add console reconnect permission .. Patch Set 2: I know that the permission check should be done in a different way now. Just wanted to have everything a

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user-gwtp - Build # 285 - Failure!

2012-03-11 Thread Jenkins oVirt Server
ovirt_engine_gwt_user-gwtp - Build # 285 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user-gwtp/285/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: Introducing new method in DiskImageDAO

2012-03-11 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: DO NOT SUBMIT core: Introducing new method in DiskImageDAO .. Patch Set 6: This method is used only from the command, therefore I think you comment is irreleva

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: implement support for documentation of netsed colle...

2012-03-11 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: codegen: implement support for documentation of netsed collection based args .. codegen: implement support for documentation of netsed collection ba

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: implement support for documentation of netsed colle...

2012-03-11 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: codegen: implement support for documentation of netsed collection based args .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://g

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: implement support for documentation of netsed colle...

2012-03-11 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: codegen: implement support for documentation of netsed collection based args .. codegen: implement support for documentation of netsed collection based args

[Engine-patches] Change in ovirt-engine[master]: ovirt-engine: Use config value ManagementNetwork

2012-03-11 Thread danny . ran
Danny Rankevich has submitted this change and it was merged. Change subject: ovirt-engine: Use config value ManagementNetwork .. ovirt-engine: Use config value ManagementNetwork The config value ManagementNetwork already exists

[Engine-patches] Change in ovirt-engine[master]: ovirt-engine: Use config value ManagementNetwork

2012-03-11 Thread danny . ran
Danny Rankevich has posted comments on this change. Change subject: ovirt-engine: Use config value ManagementNetwork .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1412 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: history: added dwh events to audit log (#772925)

2012-03-11 Thread masayag
Moti Asayag has posted comments on this change. Change subject: history: added dwh events to audit log (#772925) .. Patch Set 1: (3 inline comments) where is the code that insert the events to the audit_log table ? (the code w

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 101 - Failure!

2012-03-11 Thread Jenkins oVirt Server
ovirt_engine_gwt_admin - Build # 101 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/101/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: core : Adding functionality for moving and coping disks of v...

2012-03-11 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core : Adding functionality for moving and coping disks of vm/templates .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2555

[Engine-patches] Change in ovirt-engine[master]: restapi: Add console reconnect

2012-03-11 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Add console reconnect .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/819 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core : Fixing RemoveVmTemplateCommand in order to work with ...

2012-03-11 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core : Fixing RemoveVmTemplateCommand in order to work with multiple storage domains .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Add disk name and description

2012-03-11 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add disk name and description .. core: Add disk name and description Adding disk name and description to disk. For now this patch will not contatin

[Engine-patches] Change in ovirt-engine[master]: core: Add disk name and description

2012-03-11 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add disk name and description .. Patch Set 8: Verified; Looks good to me, approved Acked by ofrenkel -- To view, visit http://gerrit.ovirt.org/2598 To unsu

[Engine-patches] Change in ovirt-engine[master]: core: Add basic search for disks

2012-03-11 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add basic search for disks .. core: Add basic search for disks Adding support for basic search to diskImage. For now only adding API to support get

[Engine-patches] Change in ovirt-engine[master]: core: Add basic search for disks

2012-03-11 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add basic search for disks .. Patch Set 9: Verified; Looks good to me, approved Acked by ofrenkel -- To view, visit http://gerrit.ovirt.org/2534 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: Tests for new query

2012-03-11 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: DO NOT SUBMIT core: Tests for new query .. Patch Set 9: Took me about 8 resends to answer Allon, sorry for that - I will perform the squash. -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: core : Adding functionality for moving and coping disks of v...

2012-03-11 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Adding functionality for moving and coping disks of vm/templates .. Patch Set 6: (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: core : Adding functionality for moving and coping disks of v...

2012-03-11 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core : Adding functionality for moving and coping disks of vm/templates .. Patch Set 6: (1 inline comment) F

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: Adding logic of query

2012-03-11 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: DO NOT SUBMIT core: Adding logic of query .. Patch Set 11: (5 inline comments) File backend/manager/module

[Engine-patches] Change in ovirt-engine[master]: core: Add disk name and description

2012-03-11 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Add disk name and description .. Patch Set 7: Looks good to me, approved if you need to change the upgrade script number then change its name as well to "a

[Engine-patches] Change in ovirt-engine[master]: core: Add basic search for disks

2012-03-11 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Add basic search for disks .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2534 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: add canDoActions on several Vm flows for VmNetworks

2012-03-11 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: add canDoActions on several Vm flows for VmNetworks .. Patch Set 11: (1 inline comment) File backend/mana

[Engine-patches] Change in ovirt-engine[master]: webadmin: Show ISOs for oVirt node in more readable manner.

2012-03-11 Thread achub
Alexey Chub has uploaded a new change for review. Change subject: webadmin: Show ISOs for oVirt node in more readable manner. .. webadmin: Show ISOs for oVirt node in more readable manner. Change-Id: I38dfbf8ded8ec1ff4ae3e5e19ef

[Engine-patches] Change in ovirt-dwh[master]: etl: parameterized error events resend time.

2012-03-11 Thread ydary
Yaniv Dary has uploaded a new change for review. Change subject: etl: parameterized error events resend time. .. etl: parameterized error events resend time. Change-Id: I31a537144c974b7b29cf10c8ea050024e5410d45 --- M data-wareh

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 322 - Fixed!

2012-03-11 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 322 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/322/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: REST: translate VdcFault in case the error messages are empt...

2012-03-11 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: REST: translate VdcFault in case the error messages are empty .. Patch Set 2: (1 inline comment) File b

[Engine-patches] Change in ovirt-engine[master]: REST: add vm_network and bridged propertes

2012-03-11 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: REST: add vm_network and bridged propertes .. Patch Set 13: (1 inline comment) File backend/manager/mod

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latets api

2012-03-11 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latets api .. sdk: rebase to latets api - added arguments for UPDATE methods - implemented ars doc support for collection based argum

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latets api

2012-03-11 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: rebase to latets api .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2705 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: support actions on collection

2012-03-11 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: codegen: support actions on collection .. codegen: support actions on collection Change-Id: Id3720642cb3267d1bdd1e3eb66d3aeff2c5e0b10 --- M src/code

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: support actions on collection

2012-03-11 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: codegen: support actions on collection .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2704 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: refactor documentation for collection based argumen...

2012-03-11 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: codegen: refactor documentation for collection based arguments .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: refactor documentation for collection based argumen...

2012-03-11 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: codegen: refactor documentation for collection based arguments .. codegen: refactor documentation for collection based arguments Change-Id: I722b052

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: refactor documentation for collection based argumen...

2012-03-11 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: codegen: refactor documentation for collection based arguments .. codegen: refactor documentation for collection based arguments Change-Id: I722b05250cae97b

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latets api

2012-03-11 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: rebase to latets api .. sdk: rebase to latets api - added arguments for UPDATE methods - implemented ars doc support for collection based arguments - a

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: support actions on collection

2012-03-11 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: codegen: support actions on collection .. codegen: support actions on collection Change-Id: Id3720642cb3267d1bdd1e3eb66d3aeff2c5e0b10 --- M src/codegen/coll

[Engine-patches] Change in ovirt-engine[master]: core : Adding functionality for moving and coping disks of v...

2012-03-11 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Adding functionality for moving and coping disks of vm/templates .. Patch Set 6: (4 inline comments) ...

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: New mechanism in CommandBase (rollback u...

2012-03-11 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: New mechanism in CommandBase (rollback using command) .. Patch Set 7: (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: core: Adding quota id when updating image

2012-03-11 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Adding quota id when updating image .. Patch Set 2: Verified; Looks good to me, approved Acked by ofrenkel -- To view, visit http://gerrit.ovirt.org/2614 T

[Engine-patches] Change in ovirt-engine[master]: core : Adding functionality for moving and coping disks of v...

2012-03-11 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core : Adding functionality for moving and coping disks of vm/templates .. Patch Set 6: (4 inline comments)

[Engine-patches] Change in ovirt-engine[master]: core: Remove unnecessary methods in ImagesHandler

2012-03-11 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Remove unnecessary methods in ImagesHandler .. core: Remove unnecessary methods in ImagesHandler These methods are no longer needed, so deleting t

[Engine-patches] Change in ovirt-engine[master]: core: Remove unnecessary methods in ImagesHandler

2012-03-11 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Remove unnecessary methods in ImagesHandler .. Patch Set 4: Verified; Looks good to me, approved Just rebased, ack (+2) by ofrenkel -- To view, visit http

[Engine-patches] Change in ovirt-engine[master]: core: Refactor preview & restore snapshot commands

2012-03-11 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Refactor preview & restore snapshot commands .. core: Refactor preview & restore snapshot commands Refactor the TryBackToSnapshot and RestoreFromS

[Engine-patches] Change in ovirt-engine[master]: core: Refactor preview & restore snapshot commands

2012-03-11 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Refactor preview & restore snapshot commands .. Patch Set 4: Verified; Looks good to me, approved Just rebased, ack (+2) by ofrenkel -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: Add basic search for disks

2012-03-11 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Add basic search for disks .. Patch Set 8: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/2534 To unsubs

[Engine-patches] Change in ovirt-engine[master]: core: add canDoActions on several Vm flows for VmNetworks

2012-03-11 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: add canDoActions on several Vm flows for VmNetworks .. Patch Set 12: I do not understand why didn't you use just the keys set. -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: minor javadoc update

2012-03-11 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: minor javadoc update .. core: minor javadoc update Change-Id: Id9df8289efa7da53c494f8ea743e5e67ca1f7d72 --- M backend/manager/modules/vdsbroker/src/main/java

[Engine-patches] Change in ovirt-engine[master]: core: Add disk name and description

2012-03-11 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add disk name and description .. Patch Set 7: Verified Only rebase -- To view, visit http://gerrit.ovirt.org/2598 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: Add basic search for disks

2012-03-11 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add basic search for disks .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/2534 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: core: Add basic search for disks

2012-03-11 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add basic search for disks .. Patch Set 8: Changes from last patch: 1. Adding status to search 2. Fix typos in comments 3. Changed test for disk auto comple

[Engine-patches] Change in ovirt-engine[master]: ovirt-engine: Use config value ManagementNetwork

2012-03-11 Thread rgolan
Roy Golan has posted comments on this change. Change subject: ovirt-engine: Use config value ManagementNetwork .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1412 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: Adding logic of query

2012-03-11 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Adding logic of query .. Patch Set 11: I would prefer that you didn't submit this (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: Adding logic of query

2012-03-11 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Adding logic of query .. Patch Set 11: (5 inline comments) Please run formatter on code

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 321 - Still Unstable!

2012-03-11 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 321 - Still Unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/321/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailma

[Engine-patches] Change in ovirt-engine[master]: core: mock config for SetupNetworksHelperTest

2012-03-11 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: mock config for SetupNetworksHelperTest .. core: mock config for SetupNetworksHelperTest mock the NetworkUtils usage of config to fetch the management

[Engine-patches] Change in ovirt-engine[master]: core: mock config for SetupNetworksHelperTest

2012-03-11 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: mock config for SetupNetworksHelperTest .. Patch Set 2: Verified; Looks good to me, approved already acked -- To view, visit http://gerrit.ovirt.org/2701 To u

[Engine-patches] Change in ovirt-engine[master]: core: mock config for SetupNetworksHelperTest

2012-03-11 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: mock config for SetupNetworksHelperTest .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/2701 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: core: mock config for SetupNetworksHelperTest

2012-03-11 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: mock config for SetupNetworksHelperTest .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2701 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: mock config for SetupNetworksHelperTest

2012-03-11 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: mock config for SetupNetworksHelperTest .. core: mock config for SetupNetworksHelperTest mock the NetworkUtils usage of config to fetch the management network

[Engine-patches] Change in ovirt-engine[master]: core: mock config for SetupNetworksHelperTest

2012-03-11 Thread rgolan
Roy Golan has abandoned this change. Change subject: core: mock config for SetupNetworksHelperTest .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/2700 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: refactor CollectVdsNetworkDataVDSCommand

2012-03-11 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: refactor CollectVdsNetworkDataVDSCommand .. core: refactor CollectVdsNetworkDataVDSCommand a small refactor as a first step to break a long method to

[Engine-patches] Change in ovirt-engine[master]: core: refactor CollectVdsNetworkDataVDSCommand

2012-03-11 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: refactor CollectVdsNetworkDataVDSCommand .. Patch Set 12: Verified; Looks good to me, approved rebase. already acked -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: Introducing new method in DiskImageDAO

2012-03-11 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Introducing new method in DiskImageDAO .. Patch Set 6: This method should support filtering, so that the query can be safely called from use

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: Introducing new query type

2012-03-11 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Introducing new query type .. Patch Set 10: (1 inline comment) File backend/manager/mod

[Engine-patches] Change in ovirt-engine[master]: core: mock config for SetupNetworksHelperTest

2012-03-11 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: mock config for SetupNetworksHelperTest .. core: mock config for SetupNetworksHelperTest mock the NetworkUtils usage of config to fetch the management network

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: Adding snapshotExists to SnapshotValidat...

2012-03-11 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Adding snapshotExists to SnapshotValidator .. Patch Set 5: (1 inline comment) Please add unit tests

[Engine-patches] Change in ovirt-engine[master]: restapi: define maven-jaxb22-plugin.version explicitly

2012-03-11 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: define maven-jaxb22-plugin.version explicitly .. restapi: define maven-jaxb22-plugin.version explicitly since backend/manager/modules/rest

[Engine-patches] Change in ovirt-engine[master]: restapi: define maven-jaxb22-plugin.version explicitly

2012-03-11 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: define maven-jaxb22-plugin.version explicitly .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2695 To

[Engine-patches] Change in ovirt-engine[master]: restapi: define maven-jaxb22-plugin.version explicitly

2012-03-11 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: restapi: define maven-jaxb22-plugin.version explicitly .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2695 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: restapi: remove redundant url param

2012-03-11 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: remove redundant url param .. restapi: remove redundant url param Update-Vm does not require a url parameter; remove this statement from .y

[Engine-patches] Change in ovirt-engine[master]: restapi: remove redundant url param

2012-03-11 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: remove redundant url param .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2697 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Add basic search for disks

2012-03-11 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add basic search for disks .. Patch Set 7: Main chages from last patch were in DiskImageConditionFieldAutoCompleter. Based on http://pad.engineering.redhat.

[Engine-patches] Change in ovirt-engine[master]: core: Add disk name and description

2012-03-11 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add disk name and description .. Patch Set 6: Change disk_name to disk_alias, also upgraded script to 630 -- To view, visit http://gerrit.ovirt.org/2598 To

[Engine-patches] Change in ovirt-engine[master]: core: InitVdsOnUp - init virt-related resources only on virt...

2012-03-11 Thread oourfali
Oved Ourfali has uploaded a new change for review. Change subject: core: InitVdsOnUp - init virt-related resources only on virt clusters .. core: InitVdsOnUp - init virt-related resources only on virt clusters This commit chang

[Engine-patches] Change in ovirt-engine[master]: DO NOT SUBMIT core: New mechanism in CommandBase (rollback u...

2012-03-11 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: DO NOT SUBMIT core: New mechanism in CommandBase (rollback using command) .. Patch Set 7: (8 inline comments) .

[Engine-patches] Change in ovirt-engine[master]: core: removing async tasks and compensation data on upgrade

2012-03-11 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: removing async tasks and compensation data on upgrade .. core: removing async tasks and compensation data on upgrade Since async tasks and compensation data

[Engine-patches] Change in ovirt-engine[master]: restapi: remove redundant url param

2012-03-11 Thread oliel
ol...@redhat.com has uploaded a new change for review. Change subject: restapi: remove redundant url param .. restapi: remove redundant url param Change-Id: I01687db9c5f74e7b9d37665ef7d72bfbb3f0bd29 --- M backend/manager/module

  1   2   >