Michael Pasternak has posted comments on this change. Change subject: REST: translate VdcFault in case the error messages are empty ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java Line 146: throw new BackendFailureException(localize(Arrays.asList(result.getFault().getError().name()))); why would we delegate internal BE/VDSM dialect rather than handle it in BE and return appropriate message to client? BTW vdsm errors cannot be localised. -- To view, visit http://gerrit.ovirt.org/2054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c3bd87ced4d44f5f656a0f24c9928ace43cb39b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
