Keith Robertson has posted comments on this change.
Change subject: tools: Make system and REST API rebase
......................................................................
Patch Set 2: (9 inline comments)
All comments shd be addressed including ws issues in next patch.
....................................................
File Makefile
Line 18: NAME = engine-iso-uploader
Meh, just at typo. I'll fix it in my next patch.
Line 41: done; \
I tried that originally but it didn't work on some of my boxes. So, I dumbed
it down a bit. KISS principle. You did; however, highlight the fact that the
second find should be .pyo and not .pyc.
Line 81: chmod 755
$(PREFIX)/usr/share/ovirt-engine/iso-uploader/engine-iso-uploader.py
I like it. In next patch.
Line 85: chmod 600 $(PREFIX)/etc/ovirt-engine/isouploader.conf
I like it. In next patch.
....................................................
File packaging/spec/iso-uploader.spec.in
Line 2: %global __os_install_post %(echo '%{__os_install_post}' | sed -e
's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g')
Removed.
Line 31: %{__rm} -rf %{buildroot}
Removed.
Line 37: %doc %{_mandir}/man8/engine-iso-uploader.8.gz
Fixed in next patch.
....................................................
File src/engine-iso-uploader.py
Line 347: # The API has not been intialized yet.
Fixed in next patch
Line 370: logging.error(_("Unable to connect to REST API.
Message: %s" % e))
Yeah, mistake. Fixed in next patch.
--
To view, visit http://gerrit.ovirt.org/2674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63579697dff18a8e9adc52207906c0144fb89722
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
