Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Adding logic of query
......................................................................
Patch Set 11: (5 inline comments)
Please run formatter on code
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java
Line 37: if (configuration != null) {
What if configuration is empty?
Line 47: protected void markImagesIllegalIfNotInDb(VM result) {
Shouldn't VM variable be named 'vm'?
Line 48: // Gets all images for the VM as stored in DB.
This should be in the javadoc of the method.
Line 52: List<DiskImage> imagesInDbList =
No need for List suffix in variable name
Line 54: Set<Guid> existingImages = new HashSet<Guid>();
Why do you need set here?
Why would double image return, and even then list has contains method.
Set is very expansive object which I'm not sure we need here.
--
To view, visit http://gerrit.ovirt.org/2295
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3155134ff9ad89bb50ec4baa8fd393844f80bb32
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
