Moti Asayag has posted comments on this change.
Change subject: history: added dwh events to audit log (#772925)
......................................................................
Patch Set 1: (3 inline comments)
where is the code that insert the events to the audit_log table ? (the code
which produces events to ovirt-engine)
....................................................
File backend/manager/dbscripts/upgrade/03_01_0620_add_dwh_to_event_map.sql
Line 1: insert into event_map(event_up_name, event_down_name)
values('DWH_STOPPED', 'DWH_STARTED');
please note the 0620 is already taken.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 530: DWH_ERROR(9704),
what is the purpose of the gaps ?
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
Line 719:
please remove the spaces.
--
To view, visit http://gerrit.ovirt.org/2631
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dcddd24713dbbc41646c830cc1d16bde58c3ccf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Test <motiasa...@yahoo.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
