Hello Adam Litke,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/2272
to review the following change.
Change subject: Add more detailed memory statistics function to guest agent.
..
Add more detail
Yair Zaslavsky has posted comments on this change.
Change subject: core : Fixing brokem import scenarious
..
Patch Set 1:
Several questions -
1. When are we facing this issues upon disk image insertions? Is this true for
all s
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 1:
I'm not that good at testing the engine so wait until you get a verified from
someone else before pushing this in
Saggi Mizrahi has uploaded a new change for review.
Change subject: Refactor UpdateVdsGroupCommand
..
Refactor UpdateVdsGroupCommand
I'm a measly python programmer. I can't follow your long invocation
chains and complex conditio
Moti Asayag has posted comments on this change.
Change subject: clean unused member and Linq comments
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2208
To unsubscribe, visit http://gerrit
Muli Salem has abandoned this change.
Change subject: engine-core: Prestarted Vm (6 - Review Only)
..
Patch Set 7: Abandoned
Repushed with a different patch set.
--
To view, visit http://gerrit.ovirt.org/1879
To unsubscribe, v
Muli Salem has abandoned this change.
Change subject: core: Adding canDoAction CommonVmPoolWithVmsCommand
..
Patch Set 2: Abandoned
Repushed with a different patch set.
--
To view, visit http://gerrit.ovirt.org/2001
To unsubsc
Muli Salem has abandoned this change.
Change subject: engine-core: Prestarted Vm (5 - Review Only)
..
Patch Set 6: Abandoned
Repushed with a different patch set.
--
To view, visit http://gerrit.ovirt.org/1878
To unsubscribe, v
Muli Salem has abandoned this change.
Change subject: engine-core: Prestarted Vm (4 - Review Only)
..
Patch Set 8: Abandoned
Repushed with a different patch set.
--
To view, visit http://gerrit.ovirt.org/1800
To unsubscribe, v
Muli Salem has uploaded a new change for review.
Change subject: core: Prestarted Vm (6)
..
core: Prestarted Vm (6)
This patch adds a new canDoAction that validates that the number
of prestarted Vms does not exceed the number of
Muli Salem has uploaded a new change for review.
Change subject: core: Prestarted Vm (4)
..
core: Prestarted Vm (4)
This patch adds the prestarted_vms field to the vm_pools class.
It updates relevant views, stored_procedures, fi
Muli Salem has uploaded a new change for review.
Change subject: core: Prestarted Vm (5)
..
core: Prestarted Vm (5)
1. This patch adds a periodic job that maintains the desired
number of Vms in a Vm Pool. It new config values
so
Muli Salem has uploaded a new change for review.
Change subject: core: Prestarted Vm (3)
..
core: Prestarted Vm (3)
This patch adds an upgrade script to migrate the data in
image_vm_pool_map to the stateless_vm_image_map table.
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing brokem import scenarious
..
core : Fixing brokem import scenarious
The following patch should fix the broken import scenarious.
The fix will add
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota queries
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2141
To unsubscribe, visit htt
Omer Frenkel has posted comments on this change.
Change subject: engine: Fix quota vds group stored procedure
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2114
To unsubscribe, visit http
Douglas Schilling Landgraf has posted comments on this change.
Change subject: VdsInstaller: drop netconsole code
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
notes: upgrade script didn't work for m
Omer Frenkel has posted comments on this change.
Change subject: engine: Quota upgrade script
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2078
To unsubscribe, visit http://gerrit.ovirt.
Omer Frenkel has posted comments on this change.
Change subject: engine: Add consume quota permission to add Tempalte
..
Patch Set 11: (1 inline comment)
File
backend/manage
Douglas Schilling Landgraf has posted comments on this change.
Change subject: VdsInstaller: drop dead usevdcrepo code
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Omer Frenkel has posted comments on this change.
Change subject: engine: Add consume quota permission to add VM
..
Patch Set 11: (5 inline comments)
File
backend/manager/mod
Omer Frenkel has posted comments on this change.
Change subject: engine: Add permission support for Quota consume
..
Patch Set 11: (1 inline comment)
File
backend/manager/mo
Omer Frenkel has posted comments on this change.
Change subject: engine: Refactor permission subject
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2107
To unsubscribe, visit http://gerrit
Omer Frenkel has posted comments on this change.
Change subject: engine:Add quota validation for crateSnapshot
..
Patch Set 11:
this is internal command, no need to quota
--
To view, visit http://gerrit.ovirt.org/2106
To unsub
Omer Frenkel has posted comments on this change.
Change subject: engine:Add quota validation for crateAllSnapshot
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2105
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: make network DAO extend the generic DAO
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2205
To unsubscribe
Omer Frenkel has posted comments on this change.
Change subject: engine:Add quota validation for AddVmFromTemplate
..
Patch Set 11: (1 inline comment)
File
backend/manager/m
Omer Frenkel has posted comments on this change.
Change subject: engine:Add quota validation for RunVmCommand
..
Patch Set 11: (1 inline comment)
File
backend/manager/module
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation for Add Vm Tempalte
..
Patch Set 11: (2 inline comments)
File
backend/manager/m
Yair Zaslavsky has posted comments on this change.
Change subject: core: make network DAO extend the generic DAO
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
...
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core : Fixing import vm scenario
..
core : Fixing import vm scenario
During import vm scenario a source domainId should be added to
image_storage_domai
Yair Zaslavsky has posted comments on this change.
Change subject: core : Fixing import vm scenario
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2260
To unsubscribe, visit http:
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing import vm scenario
..
core : Fixing import vm scenario
During import vm scenario a source domainId should be added to
image_storage_domain map
C
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation for Add Disk to VM
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2101
To unsubscribe, visit h
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation for AddVmCommand
..
Patch Set 11: (4 inline comments)
File
backend/manager/modu
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation support commandBase
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2097
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: engine: Adding fix to quota stored procedure
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2095
To unsubscribe, visit http
Omer Frenkel has posted comments on this change.
Change subject: engine: Add audit log messages to CRUD commands.
..
Patch Set 11: (2 inline comments)
File
backend/manager/m
Omer Frenkel has posted comments on this change.
Change subject: engine: Add audit log messages
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2093
To unsubscribe, visit http://gerrit.ovir
Omer Frenkel has posted comments on this change.
Change subject: engine: Add search support for quota.
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2091
To unsubscribe, visit http://gerr
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota id to vm static
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2088
To unsubscribe, visit http://gerrit.o
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota id to disk image
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2087
To unsubscribe, visit http://gerrit.
Doron Fediuck has submitted this change and it was merged.
Change subject: vds_installer.py: fix os.path.exists() call
..
vds_installer.py: fix os.path.exists() call
Use full path instead of name of program.
Change-Id: Ibd93bd
Doron Fediuck has posted comments on this change.
Change subject: vds_installer.py: fix os.path.exists() call
..
Patch Set 2: Verified; Looks good to me, approved
Rebased patch
--
To view, visit http://gerrit.ovirt.org/2153
To
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota id to VM parameters
..
Patch Set 11:
not sure why this need to be added to the parameter class which is base for ALL
command's parameters...?
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core : Fixing view
..
core : Fixing view
Fixing broken view
Change-Id: Ie88897e3b475ba886330c0dedea16b234d61e0e5
---
M backend/manager/dbscripts/creat
Yair Zaslavsky has posted comments on this change.
Change subject: core : Fixing view
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2257
To unsubscribe, visit http://gerrit.ovirt
Omer Frenkel has posted comments on this change.
Change subject: engine: Remove quota command
..
Patch Set 11: (2 inline comments)
File
backend/manager/modules/bll/src/main/
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing view
..
core : Fixing view
Fixing broken view
Change-Id: Ie88897e3b475ba886330c0dedea16b234d61e0e5
---
M backend/manager/dbscripts/create_views.
Omer Frenkel has posted comments on this change.
Change subject: engine: Add/Edit quota commands
..
Patch Set 11: (1 inline comment)
File
backend/manager/modules/bll/src/mai
Omer Frenkel has posted comments on this change.
Change subject: engine: Add/Edit quota commands
..
Patch Set 11: (6 inline comments)
missing audit log for the commands, but IIRC, it will be in a future patch?
Omer Frenkel has posted comments on this change.
Change subject: engine: Add validation for quota name
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2083
To unsubscribe, visit http://gerr
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota to audit log
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2081
To unsubscribe, visit http://gerrit.ovir
Michael Kublin has submitted this change and it was merged.
Change subject: core : Rollback of mistaken removed code
..
core : Rollback of mistaken removed code
The following commit will revert a mistakenly removed part of db s
Michael Kublin has posted comments on this change.
Change subject: core : Rollback of mistaken removed code
..
Patch Set 1: Verified; Looks good to me, approved
revert to previous code
--
To view, visit http://gerrit.ovirt.org
Michael Kublin has uploaded a new change for review.
Change subject: core : Rollback of mistaken removed code
..
core : Rollback of mistaken removed code
The following commit will revert a mistakenly removed part of db script fo
ovirt_server_gwt_profiles - Build # 168 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_server_gwt_profiles/168/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/l
Omer Frenkel has posted comments on this change.
Change subject: engine: Create default unlimited quota for DC
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2079
To unsubscribe, visit htt
Omer Frenkel has posted comments on this change.
Change subject: engine: Add pre defined roles for consume quota
..
Patch Set 11:
i think the should be called "quota consumer" (please change in sql and code),
also i think it s
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota permission
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2077
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: engine: Add Quota helper class
..
Patch Set 9: Looks good to me, approved
(1 inline comment)
File
backend/m
Vojtech Szocs has uploaded a new change for review.
Change subject: userportal: VM Snapshot sub-tab
..
userportal: VM Snapshot sub-tab
- Extracted VM Snapshot sub-tab content from WebAdmin into GwtCommon
- Used VmSnapshotListMo
Maor Lipchuk has posted comments on this change.
Change subject: core: clean XMl annotations for VdsNetworkInterface
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2206
To unsubscribe, visit http://gerrit.ov
Maor Lipchuk has posted comments on this change.
Change subject: core: clean XMl annotations for VdsNetworkInterface
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2206
To unsubscribe, visi
Michael Kublin has posted comments on this change.
Change subject: core : Fixing regression caused by removing
image_group_storage_domain_table
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/2254
To unsubsc
Michael Kublin has submitted this change and it was merged.
Change subject: core : Fixing regression caused by removing
image_group_storage_domain_table
..
core : Fixing regression caused by removing image_group_storage_domain_
Allon Mureinik has posted comments on this change.
Change subject: core: clean XMl annotations for VdsNetworkInterface
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/22
Omer Frenkel has posted comments on this change.
Change subject: core : Fixing regression caused by removing
image_group_storage_domain_table
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Roy Golan has posted comments on this change.
Change subject: core: clean XMl annotations for VdsNetworkInterface
..
Patch Set 2:
I removed setIsManagement in a later clean-up patche for nob-used members
--
To view, visit http
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing regression caused by removing
image_group_storage_domain_table
..
core : Fixing regression caused by removing image_group_storage_domain_table
T
ol...@redhat.com has posted comments on this change.
Change subject: engine-core: Prestarted Vm (5 - Review Only)
..
Patch Set 6: (1 inline comment)
File
backend/manager/mod
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Missing "Alerts" section in VM general subtab and
status symbol
..
webadmin: Missing "Alerts" section in VM general subtab and status symbol
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Only partial menu options are enabled on first
right-click
..
webadmin: Only partial menu options are enabled on first right-click
https://bu
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: remove gwt from uicommonweb
..
webadmin: remove gwt from uicommonweb
no bz
remove the use of gwt objects from uicommonweb by moving the code
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: remove gwt from uicommonweb
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2224
To unsubscribe, visit h
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Missing "Alerts" section in VM general subtab and
status symbol
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Only partial menu options are enabled on first
right-click
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.
Einav Cohen has posted comments on this change.
Change subject: webadmin: Configure local storage
..
Patch Set 5:
There is a call to RemoveStorageServerConnection after a successful call to
AddStorageServerConnection followed
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Only partial menu options are enabled on first
right-click
..
webadmin: Only partial menu options are enabled on first right-click
https://bugzilla.re
Allon Mureinik has uploaded a new change for review.
Change subject: core: Filter GetUserBySessionIdQuery
..
core: Filter GetUserBySessionIdQuery
Define the query as a user query so it could be called in the User
Portal.
The qu
Vojtech Szocs has uploaded a new change for review.
Change subject: userportal: VM Virtual Disk sub-tab
..
userportal: VM Virtual Disk sub-tab
- Extracted VM Virtual Disk sub-tab content from WebAdmin
into GwtCommon, along wit
Omer Frenkel has posted comments on this change.
Change subject: engine: Add default quota indication field
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2075
To unsubscribe, visit http://
ovirt_engine_dao_unit_tests - Build # 170 - Fixed:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/170/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman
ovirt_engine - Build # 263 - Fixed:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/263/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Allon Mureinik has uploaded a new change for review.
Change subject: core: Extract base class for MLA queries
..
core: Extract base class for MLA queries
Extracted a base class for testing queries that use
GetEntitiesWithPermitt
Allon Mureinik has uploaded a new change for review.
Change subject: core: Filter GetDataCentersWithPermittedActionOnClustersQuery
..
core: Filter GetDataCentersWithPermittedActionOnClustersQuery
Define the query as a user query
Allon Mureinik has uploaded a new change for review.
Change subject: core: Filter GetVmTemplatesWithPermittedActionQuery
..
core: Filter GetVmTemplatesWithPermittedActionQuery
Define the query as a user query so it could be call
Allon Mureinik has uploaded a new change for review.
Change subject: core: Filter GetClustersWithPermittedActionQuery
..
core: Filter GetClustersWithPermittedActionQuery
Define the query as a user query so it could be called in
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing a bug when VM is created from template
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2163
To unsubscribe, vi
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing a bug when VM is created from template
..
Patch Set 4: No score
--
To view, visit http://gerrit.ovirt.org/2163
To unsubscribe, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing a bug when VM is created from template
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2163
To unsub
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: extended -> templates -> events
..
userportal: extended -> templates -> events
Implementation of events subtab of the templates side-tab of
Vojtech Szocs has posted comments on this change.
Change subject: userportal: extended -> templates -> events
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2236
To unsubscribe, v
Vojtech Szocs has posted comments on this change.
Change subject: userportal: extended -> templates -> events
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2236
To unsubscribe, v
Alex Lourie has uploaded a new change for review.
Change subject: Remote DB support - DO NOT MERGE. Added remote db handling
in create_db and co scripts. Added remote db calls to upgrade scripts.
..
Remote DB support - DO NO
ovirt_engine - Build # 262 - Still Failing:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/262/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patche
ovirt_engine - Build # 261 - Still Failing:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/261/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patche
ovirt_engine - Build # 260 - Still Failing:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/260/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patche
ovirt_engine_dao_unit_tests - Build # 169 - Still Failing:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/169/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
1 - 100 of 150 matches
Mail list logo
