Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation for AddVmCommand
......................................................................
Patch Set 11: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 63: private Map<Pair<Guid, Guid>, Double> quotaForStorageConsumption;
can be removed?
Line 343: protected Map<Pair<Guid, Guid>, Double> getQuotaConsumeMap() {
what it means?
Line 525: reduceQuotaCommand(getStorageDomainId().getValue(),
no need to reduce here as this is in the same transaction
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java
Line 162: public Map<Pair<Guid, Guid>, Double>
getQuotaConsumeMap(List<DiskImage> diskImageList) {
please document
--
To view, visit http://gerrit.ovirt.org/2098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2af7b2a1376db99593c42127b172925d8e88a98
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
