Omer Frenkel has posted comments on this change.

Change subject: engine: Remove quota command
......................................................................


Patch Set 11: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java
Line 23:         setStoragePoolId(parameters.getStoragePoolId());
also here, don't see a reason to send sp id if i send quota id

Line 49:         // TODO : Add Check if there are no VMs/images that are part 
of the Quota.
is this implemented in a future patch?
if not, consider open a bug to track this.

--
To view, visit http://gerrit.ovirt.org/2085
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23d9178babf1a725f28ec529ce0b00381a9dd83b
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to