Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation for Add Vm Tempalte
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 263: private Map<Pair<Guid, Guid>, Double>
storageResourceMapForConsume() {
please check if not duplicate with the method in quota helper
Line 358:
QuotaManager.reduceCommandStorageSize(createParams.getStorageDomainId(),
diskImage.getsize(),
i believe this is not needed as all images added in the same transaction
--
To view, visit http://gerrit.ovirt.org/2102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I078095622bd296ec32ef36cbc5eabc67cbcade0f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
