Omer Frenkel has posted comments on this change. Change subject: engine: Add consume quota permission to add VM ......................................................................
Patch Set 11: (5 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java Line 31: setQuotaId(params.getQuotaId()); no need to quota when changing cluster because quota didnt change .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java Line 34: setQuotaId(parameters.getQuotaId()); should be quota per disk Line 164: permissionList = QuotaHelper.addQuotaPermissionSubject(permissionList, getStoragePool(), getQuotaId()); should be quota per disk .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java Line 27: setQuotaId(parameters.getQuotaId()); this is internal command, no need to quota .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java Line 190: return permissionList; i think no need to check permission when freeing from the quota -- To view, visit http://gerrit.ovirt.org/2111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bbc3f969b8a04ad3e4ed229320cb55b63ea3fdb Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
