Roy Golan has posted comments on this change.
Change subject: engine-core: Add support for async calls to VDSM
..
Patch Set 1: (1 inline comment)
File
backend/manager/module
Roy Golan has posted comments on this change.
Change subject: engine-core: Add support for async calls to VDSM
..
Patch Set 1: (1 inline comment)
File
backend/manager/module
Joey Boggs has uploaded a new change for review.
Change subject: add openssh-clients requires in spec file
..
add openssh-clients requires in spec file
using a minimal installation for ovirt-engine will be missing openssh-client
Moti Asayag has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules/bll/src/mai
Roy Golan has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
..
Patch Set 6:
this patch would be resent once the new API for invoking VDSM calls with future
is in. see I5e88
Michael Kublin has posted comments on this change.
Change subject: engine-core: Add support for async calls to VDSM
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Also the following code will ca
Yair Zaslavsky has posted comments on this change.
Change subject: engine: allow search events by object id
..
Patch Set 3: (1 inline comment)
Besides my minor comment, looks ok to me.
I would prefer Eli still takes a look.
..
Yair Zaslavsky has posted comments on this change.
Change subject: fixup
..
Patch Set 1: I would prefer that you didn't submit this
Commit message is unclear.
I don't mind that the fix splits to two patches , as it is now, but
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: formatting JSNI native methods
..
webadmin: formatting JSNI native methods
Using the GWT plugin to format JSNI native code.
Change-Id: Id78
Danny Rankevich has posted comments on this change.
Change subject: webadmin: formatting JSNI native methods
..
Patch Set 4: Verified; Looks good to me, approved
Already reviewed, rebasing.
--
To view, visit http://gerrit.ovir
Danny Rankevich has abandoned this change.
Change subject: engine: bad performance in storage_domains.getQueryableId()
(#769615)
..
Patch Set 7: Abandoned
Fixed by http://gerrit.ovirt.org/1226
--
To view, visit http://gerrit.
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Infrastructure for Extended side tabs
..
userportal: Infrastructure for Extended side tabs
1. Created VerticalTabPanel widget that implement
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: GwtCommon related rebase changes
..
webadmin: GwtCommon related rebase changes
1. userportal-gwtp AppErrors.properties updated
2. webadmin/
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Infrastructure for Extended side tabs
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1289
To unsubscr
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Client storage abstraction
..
webadmin: Client storage abstraction
This patch provides client-side key-value storage service
that uses HTML5 W
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Client storage abstraction
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1288
To unsubscribe, visit ht
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Initial GWTP-based version using GwtCommon
..
userportal: Initial GWTP-based version using GwtCommon
1. Created first version of UserPortal
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Initial GWTP-based version using GwtCommon
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1219
To uns
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Create GwtCommon and UserPortal GWTP PoC
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1077
To unsubsc
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Initial GWTP-based version using GwtCommon
..
Patch Set 3:
OK, sounds reasonable, later on as time goes by we can move even more things to
GwtCommon
Danny Rankevich has posted comments on this change.
Change subject: webadmin: GwtCommon related rebase changes
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1362
To unsubscribe,
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: GwtCommon related rebase changes
..
webadmin: GwtCommon related rebase changes
1. userportal-gwtp AppErrors.properties updated
2. webadmin/userportal
Roy Golan has uploaded a new change for review.
Change subject: engine-core: Add support for async calls to VDSM
..
engine-core: Add support for async calls to VDSM
Till now all vdms calls were made by future performing the http
Shahar Havivi has posted comments on this change.
Change subject: engine-core: setupNetworks api change
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1061
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: Take 2: Prepration for query permissions - allowing typing of
queries as admin/user and add runAsUser property to params
..
Patch Set 2: (3 inline comments)
..
Moti Asayag has posted comments on this change.
Change subject: ovirt-engine: Add config value for docs base URL
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1342
To unsubscribe
Moti Asayag has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1062
To unsubscribe, visit http://g
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: change engine-db-install to support sysv & systemd
..
packaging: change engine-db-install to support sysv & systemd
Change engine-db-install
Ofer Schreiber has posted comments on this change.
Change subject: packaging: change engine-db-install to support sysv & systemd
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/131
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: hosts tab- pm config window is opened when editing
host
..
webadmin: hosts tab- pm config window is opened when editing host
https://bugzil
Danny Rankevich has posted comments on this change.
Change subject: webadmin: hosts tab- pm config window is opened when editing
host
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin- UserGeneralTab- shows the wrong values
..
webadmin- UserGeneralTab- shows the wrong values
https://bugzilla.redhat.com/show_bug.cgi?id=78368
Danny Rankevich has posted comments on this change.
Change subject: webadmin- UserGeneralTab- shows the wrong values
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1292
To unsubsc
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: Missing cursor on most of new windows opened
..
webadmin: Missing cursor on most of new windows opened
https://bugzilla.redhat.com/show_bug.
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Missing cursor on most of new windows opened
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1280
To u
Livnat Peer has posted comments on this change.
Change subject: Take 2: Prepration for query permissions - allowing typing of
queries as admin/user and add runAsUser property to params
..
Patch Set 2: Looks good to me, but some
Danny Rankevich has posted comments on this change.
Change subject: userportal: Infrastructure for Extended side tabs
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1289
To unsubs
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Client storage abstraction
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1288
To unsubscribe, visit
Danny Rankevich has posted comments on this change.
Change subject: userportal: Initial GWTP-based version using GwtCommon
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1219
To u
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Create GwtCommon and UserPortal GWTP PoC
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1077
To unsub
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Create GwtCommon and UserPortal GWTP PoC
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Initial GWTP-based version using GwtCommon
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
I think that we need to provide
Ofer Schreiber has posted comments on this change.
Change subject: backend: change how encryptpasswd look for jars
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1337
T
ovirt_engine_find_bugs - Build # 57 - Fixed:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/57/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/en
Ofer Schreiber has posted comments on this change.
Change subject: Packaging: Updated release definition (#784425)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1318
To unsubscri
Ofer Schreiber has posted comments on this change.
Change subject: packaging: change engine-db-install to support sysv & systemd
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/131
Roy Golan has uploaded a new change for review.
Change subject: engine-core: Refactor SetNonoperational command
..
engine-core: Refactor SetNonoperational command
refactor the way the the audit log type are determined. Instead
o
Roy Golan has uploaded a new change for review.
Change subject: engine-core: vds monitoring - mtu and bridge network parameters
..
engine-core: vds monitoring - mtu and bridge network parameters
The two new network properties mt
Roy Golan has uploaded a new change for review.
Change subject: engine: New non-operational reason backend/frontend audit log
messages
..
engine: New non-operational reason backend/frontend audit log messages
Change-Id: Ie40e0f
Roy Golan has uploaded a new change for review.
Change subject: ovirt-engine: add the fields bridged and mtu to network and
VdsnetworkInterface entities
..
ovirt-engine: add the fields bridged and mtu to network and VdsnetworkIn
Roy Golan has uploaded a new change for review.
Change subject: engine-core: minor cleanup
..
engine-core: minor cleanup
Change-Id: I3d723c347da770a14da2e6600a71fc157f51ddb8
---
M
backend/manager/modules/vdsbroker/src/main/java
Roy Golan has uploaded a new change for review.
Change subject: engine-core: clean soap annotations from
SetNonOperationalVdsParameters
..
engine-core: clean soap annotations from SetNonOperationalVdsParameters
Change-Id: I2949
Roy Golan has uploaded a new change for review.
Change subject: engine-core: add mtu and bridged to object builder
..
engine-core: add mtu and bridged to object builder
Change-Id: I5ccfae52db98999bcd76630f534a220d98e33315
---
M
Roy Golan has uploaded a new change for review.
Change subject: engine-core: refactor SetNonOpertaional command
..
engine-core: refactor SetNonOpertaional command
1. extend the API to have the results and custom audit logs
2. de
Roy Golan has uploaded a new change for review.
Change subject: engine-core: make network DAO extend the generic DAO
..
engine-core: make network DAO extend the generic DAO
Change-Id: I860f7ad8dca5bf066f53401a0d2430223967c501
--
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Initial GWTP-based version using GwtCommon
..
Patch Set 2:
Hi, the main reason for creating gwt-common is to extract common infrastructure
and featu
Einav Cohen has posted comments on this change.
Change subject: reports: fixed br6\13 query (#770267)
..
Patch Set 1:
please split to two patches.
--
To view, visit http://gerrit.ovirt.org/1312
To unsubscribe, visit http://ger
Einav Cohen has posted comments on this change.
Change subject: history: replaced all tabs with spaces.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1339
To unsubscribe, visit http://gerr
Einav Cohen has submitted this change and it was merged.
Change subject: history: replaced all tabs with spaces.
..
history: replaced all tabs with spaces.
removed remaining trialing whitespaces.
This was done to all non genera
Einav Cohen has posted comments on this change.
Change subject: reports: replaced all tabs with spaces.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1338
To unsubscribe, visit http://gerr
Yaniv Dary has posted comments on this change.
Change subject: reports: fixed br6\13 query (#770267)
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1312
To un
Yaniv Dary has posted comments on this change.
Change subject: history: replaced all tabs with spaces.
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1339
To
Yaniv Dary has posted comments on this change.
Change subject: reports: replaced all tabs with spaces.
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1338
To
Einav Cohen has submitted this change and it was merged.
Change subject: reports: removed trailing white spaces.
..
reports: removed trailing white spaces.
Change-Id: I458021eca19cad95d1007847db1a268a8598db63
---
M reports/jars
Einav Cohen has posted comments on this change.
Change subject: reports: removed trailing white spaces.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1261
To unsubscribe, visit http://gerr
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fixing a bug in string assignment
..
core: Fixing a bug in string assignment
Bug was that seq variable was never set.
Also , repalced string concatan
Moti Asayag has posted comments on this change.
Change subject: core: Fixing a bug in string assignment
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1349
To unsubscribe, visit h
ovirt_engine_find_bugs - Build # 56 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/56/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/li
Eli Mesika has uploaded a new change for review.
Change subject: core: Fixing a bug in string assignment
..
core: Fixing a bug in string assignment
Bug was that seq variable was never set.
Also , repalced string concatanation wi
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: hosts tab- pm config window is opened when editing
host
..
webadmin: hosts tab- pm config window is opened when editing host
https://bugzilla.redhat.c
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: add parameter type to list @Param
..
sdk: add parameter type to list @Param
Change-Id: I14138c410f3c54bb1f841be5eb066359ebc83480
---
M src/code
Michael Pasternak has posted comments on this change.
Change subject: sdk: add parameter type to list @Param
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1346
To unsubscribe, vi
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: add parameter type to list @Param
..
sdk: add parameter type to list @Param
Change-Id: I14138c410f3c54bb1f841be5eb066359ebc83480
---
M src/codegen/coll
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Remove unnecessary methods in ImageVmMapDAO
..
core: Remove unnecessary methods in ImageVmMapDAO
These methods aren't rellay necessary, so removed them an
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Remove ImagesSyncronizer and related code
..
core: Remove ImagesSyncronizer and related code
This class is unsued and probably won't work well if it were
Einav Cohen has posted comments on this change.
Change subject: ovirt-engine: Add config value for docs base URL
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1342
To
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Context sensitive help links (#748227)
..
webadmin: Context sensitive help links (#748227)
https://bugzilla.redhat.com/748227
Added context sensitive d
Daniel Erez has uploaded a new change for review.
Change subject: ovirt-engine: Add config value for docs base URL
..
ovirt-engine: Add config value for docs base URL
Added 'DocsURL' configuration value - the base URL for the
do
ovirt_engine_find_bugs - Build # 55 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/55/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/li
Einav Cohen has submitted this change and it was merged.
Change subject: reports: fixed inefficient subquery in all the reports (#783194)
..
reports: fixed inefficient subquery in all the reports (#783194)
https://bugzilla.redh
Einav Cohen has posted comments on this change.
Change subject: reports: fixed inefficient subquery in all the reports (#783194)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1228
To unsub
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed poms maven files.
..
reports: fixed poms maven files.
- Now pulls version from root.
- Also removed internal repository entry.
Change-Id: I
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: Cluster memory overcommit label fix
..
webadmin: Cluster memory overcommit label fix
Cluster memory overcommit were wrong (e.g. servers memory o
Einav Cohen has posted comments on this change.
Change subject: webadmin: Cluster memory overcommit label fix
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1340
To unsubscribe, v
Daniel Erez has posted comments on this change.
Change subject: webadmin: Cluster memory overcommit label fix
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1340
To unsubscribe, v
ovirt_engine_find_bugs - Build # 54 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/54/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/li
Eyal Edri has posted comments on this change.
Change subject: packaging: change engine-db-install to support sysv & systemd
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Moti Asayag has submitted this change and it was merged.
Change subject: core:REST API does not validate required parameters for power
managment
..
core:REST API does not validate required parameters for power managment
Adding
Moti Asayag has posted comments on this change.
Change subject: core:REST API does not validate required parameters for power
managment
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/1010
To unsubscribe, vi
Moti Asayag has posted comments on this change.
Change subject: core:REST API does not validate required parameters for power
managment
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1010
Eyal Edri has posted comments on this change.
Change subject: packaging: change engine-db-install to support sysv & systemd
..
Patch Set 2: I would prefer that you didn't submit this
please see comments
--
To view, visit http:
Ofer Schreiber has posted comments on this change.
Change subject: packaging: change engine-db-install to support sysv & systemd
..
Patch Set 2: Fails
(4 inline comments)
Patch looks good, few comments inside.
...
Ronen Angluster has uploaded a new change for review.
Change subject: packaging: adjust requirements for EAP
..
packaging: adjust requirements for EAP
change requirment from ovirt-engine-jbossas to rhevm-jbosseap
Change-Id: I3b
Einav Cohen has uploaded a new change for review.
Change subject: webadmin: Cluster memory overcommit label fix
..
webadmin: Cluster memory overcommit label fix
Cluster memory overcommit were wrong (e.g. servers memory overcommi
Yaniv Dary has uploaded a new change for review.
Change subject: history: replaced all tabs with spaces.
..
history: replaced all tabs with spaces.
removed remaining trialing whitespaces.
This was done to all non generated code.
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: engine-setup -support long host fqdn (#782810)
..
packaging: engine-setup -support long host fqdn (#782810)
- fixed installCA.sh t
Ofer Schreiber has posted comments on this change.
Change subject: packaging: engine-setup -support long host fqdn (#782810)
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1187
T
Yaniv Dary has uploaded a new change for review.
Change subject: reports: replaced all tabs with spaces.
..
reports: replaced all tabs with spaces.
removed remaining trailing white spaces.
Change-Id: Ice21e6378b9912f08231c4e38c
Ronen Angluster has uploaded a new change for review.
Change subject: backend: change how encryptpasswd look for jars
..
backend: change how encryptpasswd look for jars
Instead of specifying the exact jars needed by encryptpassw
99 matches
Mail list logo
