Yair Zaslavsky has posted comments on this change. Change subject: engine: allow search events by object id ......................................................................
Patch Set 3: (1 inline comment) Besides my minor comment, looks ok to me. I would prefer Eli still takes a look. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java Line 375: /** I think we have this at LinqUtils. LinqUtils should be eliminated from the code . Maybe Apache commons has something for filtering collections (worth checking) - if not, I would prefer to have a class in Utils that does it (when LinqUtils is removed). So either you now do use LinqUtils and in the future we'll introduce a patch that simply replaces all places in code that uses it, or use something from Apache commons, or write a new Utils class, that we might use later to replace LinqUtils. -- To view, visit http://gerrit.ovirt.org/1241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ca6288d256d3722023d9b7119417dc94ebdbe9e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
