Ofer Schreiber has posted comments on this change. Change subject: packaging: change engine-db-install to support sysv & systemd ......................................................................
Patch Set 2: Fails (4 inline comments) Patch looks good, few comments inside. .................................................... File backend/manager/dbscripts/engine-db-install.sh Line 39: POSTGRESQL_SERVICE=postgresql.service Both *_SERVICE are pretty confusing... Line 43: SYSTEMD_SUPPORT=1 Better put "else: SYSTEMD_SUPPORT=0" Line 134: if [ $SYSTEMD_SUPPORT -eq 1 ] If SYSTEMD_SUPPORT won't be defined, the script will throw few errors... Line 170: if [ $SYSTEMD_SUPPORT -eq 1 ] Same here, SYSTEMD_SUPPORT must be defined.... -- To view, visit http://gerrit.ovirt.org/1313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71f737f88da9228938389ed6bc558d091935b0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster <rangl...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
