Vojtech Szocs has posted comments on this change. Change subject: userportal: Initial GWTP-based version using GwtCommon ......................................................................
Patch Set 2: Hi, the main reason for creating gwt-common is to extract common infrastructure and features that could be useful for potential GWTP applications. As for dialogs: gwt-common provides AbstractModelBoundPopupPresenterWidget/View as the base for implementing popups bound to UiCommon models. gwt-common doesn't contain specific dialog implementations, since these typically depend on app-specific layout/styles/images. For example, "New Desktop VM" dialog (VmDesktopNewPopupPresenterWidget/View) has no special logic in Presenter, but its View is bound to layout/styles/images of WebAdmin UI. Why should gwt-common impose such restrictions? This would mean we would move such styles/images into gwt-common as well.. I also noticed, besides look & feel, dialogs are little bit different in WebAdmin and UserPortal. For example, "New Server VM" dialog in UserPortal doesn't show "Custom properties" dialog tab.. As for grids, it's basically the same as with dialogs. gwt-common provides AbstractActionTable as the base for implementing grids bound to UiCommon SearchableListModels. Their concrete implementations (e.g. SimpleActionTable in WebAdmin) again depend on app-specific layout/styles/images. I think abstract classes like AbstractModelBoundPopupPresenterWidget/View, AbstractActionPanel, AbstractActionTable, AbstractTabPanel etc. provide quite good separation between common functionality and app-specific implementation (mostly related to layout/styles/customizations). What do you think about this? -- To view, visit http://gerrit.ovirt.org/1219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida4e876f3db06b6de9530363e2cef4cc61f22854 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Danny Rankevich <danny....@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
