Michael Kublin has posted comments on this change. Change subject: engine-core: Add support for async calls to VDSM ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Also the following code will cause a regression at VdsManager.refreshCapabilities, you should check all over a code about such places. Most of the failover rerun of IrsBrokerCommand will be with out time out also many places at VdsUpdateRuntimeInfo. ActivateVdsVDSCommand will stop to work, possible also couple of commands which are child of VdsIdVDSCommandBase. (By the way I send u a patch which should handle those issues. ) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java Line 408: */ Add timeout as parameter, and not return future, you don't need to play with future timeout is enought .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java Line 115: The following class is unneeded -- To view, visit http://gerrit.ovirt.org/1361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e8876a9b2d04fc7d15388655688ca82d5d7008e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
