hazendaz commented on PR #718:
URL: https://github.com/apache/tomcat/pull/718#issuecomment-2050846843
Not speaking for team but as onlooker, Tomcat 7 is end of life since March
2021. There are no further updates. So it wouldn't make sense to patch it.
It wouldn't be released anyways. On
aooohan closed pull request #718: fix CVE-2024-23672
URL: https://github.com/apache/tomcat/pull/718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-
aooohan commented on PR #718:
URL: https://github.com/apache/tomcat/pull/718#issuecomment-2050851432
Tomcat 7 is end of life since March 2021, so we won't merge this change,
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
rmaucher closed pull request #713: Sessioncounter
URL: https://github.com/apache/tomcat/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-uns
rmaucher commented on PR #713:
URL: https://github.com/apache/tomcat/pull/713#issuecomment-2051302240
Thanks for pointing this out. Since tracking too many redundant stats is not
super useful, I decided to remove this one (it is now approximated by adding
the active sessions to the expired
qauck opened a new pull request, #719:
URL: https://github.com/apache/tomcat/pull/719
These attributes no longer existing in corresponding
org.apache.tomcat.util.net.NioEndpoint, which will cause
java.lang.NoSuchMethodException at run time.
--
This is an automated message from the Apache
ilapavuluri opened a new issue, #55:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/55
I am using tomcat transformer for javax to jakarta conversion, in the
similar lines I converted my activemq-all 5.16.7 into jakarta using the same
tomcat transformer, no errors during co
jose-galvez opened a new pull request, #720:
URL: https://github.com/apache/tomcat/pull/720
commit
[a8575ef](https://github.com/apache/tomcat/commit/a8575efbc1de64fe58c8fd99e53a0011b59a8e86)
removed support for seconds with floating point for the Extended Access Log
Valve and made it only
markt-asf commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061540617
From memory that change was to align Tomcat's access log configuration with
httpd. It may well be that the correct fix here is to correct the documentation.
Separately, comparing this PR
ChristopherSchultz commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061771435
Why not use `%D` which is in milliseconds (Tomcat <10) or microseconds
(Tomcat >= 10)?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061821679
> From memory that change was to align Tomcat's access log configuration
with httpd. It may well be that the correct fix here is to correct the
documentation. Separately, comparing this
jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061838297
> Why not use `%D` which is in milliseconds (Tomcat <10) or microseconds
(Tomcat >= 10)?
I wanted to keep parity on the behavior here with previous versions,
especially because in
ChristopherSchultz commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063733345
So nothing can ever change, then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063746801
It can, but in this case the documentation states that it didn't so I was
trying to bring it back to how it behaved before (which as an added bonus helps
us not change our scripts).
ChristopherSchultz commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063868914
Oh, I'm' sorry I didn't pick-up on the subtleties of your report.
Tomcat 10.1 is documented that the value for `%T` is in (presumably _whole_)
seconds. Tomcat 9 says it's in
jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2064310044
> Are you specifically talking about the ExtendedAccessLogValve's
`time-taken` token? If so, you're right, that documentation did not change yet
the underlying implementation did change.
ChristopherSchultz commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2066468644
Please have a look at a different PR which builds on some refactoring I just
pushed: https://github.com/apache/tomcat/pull/721
I think I like mine better.
--
This is an a
markt-asf commented on code in PR #721:
URL: https://github.com/apache/tomcat/pull/721#discussion_r1572301203
##
java/org/apache/catalina/valves/AbstractAccessLogValve.java:
##
@@ -1756,10 +1776,14 @@ protected AccessLogElement
createAccessLogElement(String name, char pattern)
jose-galvez closed pull request #720: Re-adding support for fractional seconds
in access log
URL: https://github.com/apache/tomcat/pull/720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2066644940
I like it!! Definitely way better than my change which now seems like a bad
hack 🤣 I can close this PR in favor of yours 😃
--
This is an automated message from the Apache Git Service
MartinLei opened a new pull request, #722:
URL: https://github.com/apache/tomcat/pull/722
Using the Tomcat-JDBC library inside a Spring Native project causes the
compilation step of a GraalVM native image to crash with the given error.
> Exception in thread "main"
org.springframewo
ChristopherSchultz commented on code in PR #721:
URL: https://github.com/apache/tomcat/pull/721#discussion_r1572451843
##
java/org/apache/catalina/valves/AbstractAccessLogValve.java:
##
@@ -1756,10 +1776,14 @@ protected AccessLogElement
createAccessLogElement(String name, char
ChristopherSchultz commented on code in PR #721:
URL: https://github.com/apache/tomcat/pull/721#discussion_r1572455403
##
java/org/apache/catalina/valves/AbstractAccessLogValve.java:
##
@@ -1756,10 +1776,14 @@ protected AccessLogElement
createAccessLogElement(String name, char
markt-asf commented on code in PR #721:
URL: https://github.com/apache/tomcat/pull/721#discussion_r1572780769
##
java/org/apache/catalina/valves/AbstractAccessLogValve.java:
##
@@ -1756,10 +1776,14 @@ protected AccessLogElement
createAccessLogElement(String name, char pattern)
adwsingh opened a new pull request, #723:
URL: https://github.com/apache/tomcat/pull/723
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xsimo opened a new pull request, #724:
URL: https://github.com/apache/tomcat/pull/724
Managing multiple tomcats on multiple servers, the need came to have a way
of customizing the Manager HTML interface.
This PR proposes to add a simple configurable html subtitle.
![Example_of_custom
ChristopherSchultz commented on code in PR #721:
URL: https://github.com/apache/tomcat/pull/721#discussion_r1578085100
##
java/org/apache/catalina/valves/AbstractAccessLogValve.java:
##
@@ -1756,10 +1776,14 @@ protected AccessLogElement
createAccessLogElement(String name, char
ChristopherSchultz merged PR #721:
URL: https://github.com/apache/tomcat/pull/721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat
michael-o opened a new pull request, #725:
URL: https://github.com/apache/tomcat/pull/725
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
markt-asf merged PR #725:
URL: https://github.com/apache/tomcat/pull/725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
michael-o commented on PR #725:
URL: https://github.com/apache/tomcat/pull/725#issuecomment-2092917929
@markt-asf, thank for merging. I will come up with my addtional X.509
username retriever idea shortly.
--
This is an automated message from the Apache Git Service.
To respond to the mess
markt-asf closed pull request #719: remove obsolete JMX bean attributes
URL: https://github.com/apache/tomcat/pull/719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
markt-asf commented on PR #719:
URL: https://github.com/apache/tomcat/pull/719#issuecomment-2093075977
Thanks for the PR. I did a broader review and found a few more attributes
that could be removed too.
--
This is an automated message from the Apache Git Service.
To respond to the messag
markt-asf closed pull request #710: it will drop first header if any header
cause exceptio during process
URL: https://github.com/apache/tomcat/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
markt-asf commented on PR #710:
URL: https://github.com/apache/tomcat/pull/710#issuecomment-2093184047
Thanks for spotting this. I've applied this fix along with a simple test
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
markt-asf merged PR #53:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
ebourg commented on issue #55:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/55#issuecomment-2106053982
@ilapavuluri Do you have a stacktrace to share?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
rmannibucau commented on issue #55:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/55#issuecomment-2108571969
Hi @ilapavuluri ,
* did you run with `-profile=EE`?
* do you use a local (vm) uri or a remote one?
* did you run it on both the client and broker if re
pluralistix opened a new pull request, #726:
URL: https://github.com/apache/tomcat/pull/726
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
markt-asf merged PR #726:
URL: https://github.com/apache/tomcat/pull/726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf commented on PR #726:
URL: https://github.com/apache/tomcat/pull/726#issuecomment-2111099637
Tx for the pR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
ChristopherSchultz commented on PR #726:
URL: https://github.com/apache/tomcat/pull/726#issuecomment-255159
:/
Sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
ilapavuluri commented on issue #55:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/55#issuecomment-2112442350
Hi Team,
Really sorry for the late response, resolved it by upgrading to 5.18.3 in my
clientside and keep the activemq server as it is.
Thanks
Ash
ilapavuluri closed issue #55: activemq 5.16.x not working after converting
javax to jakarta using tomcat transformer
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ehsaasprogram commented on PR #406:
URL: https://github.com/apache/tomcat/pull/406#issuecomment-2116423996
There are many complaints against https://ehsaasprogramme8171.pk/";>Ehsaas Programpeople are not
receiving money
--
This is an automated message from the Apache Git Service.
To respo
dsoumis opened a new pull request, #23:
URL: https://github.com/apache/tomcat-native/pull/23
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
markt-asf merged PR #23:
URL: https://github.com/apache/tomcat-native/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa
dsoumis opened a new pull request, #24:
URL: https://github.com/apache/tomcat-native/pull/24
Add to changelog that the recommended minimum version of OpenSSL has been
updated to 3.0.13 with 1.3.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the messa
markt-asf merged PR #24:
URL: https://github.com/apache/tomcat-native/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa
robinverduijn opened a new pull request, #727:
URL: https://github.com/apache/tomcat/pull/727
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
dsoumis opened a new pull request, #728:
URL: https://github.com/apache/tomcat/pull/728
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsoumis opened a new pull request, #729:
URL: https://github.com/apache/tomcat/pull/729
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf merged PR #729:
URL: https://github.com/apache/tomcat/pull/729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf merged PR #728:
URL: https://github.com/apache/tomcat/pull/728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf merged PR #727:
URL: https://github.com/apache/tomcat/pull/727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
jengebr commented on PR #730:
URL: https://github.com/apache/tomcat/pull/730#issuecomment-2142005988
Can you please add a unit test to demonstrate the problem? I don't fully
understand the issue.
Also, this implementation comes with a performance penalty when accessing
any resource,
dsoumis opened a new pull request, #731:
URL: https://github.com/apache/tomcat/pull/731
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142442782
These lines were commented out on purpose, so that they are available if you
need them but not enabled by default.
I am not sure that uncommenting them is the right thing to do. The fi
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142501404
Intellij won't compile the sources if those exclusions are not made, making
the "ant ide-intellij" step useless.
In case it's not the right thing to do, we should redefine the support for
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142532017
@dsoumis It won't compile if the Java version etc. are not compatible with
that code. This is not making it useless. Perhaps a better change would be to
add a comment about it in the output,
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142542693
@isapir It seemed weird to me, but even with Java 22 defined in Intellij the
compilation didn't succeed. Maybe something else is missing as well.
+1 For adding a comment in the output
--
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142552727
@dsoumis I agree that it's weird, but my concern is that it would break
other environments that work.
Let's wait for Remy/Mark/others to chime in as they are more familiar with
how thi
markt-asf commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142584248
I'm not an Idea user but I'd expect that code to compile using Java 22. Not
much help I know but those packages aren't showing any errors in Eclipse with
Java 22.
What is the error
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142611198
@markt-asf
Compilation errors with Java22 (compile target is 22 as well as Java 22
being used):
>
>
/home/dsoumis/Programs/github/tomcat/java/org/apache/tomcat/util/net/openssl/pa
markt-asf commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142625138
Hmm. Exactly which version of Java 22 are you using?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142631865
22.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
markt-asf commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142686031
That isn't it then. I think we need someone else with Idea (or who can set
it up) to test this.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144037801
@dsoumis I got it to work by setting the Project's `Language level` to "X -
Experimental features"
![image](https://github.com/apache/tomcat/assets/885907/41c6646c-a767-48d3-ad2b-c8b2d
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144252838
@dsoumis I pushed a patch that sets the Language Level to Experimental:
https://github.com/apache/tomcat/commit/f8eecc13b53fdca998565455d3c27e9b9a6cd8dc
Can you pull it and check if
bergander commented on PR #730:
URL: https://github.com/apache/tomcat/pull/730#issuecomment-2144410872
I've created a test case which fetches a resource from a jar file. It uses a
_JarResourceSet_ with the _internalPath_ set to _/META-INF/resources_ and the
test fetches the file _/META-INF/
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144545354
@isapir It doesn't work for me. After pulling your patch I am getting errors
such as:
`java: java.lang.foreign.Arena is a preview API and is disabled by default.
(use --enable-preview
jengebr commented on PR #730:
URL: https://github.com/apache/tomcat/pull/730#issuecomment-2145263710
Thank you, this was very helpful! I investigated and found:
1. Your test clearly reproduced the error. Much appreciated.
2. internalPath is usually "" (a String of length 0)
3. I'm
bergander commented on PR #730:
URL: https://github.com/apache/tomcat/pull/730#issuecomment-2145330590
Thanks for the very quick feedback! I'll update the code with your
suggestion.
I'm guessing that the combination of having resources inside jar files and
turning on the bloom filter
jengebr commented on PR #730:
URL: https://github.com/apache/tomcat/pull/730#issuecomment-2145551211
Looks good to me. Of course, I'm not a committer. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2145709893
Strange, I don't have those settings
But OK, I will revert the latest change. Feel
dipualnur opened a new issue, #56:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/56
I'm trying to install Tomcat 9 on my Ubuntu system using `*
`sudo apt-get install tomcat9`
but I keep running into the following error:
> monirul@nitacl-Veriton-Seri
slovdahl commented on issue #56:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/56#issuecomment-2146878806
In general, I don't think is the right place for Ubuntu-specific package
issues. For Ubuntu-specific package questions/issues, you should use
https://bugs.launchpad.
markt-asf closed issue #56: Unable to install Tomcat 9 - **"Package 'tomcat9'
has no installation candidate"** || Ubuntu 24.04 LTS
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jajik opened a new pull request, #732:
URL: https://github.com/apache/tomcat/pull/732
At the same time, I've updated the translation in the POEditor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2149133573
On second thoughts, I believe ide-support should strictly follow build.xml
rules.
As build.xml
[excludes](https://github.com/apache/tomcat/blob/main/build.xml#L1014) openssl
and panama
dsoumis opened a new pull request, #733:
URL: https://github.com/apache/tomcat/pull/733
…l libraries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsoumis commented on PR #733:
URL: https://github.com/apache/tomcat/pull/733#issuecomment-2150200992
When running `ant deploy` to reproduce the build, `pre-release` target will
not have been executed, ant.tstamp.now.iso has no value assigned and the
following output is written:
> bui
isapir commented on PR #733:
URL: https://github.com/apache/tomcat/pull/733#issuecomment-2150229542
Is `tstamp.iso.release` defined at that spot @dsoumis ? If so, maybe we can
set a default for `ant.tstamp.now.iso` to be `tstamp.iso.release`?
--
This is an automated message from the Apac
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2150273321
@dsoumis But now you are completely excluding
`/java/org/apache/tomcat/util/net/openssl/panama` and
`/java/org/apache/tomcat/util/openssl`? It might "work" on Java 17 but new
technology woul
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151524740
@isapir My expectation was that "ant ide-intellij" should work out of the
box without requiring any adjustments.
Currently, to use an SDK version lower than 22, you must exclude
`/java/o
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151559998
@dsoumis Tomcat 11 takes advantage of new technology. The build script
checks if the Java version is 22 and if so it compiles the Panama packages.
This is for a development environment
rmannibucau commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151570300
Assuming using uses the highest java version sounds okish but shouldnt
preview mode be enabled if the packages are not excluded, otherwise it leads to
the same output: it does not work i
markt-asf commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2157847935
I'm not an Idea user so I have no strong view on this. I'd be happy with
whatever consensus the Idea users reach.
I am an Eclipse user and the approach I use there (which I think the
alipsitz-sf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-2158656022
Hey, I'm not really good navigating Bugzilla, so I don't know if it's been
reported already but it looks like this PR broke the
`AbstractHttp11Protocol.reloadSslHostConfigs()` API when r
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2159528473
Thank you for your input on this @markt-asf - it makes sense to me, and is
consistent with my proposed solution.
> - Eclipse is configured to use the same Java version as the build (Jav
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160286872
> IMO it is reasonable to expect a user that is developing on the latest
version of Tomcat, i.e. the main branch, to be using the latest Java SDK, which
will work with the Experimental featu
jajik closed pull request #732: Fix typo in Czech translation
URL: https://github.com/apache/tomcat/pull/732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
jajik commented on PR #732:
URL: https://github.com/apache/tomcat/pull/732#issuecomment-2160391202
Closing after a discussion with @rmaucher , POEditor changes should be
sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
markt-asf commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160396222
> Since IDE support is
[configured](https://github.com/apache/tomcat/blob/main/build.xml#L3830) with
build.java.version, which currently is
[17](https://github.com/apache/tomcat/blob/main
dsoumis commented on PR #733:
URL: https://github.com/apache/tomcat/pull/733#issuecomment-2160410399
> Is tstamp.iso.release defined at that spot @dsoumis ?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160442520
The change we could make so that all opinions are generally satisfied are:
1. Move the exclusions from `res/ide-support/idea/compiler.xml` to
`res/ide-support/idea/tomcat.iml` commente
isapir merged PR #731:
URL: https://github.com/apache/tomcat/pull/731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
ChristopherSchultz commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2161585676
My preference is for the ide-idea ant target to work for *most people*.
_Most people_ are not Tomcat developers, but people who have downloaded our
sources and are building them l
ChristopherSchultz commented on PR #733:
URL: https://github.com/apache/tomcat/pull/733#issuecomment-2161606328
> When running `ant deploy` to reproduce the build, `pre-release` target
will not have been executed
If you are trying to reproduce the build, they you will have
`build.pro
ChristopherSchultz merged PR #733:
URL: https://github.com/apache/tomcat/pull/733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat
401 - 500 of 1992 matches
Mail list logo
