bergander commented on PR #730:
URL: https://github.com/apache/tomcat/pull/730#issuecomment-2144410872
I've created a test case which fetches a resource from a jar file. It uses a
_JarResourceSet_ with the _internalPath_ set to _/META-INF/resources_ and the
test fetches the file _/META-INF/resources/index.html_. This is what happens
when e.g. you have an exploded war-file containing a jar file inside
_/WEB-INF/lib/_ and try to load a resource using
`servletContext.getResource("/index.html")`.
Without the bloom filter the test will pass, but when enabling the filter it
fails due to the missing _internalPath_ in the call to
`mightContainResource(...)`.
Regarding the performance penalty of the string concatenation, the same
concatenation exists a few rows below when not using the bloom filter (line
228: `String pathInJar = getInternalPath() +
path.substring(webAppMount.length());`) So I'm not sure if there's a better way
of doing this when using the filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
