jose-galvez commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2064310044
> Are you specifically talking about the ExtendedAccessLogValve's
`time-taken` token? If so, you're right, that documentation did not change yet
the underlying implementation did change.
Yes, sorry I didn't state this better 😞 but the change I made was
specifically for the `time-taken` token to go back to the Tomcat 9 behavior and
report the seconds with fractions as the documentation states
> IMHO, "fractional seconds" isn't worth the computation power to format it
in the first place, then parse it later back into milliseconds or whatever. I
would recommend changing your tooling to look for an embedded `.` character and
changing behavior to be backward- and forward-compatible by simply using
milliseconds or microseconds, whichever you prefer.
I'll talk to our team to see if they can make these changes. For now we
created a patch for our application with this PR's change so we load the
modified `ExtendedAccessLogValve` class in our application for Tomcat 10. Of
course this is meant to be temporary since it could become a bit of a nightmare
to maintain long term
> We should update the documentation for `ExtendedAccessLogValve` to make it
clear that `time-taken` has changed along with `%T` to be whole-seconds.
This would be great, that way we can also send a notice to our customers
pointing to it so they can update any tooling they have that relies on the
current format
> We can continue this conversation to determine what _else_ we might do,
such as continuing to support "fractional seconds" as an output format. The
problem (for you) with supporting fractional-seconds is that it won't work from
10.1.0 - 10.1.23 at least, so you will have a specific set of Tomcat versions
that are supported by your product and tooling.
We are fine right now because our current production versions are running
Tomcat 9.x and we have the patch for 10.1.x ready for when it goes to
production so if there's a new output in the near future to have the fractional
seconds we could just move to that and remove our internal patch 🙂 but like I
said I'll bring it up with the team to see if we can start moving to using
milliseconds instead since it probably would also make calculations faster on
our scripts and monitoring systems.
Thank you so much for your comments and your insight on this issue 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
