isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151559998
@dsoumis Tomcat 11 takes advantage of new technology. The build script checks if the Java version is 22 and if so it compiles the Panama packages. This is for a development environment, which should allow you to debug and devlop the project "out of the box", including the Panama packages. By commenting out the lines you are effectively making them not debuggable. Developers who use Tomcat on an IDE are not regular users and it is perfectly reasonable IMO to expect that they use a new Java version. If they run into the error then they can refer to the documentation or comments. The lines should be kept commented out, regardless of which file (I didn't check the implication of having them in compiler.xml). A user that wishes to exclude the packages can simply uncomment them. It's a one time tweak that is easy to change if needed. Excluding the files will not take advantage of advanced features. Users who want to use older features can run Tomcat 10.1 or 9.0 rather than the main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
