dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160286872
> IMO it is reasonable to expect a user that is developing on the latest version of Tomcat, i.e. the main branch, to be using the latest Java SDK, which will work with the Experimental features flag. > @dsoumis That is not correct. The build.xml only excludes the FFM directories for Java versions < 22. See lines 1018 - 1033 which make use of the use-ffm flag at https://github.com/apache/tomcat/blob/main/build.xml#L1018 Since IDE support is [configured](https://github.com/apache/tomcat/blob/main/build.xml#L3830) with build.java.version, which currently is [17](https://github.com/apache/tomcat/blob/main/build.xml#L111), then should be aligned with build.xml. > The reason that it is not working "out of the box" is that we also need to enable "Experimental" or "Preview" features as the FFM is not enabled in Java 22 by default, and should be enabled with a switch. We can guide the developer by adding instructions to the target's comment in build.xml. --- > Keeping the exclusions in res/ide-support/idea/compiler.xml (or res/ide-support/idea/tomcat.iml, though I haven't tested that) commented out, allows the user to test the project with all of its features (e.g. FFM), and still make it easy to uncomment the lines and test without FFM on older SDKs. In its current state this will not work with @markt-asf proposal: > Keeping the project error free and the configuration of the auto-format tools is far more important to me than whether the FFM code is included in the IDE by default or not. Therefore, I propose that the exclusions be uncommented by default, and we provide guidance in the target's comment on how to include the FFM code. This would specify what needs to be commented out and the minimum SDK to use with "Experimental" or "Preview" features enabled. (It's noteworthy that I haven't managed to make this work in Intellij even when using Java22 with preview features enabled, which might be a bug in IDEA and could affect other users as well. From my point of view, it's better to have something that works flawlessly out of the box than trying to figure out what is going wrong, which led to the existence of this PR :) ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
