Re: Security of cluster's EncryptInterceptor

2018-11-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/20/18 13:46, Christopher Schultz wrote: > All, > > I'd like a sanity-check on something I've done for the > EncryptIntercepto r. > > I'm using CBC mode because any other mode makes no sense. Using &g

Re: Parallel Classloader - Again

2018-11-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/20/18 12:50, Mark Thomas wrote: > On 20/11/2018 15:21, Andrew Carr wrote: >> Hello, >> >> We have been seeing some intermittent issues with the parallel >> classloader. I do not want to jump to any conclusions and say >> this is a bug

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
okay) then I'll go ahead and back-port, assuming there is some kind of configuration error in that particular user's case. - -chris On 11/21/18 10:15, schu...@apache.org wrote: > Author: schultz Date: Wed Nov 21 15:15:34 2018 New Revision: > 1847118 > > URL: http://svn.apache

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/21/18 11:36, Mark Thomas wrote: > On 21/11/2018 15:37, Mark Thomas wrote: >> On 21/11/2018 15:29, Christopher Schultz wrote: >>> All, >>> >>> With this last patch, I'm ready for a back-port t

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/21/18 11:51, Mark Thomas wrote: > On 21/11/2018 16:36, Mark Thomas wrote: >> On 21/11/2018 15:37, Mark Thomas wrote: >>> On 21/11/2018 15:29, Christopher Schultz wrote: >>>> All, >>>> >&

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/21/18 15:11, Mark Thomas wrote: > On 21/11/2018 19:43, Christopher Schultz wrote: >> Mark, >> >> On 11/21/18 11:51, Mark Thomas wrote: >>> On 21/11/2018 16:36, Mark Thomas wrote: >>>> On 21/11/

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/22/18 05:21, Mark Thomas wrote: > On 21/11/2018 22:39, Christopher Schultz wrote: >> Mark, >> > > >>> I thought you were using CBC so a missing block (a message >>> being one or more block

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/22/18 16:43, Mark Thomas wrote: > On 22/11/2018 19:17, Christopher Schultz wrote: >> Mark, >> >> On 11/22/18 05:21, Mark Thomas wrote: >>> On 21/11/2018 22:39, Christopher Schultz wrote: >>>>

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/22/18 17:32, Christopher Schultz wrote: > Mark, > > On 11/22/18 16:43, Mark Thomas wrote: >> On 22/11/2018 19:17, Christopher Schultz wrote: >>> Mark, >>> >>> On 11/22/18 05:21, Mark Thomas wr

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/22/18 17:52, Mark Thomas wrote: > On 22/11/2018 22:32, Christopher Schultz wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> Mark, >> >> On 11/22/18 16:43, Mark Thomas wrote: >>>

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/22/18 18:24, Mark Thomas wrote: > > > On 22/11/2018 23:05, Christopher Schultz wrote: >> On 11/22/18 17:52, Mark Thomas wrote: >>> On 22/11/2018 22:32, Christopher Schultz wrote: >>>>

Re: svn commit: r1847318 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java w

2018-11-24 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/23/18 16:55, Mark Thomas wrote: > On 23/11/2018 21:18, schu...@apache.org wrote: >> Author: schultz Date: Fri Nov 23 21:18:48 2018 New Revision: >> 1847318 >> >> URL: http://svn.apache.org/viewvc?re

Re: svn commit: r1847326 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-11-24 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/23/18 18:08, ma...@apache.org wrote: > Author: markt Date: Fri Nov 23 23:08:41 2018 New Revision: 1847326 > > URL: http://svn.apache.org/viewvc?rev=1847326&view=rev Log: Fix IDE > nags > > Modified: > tomcat/trunk/test/org/apache/cata

Re: svn commit: r1847417 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java w

2018-11-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/25/18 10:49, schu...@apache.org wrote: > Author: schultz Date: Sun Nov 25 15:49:28 2018 New Revision: > 1847417 > > URL: http://svn.apache.org/viewvc?rev=1847417&view=rev Log: Add > support for GCM block cipher mode.

Re: svn commit: r1847417 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java w

2018-11-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/26/18 11:19, Christopher Schultz wrote: > All, > > On 11/25/18 10:49, schu...@apache.org wrote: >> Author: schultz Date: Sun Nov 25 15:49:28 2018 New Revision: >> 1847417 > >> URL: http://svn.apache.org/v

Re: Security of cluster's EncryptInterceptor

2018-11-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/20/18 14:02, Christopher Schultz wrote: > All, > > On 11/20/18 13:46, Christopher Schultz wrote: >> All, > >> I'd like a sanity-check on something I've done for the >> EncryptIntercepto r. &g

Re: svn commit: r1847636 - /tomcat/trunk/java/org/apache/catalina/core/StandardServer.java

2018-11-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 11/28/18 08:06, r...@apache.org wrote: > Author: remm Date: Wed Nov 28 13:06:09 2018 New Revision: 1847636 > > URL: http://svn.apache.org/viewvc?rev=1847636&view=rev Log: Fix > javadoc > > Modified: > tomcat/trunk/java/org/apache/catalin

Re: svn commit: r1847714 - /tomcat/native/trunk/native/src/sslconf.c

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Jean-Frederic, On 11/29/18 08:06, jfcl...@apache.org wrote: > Author: jfclere Date: Thu Nov 29 13:06:21 2018 New Revision: > 1847714 > > URL: http://svn.apache.org/viewvc?rev=1847714&view=rev Log: Allow > to compile with --enable-insecure-export-ci

Re: Current problems with TLS 1.0 and NIO(2)+native+openssl 1.1.1

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 11/29/18 08:27, Rémy Maucherat wrote: > On Sun, Nov 25, 2018 at 10:42 AM Rainer Jung > wrote: > >> In our Java code, what happens is a call to unwrap() in >> OpenSSLEngine. This call writes I think 146 bytes, then checks >> pendingReadab

Re: svn commit: r1847714 - /tomcat/native/trunk/native/src/sslconf.c

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Jean-Frederic, On 11/29/18 12:18, jean-frederic clere wrote: > On 29/11/2018 18:13, Christopher Schultz wrote: >> Jean-Frederic, >> >> On 11/29/18 08:06, jfcl...@apache.org wrote: >>> Author: jfclere Date: Thu Nov

Re: Tagging Tomcat Native 1.2.19

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/29/18 16:29, Mark Thomas wrote: > I think the issues are resolved now so I plan to review the > current state of the code and then tag either later today or early > tomorrow. +1 - -chris -BEGIN PGP SIGNATURE- Comment: Using Gnu

Re: svn commit: r1847854 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-12-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/30/18 15:59, ma...@apache.org wrote: > Author: markt Date: Fri Nov 30 20:59:37 2018 New Revision: 1847854 > > URL: http://svn.apache.org/viewvc?rev=1847854&view=rev Log: > Clean-up file created during test It was actually intentional

Re: Time for 8.5.36?

2018-12-11 Thread Christopher Schultz
All, On 12/11/18 08:21, Mark Thomas wrote: > Chris, > > Are you still interested in being RM for this? I don't think I'm quite ready to take over for 8.5.36, but I would like to work towards it. I haven't been able to get the build to run 100% in my Windows VM yet. This time around, I'll see w

Re: Time for 8.5.36?

2018-12-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Just confirming that I did indeed send the below message. I was having a problem with gpg-agent on my laptop and getting really weird errors when attempting to sign the message. Thanks, - -chris On 12/11/18 22:57, Christopher Schultz wrote

Re: svn commit: r1848806 - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/jasper/ org/apache/jasper/compiler/ org/apache/jasper/resources/ org/apache/jasper/runtime/ or

2018-12-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 12/12/18 17:42, Rémy Maucherat wrote: > On Wed, Dec 12, 2018 at 11:29 PM wrote: > >> Author: remm Date: Wed Dec 12 22:29:52 2018 New Revision: >> 1848806 >> >> URL: http://svn.apache.org/viewvc?rev=1848806&view=rev Log: Add >> i18n for j

Re: svn commit: r1848810 - in /tomcat/trunk: java/javax/servlet/http/HttpServlet.java test/javax/servlet/http/TestHttpServlet.java webapps/docs/changelog.xml

2018-12-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/12/18 18:26, Mark Thomas wrote: > On 12/12/2018 23:25, ma...@apache.org wrote: >> Author: markt Date: Wed Dec 12 23:25:39 2018 New Revision: >> 1848810 >> >> URL: http://svn.apache.org/viewvc?rev=1848810&view=rev Log: >> Ensure that th

Re: [Bug 63009] Content-Length header is dropped when HTTP2 is used

2018-12-14 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Is this bad enough to pull and re-roll the latest 8.5.x release? Missing Content-Type is ... pretty bad. - -chris On 12/14/18 12:39, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=63009 > > Mark Thomas changed:

Re: [VOTE] Release Apache Tomcat 8.5.37

2018-12-16 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 12/12/18 08:22, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.37 release is now available for > voting. > > The major changes compared to the 8.5.35 release are: > > - Implement the requirements of section 8.2.2 2.c of the Servlet >

Re: [Bug 63009] Content-Length header is dropped when HTTP2 is used

2018-12-16 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 12/14/18 17:05, Caldarale, Charles R wrote: >> From: Christopher Schultz [mailto:ch...@christopherschultz.net] >> Subject: Re: [Bug 63009] Content-Length header is dropped when >> HTTP2 is > used > >> Is

Re: [VOTE] Release Apache Tomcat 8.5.37

2018-12-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/17/18 05:49, Mark Thomas wrote: > On 16/12/2018 16:02, Christopher Schultz wrote: > > > >> I've got a signature problem with the Windows installer (see >> below). Everything else seems okay. I'll ho

Re: [VOTE] Release Apache Tomcat 8.5.37

2018-12-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/17/18 11:37, Mark Thomas wrote: > On 17/12/2018 16:21, Christopher Schultz wrote: > > > >> 16-Dec-2018 11:01:04.189 INFO [main] >> org.apache.catalina.tribes.transport.ReceiverBase.bind Unable to >>

Re: [VOTE] Release Apache Tomcat 8.5.37

2018-12-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Thanks for volunteering to RM this release. Sigs are correct. Unit test failure is environmental in nature. +1 to release STABLE 8.5.37 - -chris On 12/16/18 11:02, Christopher Schultz wrote: > All, > > On 12/12/18 08:22, Mark Tho

Re: svn commit: r1811614 - in /tomcat/trunk: bin/ciphers.sh java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java

2017-10-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 10/10/17 4:49 AM, Mark Thomas wrote: > On 09/10/17 22:55, schu...@apache.org wrote: >> Author: schultz Date: Mon Oct 9 21:55:29 2017 New Revision: >> 1811614 >> >> URL: http://svn.apache.org/viewvc?rev=181161

Time for 7.0.83?

2017-11-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All (particularly Violetta), With Java 9 officially released and the latest Tomcat 7 release not starting due to the inclusion of the "endorsed dirs" system property, I think it makes sense to do another Tomcat 7.0.x release. Rainer put the fix int

Re: Time for 7.0.83?

2017-11-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/6/17 10:44 AM, Mark Thomas wrote: > On 6 November 2017 15:35:16 GMT+00:00, Christopher Schultz > wrote: >> All (particularly Violetta), >> >> With Java 9 officially released and the latest Tomcat 7 release &g

Re: [VOTE] Release Apache Tomcat Native 1.2.16

2017-11-16 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/15/17 6:03 AM, Mark Thomas wrote: > Version 1.2.16 includes the following changes compared to 1.2.14: > > - Update minimum recommended OpenSSL version to 1.0.2m - Update > minimum recommended APR version to 1.6.3 - Windows binaries buil

Re: svn commit: r1815840 - /tomcat/trunk/conf/jaspic-providers.xml

2017-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/20/17 3:03 PM, ma...@apache.org wrote: > Author: markt Date: Mon Nov 20 20:03:34 2017 New Revision: 1815840 > > URL: http://svn.apache.org/viewvc?rev=1815840&view=rev Log: Revert > accidental commit > > Modified: tomcat/trunk/conf/jasp

Re: [PROPOSAL] Drop some JK components

2017-11-22 Thread Christopher Schultz
Mark, On 11/21/17 7:58 AM, Mark Thomas wrote: > All, > > I've been looking at jk/trunk with a view to rolling a release in the > near future. (It has been just over a year since the last release.) > > As I have been looking through the source, I have noticed a number of > components that we stil

Incorrect version number listed for Tomcat 6.0.x

2017-12-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I'm not sure if anyone actually cares, but the archive page for Tomcat 6 says that the latest stable version is 6.0.45 when it appears to be 6.0.53. https://archive.apache.org/dist/tomcat/tomcat-6/ I have no idea how to change that. Thanks,

Re: svn commit: r1817800 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/security/SecurityClassLoad.java webapps/docs/changelog.xml

2017-12-11 Thread Christopher Schultz
Mark, On 12/11/17 12:47 PM, ma...@apache.org wrote: > Author: markt > Date: Mon Dec 11 17:47:03 2017 > New Revision: 1817800 > > URL: http://svn.apache.org/viewvc?rev=1817800&view=rev > Log: > Pre-load additional classes to prevent SecurityExceptions if the first > request received when running

Re: Responsive Website

2017-12-19 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 12/19/17 11:29 AM, Igal Sapir wrote: > Hi everyone, > > The Tomcat website at http://tomcat.apache.org/ is not using > responsive design, and therefore is not very mobile-friendly. > > I have a lot of experience with Front End development

Re: [Git Migration] Review board

2018-01-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/4/18 5:29 AM, Mark Thomas wrote: > Happy New Year all! > > This is the first of the per issue e-mails to discuss the issues > associated with migrating from svn to git. > > Some years ago we looked at using review board. It didn't real

Re: [Git migration] trunk or master

2018-01-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/9/18 9:25 AM, Mark Thomas wrote: > On 09/01/18 07:06, Martin Grigorov wrote: >> Hi, >> >> On Jan 8, 2018 15:33, "Mark Thomas" wrote: >> >> This is the third of the per issue e-mails to discuss the issues >> associated with migrating f

Http11OutputBuffer mixes write strategies

2018-01-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, While reading this BZ issue[1], I decided to read the code referred to by Michael Osipov in Http11OutputBuffer.java. The method is sendStatus and looks roughly like this: write(Constants.HTTP_11_BYTES); headerBuffer.put(Constants.SP);

Re: [VOTE] Release Apache Tomcat 9.0.3

2018-01-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/11/18 6:29 AM, Mark Thomas wrote: > The proposed Apache Tomcat 9.0.3 release is now available for > voting. > > The major changes compared to the 9.0.2 release are: > > - Modify the Default and WebDAV Servlets so that a 405 status code

Re: Http11OutputBuffer mixes write strategies

2018-01-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/12/18 3:27 AM, Mark Thomas wrote: > On 11/01/18 23:12, Christopher Schultz wrote: > > > >> If performance is a consideration, then most of the calls to >> write() should probably be calls to headerBuffer.pu

Re: Closing channel sockets

2018-01-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/12/18 3:27 AM, Mark Thomas wrote: > On 12/01/18 08:04, Rémy Maucherat wrote: >> On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas >> wrote: >> >>> Hi, >>> >>> I've been looking at how we close NIO channels and I think >>> there is an oppor

Re: CPU security fixes and performance

2018-01-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 1/19/18 11:18 AM, Rémy Maucherat wrote: > I had a look at performance with the CPU security fixes on my > Fedora 27. Although it is a bit early for final conclusions, I can > report that they have an impact for Tomcat, but it doesn't seem >

Re: CPU security fixes and performance

2018-01-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 1/21/18 2:17 PM, Rémy Maucherat wrote: > On Sat, Jan 20, 2018 at 5:42 PM, Christopher Schultz < > ch...@christopherschultz.net> wrote: > > Rémy, > > On 1/19/18 11:18 AM, Rémy Maucherat wrote: >>>>

Re: Migrating to git

2018-01-24 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Coty, On 1/24/18 1:34 PM, Coty Sutherland wrote: > I think this is the right thread to add this :) > > Given that we will be able to accept PRs on Github after this > migration, do we want to add a Travis (or other CI) configuration > to our repos

Re: Mutual SSL client certificate validation(Key Usage and Extended Key Usage) in tomcat server

2018-02-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Indunil, On 2/1/18 7:29 AM, Indunil Rathnayake wrote: > I have configured a tomcat connector for handling requests for a > particular servlet and have configured a trust store for the > connector. Anyone knows whether tomcat handles validation of "K

Re: svn commit: r1849311 - in /tomcat/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java weba

2018-12-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 12/19/18 14:14, Rémy Maucherat wrote: > On Wed, Dec 19, 2018 at 5:13 PM wrote: > >> Author: markt Date: Wed Dec 19 16:13:46 2018 New Revision: >> 1849311 >> >> URL: http://svn.apache.org/viewvc?rev=1849311&view=rev Log: Fix >> https://bz

System properties: JVM launch versus catalina.properties

2018-12-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Someone asked this question on SO recently: https://stackoverflow.com/questions/53921375/tomcat-overriding-catalina- properties-from-commandline/53952396#53952396 TLDR: this person wants to set system properties in catalina.properties but be a

Re: System properties: JVM launch versus catalina.properties

2018-12-28 Thread Christopher Schultz
/"-D/' -e 's/$/"/' conf/system.not-properties $) $) ... java [script properties] $sysprops You still have the awful problem of quoting, though. - -chris > Le 28 déc. 2018 16:07, "Christopher Schultz" > a écrit : > > All, > > Someone asked this

Re: buildbot failure in on tomcat-85-trunk

2019-01-05 Thread Christopher Schultz
for this Build: silvanus_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'on-tomcat-85-commit' triggered this build Build Source Stamp: > [branch tomcat/tc8.5.x/trunk] 1850509 Blamelist: schultz > > B

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

2019-01-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Woonsan, On 1/4/19 05:11, Woonsan Ko wrote: > I've noticed in the commit messages that some i18n bundle files > showing Japanese correctly (e.g, > tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_ja.pr operties > > below) while sc

Re: buildbot failure in on tomcat-85-trunk

2019-01-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rainer, On 1/6/19 10:09, Rainer Jung wrote: > Hi Chris, > > Am 05.01.2019 um 22:25 schrieb Christopher Schultz: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All, >> >> Hmm... this my fault.

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

2019-01-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/6/19 16:37, Mark Thomas wrote: > On 06/01/2019 17:40, Christopher Schultz wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> Woonsan, >> >> On 1/4/19 05:11, Woonsan Ko wrote: >>>

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

2019-01-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/6/19 17:12, Mark Thomas wrote: > On 06/01/2019 21:51, Christopher Schultz wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> Mark, >> >> On 1/6/19 16:37, Mark Thomas wrote: >>>

Links to other websites in the documentation?

2019-01-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Would it be okay to link to another web site -- specifically, Wikipedia -- in the Tomcat documentation? I'd like to link to the page on "block cipher modes" from the EncryptInterceptor documentation. We have links to Oracle's documentation, s

Re: Links to other websites in the documentation?

2019-01-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 1/22/19 14:31, Igal Sapir wrote: > On Tue, Jan 22, 2019 at 11:09 AM Mark Thomas > wrote: > >> On 22/01/2019 18:13, Christopher Schultz wrote: >>> All, >>> >>> Would it be okay to link to anothe

Re: [Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-24 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/23/19 16:55, VP Brand wrote: > On 23/01/2019 21:48, bugzi...@apache.org wrote: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 >> >> --- Comment #14 from Mark Thomas --- Created >> attachment 36389 --> >> https://bz.apache.org/b

Proposal: BackupManager *is* "battle-tested"

2019-01-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, The documentation[1][2] for the cluster manager currently says: " Downside of the BackupManager: not quite as battle tested as the delta manager. " I think we can remove this qualification from the BackupManager at this point. In fact, we mig

Re: [VOTE] Release Apache Tomcat Native 1.2.21

2019-01-30 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/25/19 16:06, Mark Thomas wrote: > Version 1.2.21 includes the following changes compared to 1.2.19: > > - Fixed memory leak associated with the use of OpenSSL BIO (used > when OpenSSL provides the TLS functionality for the NIO and NIO2

APRLifecycleListener on Solaris + gcc

2019-02-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Ref: http://tomcat.apache.org/tomcat-9.0-doc/security-howto.html#Listene rs " The APR Lifecycle Listener is not stable if compiled on Solaris using gcc. If using the APR/native connector on Solaris, compile it with the Sun Studio compiler. "

Quick review of outline for Tomcat security presentation?

2019-02-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I'm going to be presenting at the upcoming Apache RoadShow in Washington, DC -- Monday, March 25th if you are local -- and my presentation is on locking-down Tomcat. I have an outline that I'd like anyone to take a look at. It's only 15 slide

Re: Quick review of outline for Tomcat security presentation?

2019-02-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, New and improved! With a link to the outline! https://people.apache.org/~schultz/Apache%20RoadShow%20DC%202019/Locking - -Down%20Apache%20Tomcat_outline.pdf Thanks, - -chris On 2/11/19 11:54, Christopher Schultz wrote: > All, > >

Re: Quick review of outline for Tomcat security presentation?

2019-02-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, Thanks for the review. On 2/11/19 15:24, Mark Thomas wrote: > On 11/02/2019 19:53, Christopher Schultz wrote: >> https://people.apache.org/~schultz/Apache%20RoadShow%20DC%202019/Lock ing >> >> >> - -Down%20Apache%

Re: [PROPOSAL] Copy DBCP 1.x (and POOL 1.x) source to 7.0.x

2019-02-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/12/19 08:55, Mark Thomas wrote: > Hi, > > Tomcat 7 depends on DBCP 1.x and POOL 1.x. The last release of each > of these was in 2013. There are a number of fixes I would like to > be able to pull into Tomcat 7 - including the fix for BZ

Re: [Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/13/19 06:46, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 > > --- Comment #26 from Mark Thomas --- Got it. > > With the single & the pid of the process that is put in the > background is not the pid

Confirming that UTF-7 is not a typo in Tomcat docs

2019-02-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I just wanted to confirm that UTF-7 is not a typo on this page: http://tomcat.apache.org/tomcat-9.0-doc/security-howto.html#System_Prope rties Under the system property ENFORCE_ENCODING_IN_GET_WRITER. I'm almost certain that it's *not* a typ

Re: Tag Tomcat 7

2019-02-15 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Violetta, On 2/15/19 05:37, Violeta Georgieva wrote: > На пт, 15.02.2019 г. в 10:24 ч. Mark Thomas > написа: >> >> >> >> On 15/02/2019 07:02, Violeta Georgieva wrote: >>> На вт, 12.02.2019 г. в 7:30 ч. Violeta Georgieva >>> написа:

Re: Git migration: new branch/tag naming scheme

2019-02-18 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/18/19 05:03, Mark Thomas wrote: > On 18/02/2019 09:13, Rémy Maucherat wrote: >> On Sat, Feb 16, 2019 at 4:09 PM Michael Osipov >> wrote: >> >>> Folks, >>> >>> given that we are currently in the process of migrating to Git >>> I'd like

DEBUG binaries for win32/win64

2019-02-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, At the risk of making the build for Windows even more onerous, would it be possible to distribute DEBUG builds along with the standard ones? The native stack trace in this bug report[1] for example is non-existent and useless because it just s

Re: DEBUG binaries for win32/win64

2019-02-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/25/19 09:42, Mark Thomas wrote: > On 25/02/2019 14:17, Christopher Schultz wrote: >> All, >> >> At the risk of making the build for Windows even more onerous, >> would it be possible to distribute DEBUG builds

Re: Tomcat Site Redesign

2019-03-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 3/4/19 01:02, Igal Sapir wrote: > I have uploaded the Tomcat site redesign to a temporary location > for review: http://people.apache.org/~isapir/mockups/tomcat-site/ > > The source can be seen at https://github.com/isapir/tomcat-website >

Re: Default Number of Test Threads

2019-03-15 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 3/14/19 16:29, Igal Sapir wrote: > On 3/14/2019 12:51 PM, Mark Thomas wrote: >> On 14/03/2019 19:26, Igal Sapir wrote: >>> Does test.threads default to 1 for a reason? >> Mostly historical. The tests weren't originally designed to run >> in

Re: Default Number of Test Threads

2019-03-15 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 3/15/19 16:45, Igal Sapir wrote: > On Fri, Mar 15, 2019 at 9:45 AM Konstantin Kolinko > wrote: > >> чт, 14 мар. 2019 г. в 22:26, Igal Sapir : >> What is the use case? People verifying a release? CI >> servers that may have different har

Re: Default Number of Test Threads

2019-03-16 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 3/15/19 22:38, Igal Sapir wrote: > Chris, > > On Fri, Mar 15, 2019 at 4:56 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >&

Re: svn commit: r1856174 [1/29] - in /tomcat/site/trunk: docs/ xdocs/ xdocs/stylesheets/

2019-03-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, You don't like leading whitespace, now? This diff looks ... WAY bigger than it should have been. - -chris On 3/25/19 05:26, ma...@apache.org wrote: > Author: markt Date: Mon Mar 25 09:26:32 2019 New Revision: 1856174 > > URL: http://svn.ap

Re: Tomcat Site Redesign

2019-03-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Konstantin, On 3/25/19 17:41, Konstantin Kolinko wrote: > My main concern is that the documentation is printable and is easy > to use as a reference document. > > 1) Not being able to print is a show-stopper. (Really.) Anything > else is just a per

Re: svn commit: r1856174 [1/29] - in /tomcat/site/trunk: docs/ xdocs/ xdocs/stylesheets/

2019-04-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Konstantin, On 3/25/19 16:24, Konstantin Kolinko wrote: > пн, 25 мар. 2019 г. в 20:13, Mark Thomas : >> >> On 25/03/2019 16:02, Christopher Schultz wrote: >>> Mark, >>> >>> You don't like leading wh

Re: [tomcat] 01/01: Fix wrong protocol version usage

2019-04-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael, On 3/31/19 04:03, micha...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > michaelo pushed a commit to branch wrong-http2-version in > repository https://gitbox.apache.org/repos/asf/tomcat.git

Re: [VOTE] Release Apache Tomcat 8.5.40

2019-04-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Gah. I replied to Mark only yesterday. :( On 4/10/19 10:58, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.40 release is now available for > voting. > > The major changes compared to the 8.5.39 release are: > > - Fix for CVE-2019-0232 a

Re: [VOTE] Release Apache Tomcat 8.5.40

2019-04-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 4/11/19 12:40, Mark Thomas wrote: > On 11/04/2019 15:21, Christopher Schultz wrote: > > > >> I'm having a bit of trouble building the bundled tcnative. I'm >> tried building against OpenSSL 1.0.2k and 1

Re: svn commit: r1681218 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c src/sslutils.c

2015-05-24 Thread Christopher Schultz
Rainer, On 5/22/15 3:54 PM, rj...@apache.org wrote: > Author: rjung > Date: Fri May 22 19:54:09 2015 > New Revision: 1681218 > > URL: http://svn.apache.org/r1681218 > Log: > Port mod_ssl improvements to tcnative/ssl: > > r1605827 | jorton | 2014-06-26 17:49:49 +0200 (Thu, 26 Jun 2014) | 6 lines

Re: svn commit: r1681321 - in /tomcat/native/trunk/native: include/tcn.h src/network.c src/poll.c

2015-05-24 Thread Christopher Schultz
Rainer, On 5/23/15 7:17 AM, rj...@apache.org wrote: > Author: rjung > Date: Sat May 23 11:17:11 2015 > New Revision: 1681321 > > URL: http://svn.apache.org/r1681321 > Log: > Forward port 1.1 changes to trunk: Thanks for doing this: trunk really needs to get back in shape. -chris signature.as

Re: Drop support for EXPORT ciphers in tcnative 1.1?

2015-05-24 Thread Christopher Schultz
Rainer, On 5/23/15 12:03 PM, Rainer Jung wrote: > mod_ssl dropped support for EXPORT ciphers in Apache 2.4 some time ago > and will also drop it in Apache 2.2 in the soon to be released next > version. > > I applied a similar change to tcnative trunk and would also like to > apply it to 1.1. +1

Re: Supporting multiple certificates

2015-05-25 Thread Christopher Schultz
Rainer, On 5/24/15 2:09 PM, Rainer Jung wrote: > mod_ssl supports multiple certificates for the same host, one with RSA > key, one with DSA key and one with EC key. They can be configured at the > same time. So the connector would be able to handshake using any of the 3 different types of certifi

Re: Drop support for EXPORT ciphers in tcnative 1.1?

2015-05-25 Thread Christopher Schultz
Rainer, On 5/24/15 2:12 PM, Rainer Jung wrote: > Am 24.05.2015 um 18:33 schrieb Mark Thomas: >> On 23 May 2015 17:03:21 BST, Rainer Jung wrote: >>> mod_ssl dropped support for EXPORT ciphers in Apache 2.4 some time ago >>> and will also drop it in Apache 2.2 in the sonn to be released next >>> ve

Re: Drop support for EXPORT ciphers in tcnative 1.1?

2015-05-25 Thread Christopher Schultz
Rainer, On 5/24/15 3:46 PM, Rainer Jung wrote: > Am 24.05.2015 um 20:10 schrieb Christopher Schultz: >> Rainer, >> >> On 5/23/15 12:03 PM, Rainer Jung wrote: >>> mod_ssl dropped support for EXPORT ciphers in Apache 2.4 some time ago >>> and will also

Re: Supporting multiple certificates

2015-05-28 Thread Christopher Schultz
Mark, On 5/27/15 4:56 AM, Mark Thomas wrote: > On 26/05/2015 08:28, Mark Thomas wrote: >> On 25/05/2015 15:18, Rainer Jung wrote: >> >> >> Mark has been doing a whole lot of work recently to both unify the TLS configuration across all connectors (OpenSSL and JSSE) as well as suppor

Re: Trimming Accepted Ciphers

2015-06-02 Thread Christopher Schultz
Robert, On 6/2/15 10:40 AM, Robert Paasche wrote: > Hi, > > I'm using tcnativ with: > SSLCipherSuite="EECDH+ECDSA+AESGCM:EECDH+aRSA+AESGCM:EECDH+ECDSA:EECDH:EDH+AESGCM:EDH:+3DES:ECDH+AESGCM:ECDH+AES:ECDH:AES:HIGH:MEDIUM:!RC4:!CAMELLIA:!SEED:!aNULL:!MD5:!eNULL:!LOW:!EXP:!DSS:!PSK:!SRP" > > To gen

Re: [PROPOSAL] Remove tomcat-jdbc from Tomcat 9 onwards

2015-06-03 Thread Christopher Schultz
Mark, On 6/3/15 6:08 AM, Mark Thomas wrote: > A connection pooling question on the users list prompted me to write a > short history [1] of Tomcat's connection pooling with respect to DBCP 1, > DBCP 2 and tomcat-jdbc. That got me thinking. > > Given the current situation: > - DBCP 2 is stable > -

Re: [Bug 58004] Possible memory leak on ClientAbortException in Ajp

2015-06-12 Thread Christopher Schultz
Rémy, On 6/12/15 11:52 AM, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=58004 > > Remy Maucherat changed: > >What|Removed |Added > > Resolutio

Re: svn commit: r1685253 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2015-06-16 Thread Christopher Schultz
referred TLS > -cipher suite ordering. This feature requires Java 8. > +cipher suite ordering. This feature requires Java 8 > +and is controlled by useServerCipherSuitesOrder > +attribute on an HTTP connector. > Based upon a patch provided by O

Re: porting netty-tcnative to tomcat-native

2015-06-16 Thread Christopher Schultz
Rémy, On 6/15/15 5:10 AM, Rémy Maucherat wrote: > 2015-06-15 10:42 GMT+02:00 Mark Thomas : > >>> It seems they are used in etPeerCertChain() and getCiphers() only, if >>> someone uses client certificates than might make sense. >> >> Those will get called more than once so no objection to caching

Re: removing empty stubs in tc-native trunk

2015-06-16 Thread Christopher Schultz
Jean-Frederic, On 6/15/15 7:27 AM, jean-frederic clere wrote: > We have empty stubs in tc-native when openssl isn't detected, are those > still needed? > > With NIO and NIO2 connectors we don't need native when we aren't using SSL. > > Comments? Having #ifdef'd some of those stubs myself, the

Re: Multi-threaded unit tests

2015-06-16 Thread Christopher Schultz
Mark, On 6/15/15 8:02 AM, Mark Thomas wrote: > I have been experimenting with the free Azure credits that come with the > MSDN subscription Microsoft kindly offers to all Apache committers to > use for their ASF work. > > I have been looking at options for making the unit tests run faster. > > A

Re: Multi-threaded unit tests

2015-06-16 Thread Christopher Schultz
Mark, On 6/16/15 4:13 PM, Mark Thomas wrote: > On 16/06/2015 20:39, Christopher Schultz wrote: >> Mark, >> >> On 6/15/15 8:02 AM, Mark Thomas wrote: >>> I have been experimenting with the free Azure credits that come with the >>> MSDN subscription Microsoft

<    15   16   17   18   19   20   21   22   23   24   >