-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Mark,

On 11/15/17 6:03 AM, Mark Thomas wrote:
> Version 1.2.16 includes the following changes compared to 1.2.14:
> 
> - Update minimum recommended OpenSSL version to 1.0.2m - Update
> minimum recommended APR version to 1.6.3 - Windows binaries built
> with OpenSSL 1.0.2m and APR 1.6.3
> 
> Various other fixes and improvements. See the changelog for
> details.
> 
> The proposed release artefacts can be found at [1], and the build
> was done using tag [2].
> 
> The Apache Tomcat Native 1.2.16 is [X] Stable, go ahead and
> release

Tested on x86-64 Linux without /using/ any crypto features (but built
with crypto features included).

Notes:

Built on Debian (gcc 4.7.2) with APR 1.4.6 and OpenSSL 1.0.2k. No
compiler errors or warnings.

Configured Tomcat 8.0.47 with two APR-based connectors:

Nov 15, 2017 2:54:02 PM org.apache.catalina.core.AprLifecycleListener
lifecycleEvent
INFO: Loaded APR based Apache Tomcat Native library 1.2.16 using APR
version 1.4.6.
Nov 15, 2017 2:54:02 PM org.apache.catalina.core.AprLifecycleListener
lifecycleEvent
INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters
[false], random [true].
Nov 15, 2017 2:54:02 PM org.apache.catalina.core.AprLifecycleListener
initializeSSL
INFO: OpenSSL successfully initialized (OpenSSL 1.0.2k  26 Jan 2017)

...

Nov 15, 2017 2:54:26 PM org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler ["ajp-apr-8215"]
Nov 15, 2017 2:54:26 PM org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler ["http-apr-127.0.0.1-8217"]

Initial use of the connectors looks just fine.

I did not actively use any SSL-related capabilities.

"make check" fails. Looks like there are no automated checks for
tcnative. We should probably add some or remove that target.

Did a quick test build on MacOS 10.3 (clang-900.0.38) against APR
1.5.2 and OpenSSL 1.0.2j. Only a single warning was produced:

src/ssl.c:203:6: warning: implicit conversion from 'long' to 'jint'
(aka 'int') changes value from 4292828079 to -2139217
[-Wconstant-conversion]
     | 0;
     ^~~
1 warning generated.

Re-building against APR 1.5.2 and LibreSSL 2.6.3 produced a different
warning:

src/ssl.c:367:5: warning: implicit declaration of function
'SSL_COMP_free_compression_methods' is invalid in C99
[-Wimplicit-function-declaration]
    SSL_COMP_free_compression_methods();
    ^
1 warning generated.

Note that I performed compile-tests ONLY on MacOS, no actual live testin
g.

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQJRBAEBCAA7FiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAloNnqAdHGNocmlzQGNo
cmlzdG9waGVyc2NodWx0ei5uZXQACgkQHPApP6U8pFgoww//cGfRn+ek8TnLNlN5
KoUSiQf10jgds4GH3xa73tXcrku8CrIuxGdQBXz0cHQQb8MRG7IIsuXohRb4uiYX
UHV6ErRAJV26Ii3HFV1FHBcHtRY6DZClv1wN3pWjczMLDRqCr7hA7XRQaG15vpmU
WrQsjzY2YPM4Bl2QO5ieEu7eFcMBv4XTUPMUOjrb/FrK7wS1+iXtn5oP2jWkdHJX
53xe8VxZuREm5uks9NQgXD+FZH/6CpKREalIL+/uSCD0caO7KFUATZd+qWck+aov
fDv2G/PS6aLPVX3GD/S1Zd+l7YCVZzumBpPjy8/C0KgRXfNl7jylcYV5D9i7EI3n
d+yJ/3ER3EnrcFxqzpBBHjOH2E0IpjiUtrT9AIaKe/YjU2M3IF2kEF5RAfkzrE5f
vdPOcv3csmQyAb4qaFTdz62Zlj4ahtsBR6S30M28d/4lfW5MDMgNApqqZqmXe8gk
ET1g5h6f47d6+KLvt3PjxquMc5ebV9LIgvavlGESObDD2VPVioy+PwpZJMdaXEj3
Uv521FgZQ6ULmxq7QeZc1YxqmiYGCVTeVnDrDfxeyylkuqNGqcVnO5oCDbgCUM2O
FdRp+Sx/stRlORO4ZzTpaFVOlWv0AWDOCwInMntqUroJQHMsfP4CTTzt9+EFphgS
xLPI932pTx6ewMZP58x5erFTXks=
=NDzZ
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to