-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 4/11/19 12:40, Mark Thomas wrote: > On 11/04/2019 15:21, Christopher Schultz wrote: > > <snip/> > >> I'm having a bit of trouble building the bundled tcnative. I'm >> tried building against OpenSSL 1.0.2k and 1.1.1 and both of the >> "configure" invocations given me a message similar to the >> following: >> >> checking for OpenSSL library... using openssl from >> /home/cschultz/openssl-1.0.2k/target/target/${exec_prefix}/lib >> and /home/cschultz/openssl-1.0.2k/target/target/include checking >> OpenSSL library version >= 1.0.2... configure: error: Your >> version of OpenSSL is not compatible with this version of >> tcnative >> >> Any ideas for what to check? That ${exec_prefix} in there looks a >> little fishy. Here's my configure command: >> >> ./configure --with-apr=/usr/bin >> --with-ssl=/home/cschultz/openssl-1.0.2k/target/target > > That looks odd with 2 targets on the end. You're right, it does. I corrected that and it seems that was the problem. :( That "configure" command was generated by my test-tomcat script. Hmm. I'll have to see what's wrong, there. Aha. A hardware migration + directory re-organization has simply broken the path. Oddly, this causes the build to fail. Had it fallen-back to the OS's default OpenSSL version (1.1.0j in my case), I would have expected it to succeed. Perhaps the fallback isn't working reliably? >> --with-java-home=/usr/lib/jvm/java-8-openjdk-amd64 > > I did a little testing with this. > > I agree the ${exec_prefix} looks odd but it doesn't appear to be > breaking anything. > > When I provide a valid path to an OpenSSL build everything works > as expected (1.0.2, 1.1.0, 1.1.1 and master). > > When I provide an invalid path to an OpenSSL build then it appears > to pick up up the version of OpenSSL installed by the OS. > > I see two (minor) problems we could fix: > > 1. The ${exec_prefix} oddity > > 2. If an invalid OpenSSL path is specified the build should fail > rather than pick up a system default. > > Given that everything appears to work as intended with valid input, > I don't see any immediate need to roll a Tomcat Native release. +1 - no release is necessary. - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlyvdkIACgkQHPApP6U8 pFiYohAAmO0ouLCMydseViHj2PxfP10mj7uvgB5tCM8FEcoluuB97Lrq1erCT/CY EC5DHGuRdOBvIv+DSw4qkUOE0cCTUe90KZhoWPKJYQuM/Ins+fQwSy98aJMmXLHD d3rvyZ4fGnF6twwg6Sf/eFstq1tzkqUIC0cPuVwytirqZDNCVdgTSLp0xUkEf8yp wFY2AAjOGuW6fTLCs7ie85JrAF/eo9vjM40HRCTTpCL03gYvPi5mfYNbEtLUWJ4K 0qZOJGvbl8oxuAkG42ZzUZueA/pEtZDk6jfD1KDc8OOOkk77Yix/gVHdwSZpZR8l F8ihXEAigUdRqEyFo0sQ0KyaRq27E5yrrMMURpN2iOYJl9pyhcpowIEF7NMwMVYM tfH01qg/D/2AQYnpYnO9o7ou1rsyyXWVViJu6xIkZwC7eHuWkfGjQHGrfcYkc95o erTZ/VTkBE95zLNJHfkrMb3NQ7vX1h0E8hfBAIJNnhMrVRPbfsdGDjU+KST6qoid MXuQnvIefp2CQCtqPVSUVxC9irXdDWeR/IIDNThguVOu69SrEkK7BGQyHGEpPQvV 7ieuWQ4PVyQw85QUdzkbIhAtswl75b118e/NUtBiijUCGtX/tgLpaSgME+TeENny E3v0GaU1aLD9l9mwCQqWz5BEFHAymxC0XxqzPhsiSnLB21xA/hs= =6Wkm -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org