-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Mark,

On 2/13/19 06:46, bugzi...@apache.org wrote:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=63041
> 
> --- Comment #26 from Mark Thomas <ma...@apache.org> --- Got it.
> 
> With the single & the pid of the process that is put in the
> background is not the pid of the Tomcat process. If I specify
> $CATALINA_PID and then configure systemd to use the same file with
> PIDFILE everything starts working.
> 
> That final "&" prevents the eval command being written to the
> console when using catalina.sh start
> 
> Assuming the above is correct I think we have two options:
> 
> 1. Revert the "&" -> "&&" change. systemd users (and possibly
> others) will be required to use a PID file and to tell systemd
> where to find that file.
> 
> 2. Revert both changes. systemd users will have to take no action.
> Users wanting to redirect to a command will have to use a named
> pipe.

+1 on option 2

pid-files are anathema to systemd, so let's do them a favor. Also,
logging huge amounts of data to an unrotatable file is something users
have to swallow if they want to dump huge amounts of data to it.

Finally, using a named-pipe is possible with the original startup
script, so we aren't taking anything away from anyone.

> I'm leaning towards 2 on the grounds this has the least impact on
> the smallest number of users. This assumes that the number of
> systemd users is greater than the number of users wanting to
> redirect to a command.

+1

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlxkKMIACgkQHPApP6U8
pFhRhxAAkOAiINas0qjNUFevzJOB3wVpiAjT4mJ338571582WazD7gLX66knDlRV
UC1TXvENI/HADcpjgu2ncA7O8qHaEv3Sf5ZGN+JzYHfzVcwPBGq9P2N8WNZoFV6O
qpYNfBj5Ph37ecxLzYYw0fCTVmNXoOpPqc+7c08VqxXSpJ89C0sYCbZhA1CKLJQr
J3adJLrVdUOJSGBMEJaYzdKH6kWHVwZSohq5qsqfJrgfKkaSn8f/usq6Qdzawnd5
RDIzNYvPAkfid9VleS43kVhiKAR5+xhQMUkygVWQxCrnOdciI3UFrVUGaxHb843r
j0NnLneqAqcQC6ECR/bX087tSU/XpVd3BvS7H/DSxGnd/fZFL2yhV29nE9iMBKOj
YjOKRdVCXZJRbf+OqweMM7GpSYdBd3AHNqtfilAR5id9PbxhwoJzBd6Ebck+mw05
jmDsNirX6PFSoaC6+bnlAsdlcMGNtBj4h84SA65jtNhdSJPymC+osbaM6Or8VeIi
EHbLWusYK7JWrBP7myQzLYfiXNw2Fa6G3pfTBCt8B+VI2FW37692d3qFwWjY2ZDj
84yoPNreli1Pgud6bzc5eqwGkWwdDuYLnzKAUK1EQ3h3G4lhZvZiVrD/bQCqo64f
q8tQpyXBQPcX13252ZjTHF6FXJ+inE5XMS7to1T/U+YLnf/oeCk=
=M6xb
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to