-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 2/12/19 08:55, Mark Thomas wrote: > Hi, > > Tomcat 7 depends on DBCP 1.x and POOL 1.x. The last release of each > of these was in 2013. There are a number of fixes I would like to > be able to pull into Tomcat 7 - including the fix for BZ 58338. > > There is little/no appetite in the Commons community to release > DBCP 1.x or Pool 1.x. > > Having tried to get releases out via the release process Commons > uses, I have no desire to try and get these releases out myself. > > It would greatly simplify things if 7.0.x took the same approach to > DBCP and Pool as 8.5.x and 9.0.x and maintained a local fork of the > code. > > Like the fork of DBCP 2.x and Pool 2.x, changes would be made in > commons and the Tomcat fork updated. The only local changes would > be the package re-naming and and changes required to keep > checkstyle and FindBugs happy (and some of those may get made in > Commons first). > > I therefore propose to import the DBCP/Pool 1.x source into Tomcat > 7.x following the same pattern as for DBCP/Pool 2.x in 8.5.x. > > If there are no objections, I'll probably do this late this week > early next. Is there any appetite for maintaining patches-only and merging-on-build? It would mean a smaller repo for us not just in terms of size (which is largely irrelevant) but also in terms of brain-cycles. If I can see that we patch pool-1.x with a 5-line change and add a sour\ce file versus there are 500 source files in there that all need to be diff'd against their original sources, it makes it easier for anyone to look at the code to see what's happening. It does complicate the release process, though. - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlxjUlUACgkQHPApP6U8 pFjZ1g/9EdYu1jC2JDTd6F6X7QZx7i+1VXKytdr0umzFfqKDQ+pbsVIKZDDWgoLU cHRX/2jw3IBpObxTL/44cJNGvy2g9PGOKL4I7IQHF1/zm9jyspTmp01JIPbznWgK /Kw0+lbsd0parxu+UzEzV4plDHLg4uyvTEXdmKr0ZMoe2MqSYSUR6zHIcGPIVW/T JLwpxVkk4alpRonYquOdKVB9W6iH67/OgqVLyrLNP+KBU2RTHCL5/OP6FVcEIWvZ Hqekt8q8tZQA1biGUTFNzp15P3oseugwd2DVrstvbEapF37juRJIOApMxONBjIXQ ntQ1d8T6RwD743ThRQfyn3BI8DoZua7LYLIgeRyaV3PYij3uklyeGuY8xtsQxJtz Q3vfDEuHg+AqFvnSvjjDnbX4umybNsxGq1W5zYyhCOyaMcXVsvTVgYu6nRw3esc7 jhuB+3PDAB6glQ7Hy4b0ugmjte5pGmQGjczW/8S6KBvlqJwjR8RKykjX9oT8Yr16 2hPL9EZaUyDfda0v/u/fQZAJdqZqEwdXXgQUh4BgBInX30QMo5BlT5OgBipA4Jtt +lmf1bNlviIpbc800t35VswXzzp4Joh8r1wYKuWMwBlPT9fR60EcSWgwm2tutyJw yA6YZs63PkYHhwxCDwdBE59e36ZJuqL3R/rwXcMS/xAAWxu7Tjg= =wXz0 -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
