Re: svn commit: r1303339 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/RealmBase.java webapps/docs/changelog.xml

2012-04-24 Thread Mark Thomas
On 24/04/2012 20:51, Brian Burch wrote: > Sorry I haven't been able to quote the details of this commit made by > markt a month ago, but I didn't keep a copy in my inbox. > > I previously submitted an enhancement to the corresponding test suite > https://issues.apache.org/bugzilla/show_bug.cgi?id=

Re: svn commit: r1303339 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/RealmBase.java webapps/docs/changelog.xml

2012-04-24 Thread Mark Thomas
On 24/04/2012 21:11, Mark Thomas wrote: > On 24/04/2012 20:51, Brian Burch wrote: >> Sorry I haven't been able to quote the details of this commit made by >> markt a month ago, but I didn't keep a copy in my inbox. >> >> I previously submitted an enhanc

Re: svn commit: r1303339 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/RealmBase.java webapps/docs/changelog.xml

2012-04-25 Thread Mark Thomas
On 25/04/2012 12:03, Brian Burch wrote: > On 24/04/12 21:34, Mark Thomas wrote: >> On 24/04/2012 21:11, Mark Thomas wrote: >>> On 24/04/2012 20:51, Brian Burch wrote: >>>> Sorry I haven't been able to quote the details of this commit made by >>>> ma

Re: asp file and session creation

2012-04-26 Thread Mark Thomas
On 26/04/2012 19:54, gunay arslan wrote: > Here I am not telling that we need to change the standards, I am > suggesting to add a variable so for this session behavior, with > default value running as it is right now, you need to check other > lazy session creation change to value, restart the app

Re: Duplicate String values

2012-04-27 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/04/2012 01:37, Christopher Schultz wrote: > All, > > I've been doing some memory profiling on my webapp to see where I > can reduce our memory footprint a bit by combining equivalent > objects. YourKit has some nice utilities to look for duplica

Re: Problem in WebSocket

2012-05-01 Thread Mark Thomas
On 01/05/2012 19:27, umar farooq wrote: > Hi All, >I am trying to use Chat example of WebSocket given in Tomcat version > 7.0.27. Problem I faced are here. > > 1) After opening the web socket it closes the socket automatically after 20 > sec. I want connection open until Guest (i.e. user

Re: Problem in WebSocket

2012-05-01 Thread Mark Thomas
On 01/05/2012 20:43, umar farooq wrote: > I got it. I will make my application to handle groups. but how can I > increase keep alive time..?? to be specific .. what steps do I need to > follow..? That would be a question for the users mailing list. Mark > > On 5/1/12, Mark Thoma

Re: [JK] Tagging 1.2.36

2012-05-07 Thread Mark Thomas
On 07/05/2012 10:01, Mladen Turk wrote: > Hi, > > I plan to tag 1.2.36 (as promised after finishing shm rewrite). > There is one nasty bug in windows status worker and sharing > actually doesn't work in 1.2.35, so a couple of very good > reasons for a quick release. > > Comments? +1 Go for it.

Re: Purpose of unlockAccept

2012-05-07 Thread Mark Thomas
On 07/05/2012 17:24, Mladen Turk wrote: > Hi > > Did some testing and removing unlockAccept works equally > fine (and in some circumstances pause/continue and even shutdown is much > faster). > Using a simple socket close on stop/destroy and monitoring > for pause 'after' acceptSocket() by not han

Re: Purpose of unlockAccept

2012-05-08 Thread Mark Thomas
On 08/05/2012 07:41, Mladen Turk wrote: > On 05/08/2012 08:34 AM, Costin Manolache wrote: >> On Mon, May 7, 2012 at 11:05 PM, Mladen Turk wrote: >> >>> >>> For real pause (stop accepting connections and wait till all sessions >>> times out) this can be done safely by setting 10 second timeout >>>

Re: Purpose of unlockAccept

2012-05-08 Thread Mark Thomas
On 08/05/2012 19:47, Costin Manolache wrote: > You may still want to accept requests for existing sessions. > > Both 'graceful shutdown' and app deploy are important cases - it's just > that current 'pause()' is not that good for either of them, if you really > want to cleanup... > > Maybe an opt

Re: Purpose of unlockAccept

2012-05-08 Thread Mark Thomas
On 08/05/2012 21:09, Costin Manolache wrote: > On Tue, May 8, 2012 at 11:54 AM, Mark Thomas wrote: >> pause() on the connector means something very different to pause in the >> reverse proxy. In the connector pause means: >> - stop processing new connections >> -

Re: Purpose of unlockAccept

2012-05-08 Thread Mark Thomas
On 08/05/2012 21:33, Mladen Turk wrote: > On 05/08/2012 08:54 PM, Mark Thomas wrote: >> On 08/05/2012 19:47, Costin Manolache wrote: >>> You may still want to accept requests for existing sessions. >>> >>> Both 'graceful shutdown' and app deploy ar

Re: svn commit: r1337643 - /tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java

2012-05-12 Thread Mark Thomas
On 12/05/2012 23:14, Konstantin Kolinko wrote: > 2012/5/13 : >> Author: markt >> Date: Sat May 12 20:51:24 2012 >> New Revision: 1337643 >> +if (inner instanceof RequestFacade) { >> +((RequestFacade) req).doUpgrade(inbound); > > inner.doUpgrade(), not req. Doh. > >> +

Re: svn commit: r1337741 - /tomcat/trunk/webapps/examples/WEB-INF/classes/RequestInfoExample.java

2012-05-13 Thread Mark Thomas
On 13/05/2012 00:56, kkoli...@apache.org wrote: > Author: kkolinko > Date: Sat May 12 23:56:13 2012 > New Revision: 1337741 > > URL: http://svn.apache.org/viewvc?rev=1337741&view=rev > Log: > Pass all string values through the filter in RequestInfoExample servlet. Those values were not passed thr

Re: [ANN] Apache Tomcat Connectors 1.2.35 released

2012-05-17 Thread Mark Thomas
On 17/05/2012 05:22, Mladen Turk wrote: > Crap. > Not only late, but with the wrong @subject. > Well, hope people will figure that out. I haven't moderated the mail to announce@t.a.o through. If you want to resend that with the correct subject you can. Mark --

APR/native and per socket timeouts.

2012-05-20 Thread Mark Thomas
Currently, time outs for APR/native sockets are managed at the Pollset level. This means all sockets in a single Pollset must have the same time out. This is starting to become a nuisance. I have already had to add a second Pollset to AprEndpoint to handle separate connection and keep-alive time o

Re: APR/native and per socket timeouts.

2012-05-20 Thread Mark Thomas
etter but only if there is a real need :-) > > Btw, i'll take a look to your commits. > > Le 20 mai 2012 à 20:37, Mark Thomas a écrit : > >> Currently, time outs for APR/native sockets are managed at the Pollset >> level. This means all sockets in a single Poll

Re: APR/native and per socket timeouts.

2012-05-20 Thread Mark Thomas
d different time outs increases. Mark > > Just an idea. > > Le 20 mai 2012 à 20:37, Mark Thomas a écrit : > >> Currently, time outs for APR/native sockets are managed at the Pollset >> level. This means all sockets in a single Pollset must have the same >> tim

native connector tool chain

2012-05-21 Thread Mark Thomas
I am trying to build the 1.1.x native connector from trunk so I can test the changes I plan to make to support per socket time outs. I can build using dynamic linking but not statically. What tool chain are folks currently using to build the native connector binaries we currently ship? My current

Porting native fixes from trunk to 1.1.x

2012-05-21 Thread Mark Thomas
Just a quick check before I hit commit. Am I correct in thinking that r1296944 [1] should be back-ported to 1.1.x? Cheers, Mark [1] http://svn.apache.org/viewvc?view=revision&revision=1296944 - To unsubscribe, e-mail: dev-unsu

Re: Porting native fixes from trunk to 1.1.x

2012-05-21 Thread Mark Thomas
On 21/05/2012 13:25, Mark Thomas wrote: > Just a quick check before I hit commit. Am I correct in thinking that > r1296944 [1] should be back-ported to 1.1.x? Ignore me. I now realise I am wrong since interrupt() isn't implemented in the 1.1.x br

Re: APR/native and per socket timeouts.

2012-05-21 Thread Mark Thomas
On 20/05/2012 21:47, Mladen Turk wrote: > On 05/20/2012 08:37 PM, Mark Thomas wrote: >> Therefore, I intend modifying the APR/native code to support per socket >> time outs. I would be grateful if those of you with more C knowledge >> than I (which is most people on this list)

Re: APR/native and per socket timeouts.

2012-05-21 Thread Mark Thomas
se whenever you need from java ? The timeout is also used in poll so it wouldn't be a completely clean solution. It would probably work but there might be some odd edge cases. It think it is probably better - for now - to keep this in native. Mark > > Costin > > On Mon, May 21

Re: native connector tool chain

2012-05-21 Thread Mark Thomas
if only as protection against the current release manager being run over by a bus. Mark > > Costin > > On Mon, May 21, 2012 at 5:05 AM, Mark Thomas wrote: > >> I am trying to build the 1.1.x native connector from trunk so I can test >> the changes I plan to make

Re: native connector tool chain

2012-05-21 Thread Mark Thomas
On 21/05/2012 17:52, Mladen Turk wrote: > On 05/21/2012 02:05 PM, Mark Thomas wrote: >> I am trying to build the 1.1.x native connector from trunk so I can test >> the changes I plan to make to support per socket time outs. I can build >> using dynamic linking but not static

Re: APR/native and per socket timeouts.

2012-05-21 Thread Mark Thomas
On 21/05/2012 18:30, Costin Manolache wrote: > On Mon, May 21, 2012 at 9:29 AM, Mark Thomas wrote: > >> On 21/05/2012 15:26, Costin Manolache wrote: >>> My understanding is that the timeout is implemented in poll.c maintain() >> - >>> by scanning the socket

Re: native connector tool chain

2012-05-21 Thread Mark Thomas
On 21/05/2012 17:52, Mladen Turk wrote: > On 05/21/2012 02:05 PM, Mark Thomas wrote: >> I am trying to build the 1.1.x native connector from trunk so I can test >> the changes I plan to make to support per socket time outs. I can build >> using dynamic linking but not static

Re: svn commit: r1342010 - in /tomcat/native/branches/1.1.x: ./ native/src/poll.c

2012-05-24 Thread Mark Thomas
On 24/05/2012 05:19, Mladen Turk wrote: > On 05/23/2012 10:07 PM, ma...@apache.org wrote: >> Author: markt >> -apr_time_t*socket_ttl; >> -apr_interval_time_t max_ttl; >> +apr_time_t*socket_last_active; >> +apr_interval_time_t default_timeout; > > Think we should move both s

Re: svn commit: r1342010 - in /tomcat/native/branches/1.1.x: ./ native/src/poll.c

2012-05-24 Thread Mark Thomas
On 24/05/2012 16:06, Mladen Turk wrote: > On 05/24/2012 04:47 PM, Mark Thomas wrote: >> On 24/05/2012 05:19, Mladen Turk wrote: >>> On 05/23/2012 10:07 PM, ma...@apache.org wrote: >>>> Author: markt >>>> -apr_time_t*socket_ttl; >>>>

Re: A small question regarding connector.Request.getCoyoteRequest method

2012-05-28 Thread Mark Thomas
On 28/05/2012 14:07, N V Hari Krishna wrote: > Hello all, > > I had few questions regarding > org.apache.connector.Request.getCoyoteRequest() method. > > My questions are: > > Request.getCoyoteRequest() method's corresponding response method > org.apache.catalina.connector.Response.getCoyoteResp

Re: [Bug 53326] New: -

2012-05-30 Thread Mark Thomas
On 30/05/2012 09:41, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=53326 > > Priority: P2 > Bug ID: 53326 > Assignee: dev@tomcat.apache.org >Summary: - > Severity: normal > Classification: Unclassified >

Re: svn commit: r1345021 - in /tomcat/tc7.0.x/trunk: ./ build.xml test/webapp-3.0/bug53257/index.jsp

2012-06-01 Thread Mark Thomas
On 01/06/2012 17:02, Konstantin Kolinko wrote: > 2012/6/1 : >> + >> + > > OK. I'll add them to res/rat/rat-excludes.txt, for RAT reports done by > buildbot > http://tomcat.apache.org/ci.html#Buildbot Cheers >> + > > ?? I do not see any files there. Did you forg

Re: JIRA configuration for MTOMCAT - attachments not allowed?

2012-06-01 Thread Mark Thomas
On 01/06/2012 19:53, Konstantin Kolinko wrote: > Hi! > > Looking at Tomcat Maven Plugin issues in JIRA, e.g. > there is no way to submit an attachment. There is no "Attach Files" button. > > If I look at some Apache Commons issues, the "Attach Files" button is there. > So that is some issue with

Re: StuckThreadDetectionValve proposal in Tomcat 6 - GitHub link is dead

2012-06-03 Thread Mark Thomas
On 03/06/2012 20:59, Henri Gomez wrote: > Did you contact him ? > > Btw, it could allways happen with external contributions, not GitHub related. Which is why a patch attached to BZ should be the preferred approach. > Le 3 juin 2012 à 21:02, Konstantin Kolinko a écrit : > >> Hi! >> >> I was go

Re: svn commit: r1345780 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/websocket/StreamInbound.java

2012-06-03 Thread Mark Thomas
On 03/06/2012 22:12, kkoli...@apache.org wrote: > Author: kkolinko > Date: Sun Jun 3 21:12:40 2012 > New Revision: 1345780 > > URL: http://svn.apache.org/viewvc?rev=1345780&view=rev > Log: > Merged revision 1345779 from tomcat/trunk: > Review of r1345737: Correct copy-pasted comments to match the

Re: svn commit: r1345580 - in /tomcat/trunk/java/org/apache/catalina/deploy: LocalStrings.properties NamingResources.java

2012-06-03 Thread Mark Thomas
Konstantin Kolinko wrote: >2012/6/3 : >> Author: markt >> Date: Sat Jun  2 21:18:53 2012 >> New Revision: 1345580 >> >> URL: http://svn.apache.org/viewvc?rev=1345580&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=5 >> Validate JNDI resource types against injecti

Re: svn commit: r1335700 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/

2012-06-04 Thread Mark Thomas
On 04/06/2012 07:55, Konstantin Kolinko wrote: > 2012/5/8 : >> Author: markt >> Date: Tue May 8 19:07:09 2012 >> New Revision: 1335700 >> >> URL: http://svn.apache.org/viewvc?rev=1335700&view=rev >> Log: >> It appears that pausing requests for a Context during reload was relying on >> the mapper

Re: svn commit: r1344253 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AjpAprProcessor.java webapps/docs/changelog.xml

2012-06-04 Thread Mark Thomas
On 04/06/2012 07:41, Konstantin Kolinko wrote: > 2012/5/30 : >> Author: markt >> Date: Wed May 30 13:35:55 2012 >> New Revision: 1344253 >> >> URL: http://svn.apache.org/viewvc?rev=1344253&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53119 >> Make sure the buffer is c

Re: svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java java/org/apache/tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread Mark Thomas
On 04/06/2012 17:05, Filip Hanik (mailing lists) wrote: > > Ok, this is back to code discipline. At some point, we'd have to > expect that more users will adopt v7 in production (I'm still seeing > 80%+ being on v6), at that point, commits like this do nothing except > pollute the diffs. It depen

Re: svn commit: r1345580 - in /tomcat/trunk/java/org/apache/catalina/deploy: LocalStrings.properties NamingResources.java

2012-06-04 Thread Mark Thomas
On 03/06/2012 23:58, Mark Thomas wrote: > Konstantin Kolinko wrote: >> Does something guarantee that there is always common type among >> injection targets? >> >> Can there be two disjoint interfaces A and B, which are both >> implemented by a resource, so as

Re: svn commit: r1346510 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java java/org/apache/tomcat/util/http/mapper/Mapper.java test/org/apache/tomcat/util/http/mapper/TestMapperCo

2012-06-05 Thread Mark Thomas
On 05/06/2012 19:29, Konstantin Kolinko wrote: > 2012/6/5 : >> Author: markt >> Date: Tue Jun 5 18:17:58 2012 >> New Revision: 1346510 >> >> URL: http://svn.apache.org/viewvc?rev=1346510&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53356 >> Add support for an explici

Re: svn commit: r1346510 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java java/org/apache/tomcat/util/http/mapper/Mapper.java test/org/apache/tomcat/util/http/mapper/TestMapperCo

2012-06-05 Thread Mark Thomas
On 05/06/2012 20:57, Konstantin Kolinko wrote: > 2012/6/5 : >> Author: markt >> Date: Tue Jun 5 18:17:58 2012 >> New Revision: 1346510 >> --- >> tomcat/trunk/test/org/apache/tomcat/util/http/mapper/TestMapperContextRoot.java >> (added) >> +++ >> tomcat/trunk/test/org/apache/tomcat/util/http/

Re: svn commit: r1346638 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/antlib.xml

2012-06-05 Thread Mark Thomas
On 05/06/2012 23:42, Konstantin Kolinko wrote: > 2012/6/6 : >> Author: markt >> Date: Tue Jun 5 22:38:53 2012 >> New Revision: 1346638 >> >> URL: http://svn.apache.org/viewvc?rev=1346638&view=rev >> Log: >> Remove unused file >> >> Removed: >>tomcat/tc7.0.x/trunk/java/org/apache/catalina/ant/

Re: svn commit: r1346638 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/antlib.xml

2012-06-05 Thread Mark Thomas
On 06/06/2012 00:22, Konstantin Kolinko wrote: > 2012/6/6 Mark Thomas : >> On 05/06/2012 23:42, Konstantin Kolinko wrote: >>> 2012/6/6 : >>>> Author: markt >>>> Date: Tue Jun 5 22:38:53 2012 >>>> New Revision: 1346638 >>>> &g

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-06-05 Thread Mark Thomas
On 05/06/2012 22:37, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-trunk/builds/3039 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for t

Re: Problem updating TC site

2012-06-06 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/06/2012 15:20, Christopher Schultz wrote: > All, > > I just made an update to the Tomcat site project and was trying to > publish it live following the instructions in README.txt. As such, > I ssh'd to people.apache.org, cd /www/tomcat.apache.o

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-06-06 Thread Mark Thomas
On 06/06/2012 00:58, Mark Thomas wrote: > On 05/06/2012 22:37, build...@apache.org wrote: >> The Buildbot has detected a new failure on builder tomcat-trunk while >> building ASF Buildbot. >> Full details are available at: >> http://ci.apache.org/builders/tomcat-trunk

Re: svn commit: r1348425 - /tomcat/trunk/RUNNING.txt

2012-06-09 Thread Mark Thomas
kkoli...@apache.org wrote: >Author: kkolinko >Date: Sat Jun 9 15:15:54 2012 >New Revision: 1348425 > >URL: http://svn.apache.org/viewvc?rev=1348425&view=rev >-(1) Download and Install the Java SE Runtime Environment (JRE) >+(1) Download and Install Java SE Runtime Environment (JRE) That chang

Re: svn commit: r1348425 - /tomcat/trunk/RUNNING.txt

2012-06-09 Thread Mark Thomas
On 09/06/2012 20:57, Konstantin Kolinko wrote: > 2012/6/9 Mark Thomas : >> >> >> kkoli...@apache.org wrote: >> >>> Author: kkolinko >>> Date: Sat Jun 9 15:15:54 2012 >>> New Revision: 1348425 >>> >>> URL: http://svn.apache.o

Need a native connector release

2012-06-09 Thread Mark Thomas
Tomcat 7.0.28 is getting close to being ready to roll the release. However, a new native release is required since the new infinite time out feature required by WebSocket needs native 1.2.24. Mladen, what are the chances of you starting a native 1.2.24 release in the next few days? Mark

Re: Need a native connector release

2012-06-10 Thread Mark Thomas
On 10/06/2012 16:09, Mladen Turk wrote: > On 06/09/2012 10:34 PM, Mark Thomas wrote: >> >> Mladen, what are the chances of you starting a native 1.2.24 release in >> the next few days? >> > > Sure. Need to double check few things, but Monday or Tuesday we sho

Re: svn commit: r1348762 - in /tomcat/trunk: java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread Mark Thomas
On 11/06/2012 10:33, Konstantin Kolinko wrote: > 2012/6/11 : >> Author: markt >> Date: Mon Jun 11 09:24:53 2012 >> New Revision: 1348762 >> >> URL: http://svn.apache.org/viewvc?rev=1348762&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 >> Stepping through the code

Re: svn commit: r1348772 - /tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

2012-06-11 Thread Mark Thomas
On 11/06/2012 10:42, Konstantin Kolinko wrote: > 2012/6/11 : >> Author: markt >> Date: Mon Jun 11 09:37:00 2012 >> New Revision: 1348772 >> >> URL: http://svn.apache.org/viewvc?rev=1348772&view=rev >> Log: >> Throwable.getMessage() might be null >> >> Modified: >>tomcat/trunk/java/org/apache/c

Re: svn commit: r1348780 - in /tomcat/native/branches/1.1.x/native/srclib: VERSIONS openssl/openssl-msvcrt.patch

2012-06-11 Thread Mark Thomas
On 11/06/2012 10:56, mt...@apache.org wrote: > Author: mturk > Date: Mon Jun 11 09:56:31 2012 > New Revision: 1348780 > > URL: http://svn.apache.org/viewvc?rev=1348780&view=rev > Log: > Update openssl version and patch > > Modified: > tomcat/native/branches/1.1.x/native/srclib/VERSIONS >

Re: Need a native connector release

2012-06-11 Thread Mark Thomas
On 11/06/2012 11:24, Mladen Turk wrote: > On 06/10/2012 05:11 PM, Mark Thomas wrote: >> On 10/06/2012 16:09, Mladen Turk wrote: >>> Sure. Need to double check few things, but Monday or Tuesday we should >>> have RC. >> >> Excellent. Thanks. >&

Re: [VOTE] Release Apache Tomcat Native 1.1.24

2012-06-11 Thread Mark Thomas
On 11/06/2012 13:54, Mladen Turk wrote: > Version 1.1.24 is feature-add release containing additional > API to set per-socket timeouts inside Poller. > The proposed release artefacts can be found at [1], > and the build was done using tag [2]. > > The VOTE will remain open for at least 48 hours. >

Re: "WARNING: Incorrect connection count" when running testsuite for APR/native 1.1.24

2012-06-13 Thread Mark Thomas
On 13/06/2012 09:24, Rainer Jung wrote: > On 13.06.2012 05:21, Konstantin Kolinko wrote: >> Hi! >> >> I run the testsuite for Tomcat trunk with APR connector with release >> candidate for Tomcat Native 1.1.24, on WinXP 32-bit. >> >> The testsuite passes successfully, but looking closer into log fil

Tagging 7.0.28

2012-06-13 Thread Mark Thomas
I'm running the TCKs and unit tests on 7.0.x/trunk now. Assuming everything passes and no-one raises a show-stopping bug between now and when they finish, I'll tag current trunk as 7.0.28 - probably some time tomorrow morning UTC. Mark -

Re: "WARNING: Incorrect connection count" when running testsuite for APR/native 1.1.24

2012-06-13 Thread Mark Thomas
On 13/06/2012 17:08, Mark Thomas wrote: > On 13/06/2012 09:24, Rainer Jung wrote: >> On 13.06.2012 05:21, Konstantin Kolinko wrote: >>> Hi! >>> >>> I run the testsuite for Tomcat trunk with APR connector with release >>> candidate for Tomcat Native 1

Re: Tagging 7.0.28

2012-06-13 Thread Mark Thomas
On 13/06/2012 19:39, Mark Thomas wrote: > I'm running the TCKs and unit tests on 7.0.x/trunk now. Assuming > everything passes and no-one raises a show-stopping bug between now and > when they finish, I'll tag current trunk as 7.0.28 - probably some time > tomorrow morning

Re: svn commit: r1349984 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2012-06-13 Thread Mark Thomas
On 13/06/2012 22:14, Filip Hanik (mailing lists) wrote: > > >> } else { >> -countDownConnection(); >> // Close socket and pool right away >> destroySocket(socket); >> } >> > > [Fil

Re: svn commit: r1349984 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2012-06-14 Thread Mark Thomas
On 13/06/2012 23:22, Konstantin Kolinko wrote: > 2012/6/13 : >> Author: markt >> Date: Wed Jun 13 18:29:07 2012 >> New Revision: 1349984 >> >> URL: http://svn.apache.org/viewvc?rev=1349984&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53173 >> Remove some duplicate cal

Re: svn commit: r1350235 - /tomcat/tc5.5.x/trunk/STATUS.txt

2012-06-14 Thread Mark Thomas
On 14/06/2012 14:41, Mladen Turk wrote: > On 06/14/2012 03:37 PM, rj...@apache.org wrote: >> Author: rjung >> Date: Thu Jun 14 13:37:43 2012 >> New Revision: 1350235 >> >> URL: http://svn.apache.org/viewvc?rev=1350235&view=rev >> Log: >> Revoke proposal. >> > > I actually think we should stop ship

Re: Problem running "svn up" on Tomcat site

2012-06-14 Thread Mark Thomas
On 14/06/2012 15:10, Konstantin Kolinko wrote: > Hi! > > I just had a problem with running "svn up" on tomcat.a.o. > I found a solution, but I wonder whether others will experience the same > issue. They will. Well, they would have done. I've made wc.db group writeable (which it clearly has to

Re: Tagging 7.0.28

2012-06-14 Thread Mark Thomas
On 13/06/2012 21:31, Mark Thomas wrote: > On 13/06/2012 19:39, Mark Thomas wrote: >> I'm running the TCKs and unit tests on 7.0.x/trunk now. Assuming >> everything passes and no-one raises a show-stopping bug between now and >> when they finish, I'll tag current

Re: [OT] Subversion and recording bugzilla bug ids

2012-06-14 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/06/2012 23:12, Christopher Schultz wrote: > All, > > Since I know we've got some infra folks on this list but I'm not on > the infra mailing list, I hope nobody minds if I ask here: > > When I do an svn commit to the ASF repository, one of the

Re: Implement support for setTimeout() for Comet + APR?

2012-06-14 Thread Mark Thomas
On 15/06/2012 01:41, Konstantin Kolinko wrote: > Hi! > > There is one known limitation in Comet API: > > The event.setTimeout() method works for NIO connector only > and for APR it throws UnsupportedOperationException > > Now that with 7.0.28 per-socket timeouts are supported in APR > connector,

[VOTE] Release Apache Tomcat 7.0.28

2012-06-15 Thread Mark Thomas
The proposed Apache Tomcat 7.0.28 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.28/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-243/ The svn tag is: http://svn.apache.org/r

Re: [VOTE] Release Apache Tomcat 7.0.28

2012-06-15 Thread Mark Thomas
On 15/06/2012 10:14, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.28 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.28/ > The Maven staging repo is: > https://repository.apache.org/co

[Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-15 Thread Mark Thomas
All, Servlet 3.1 looks like it is going to introduce 'overlays' or something similar along the lines of the enhancement request [1]. Tomcat already has aliases, VirtualDirContext and resource JAR support - each implemented slightly differently. Things are already rather messy and will get worse i

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-16 Thread Mark Thomas
On 16/06/2012 16:28, Konstantin Kolinko wrote: > 2012/6/15 Mark Thomas : >> All, >> >> Servlet 3.1 looks like it is going to introduce 'overlays' or something >> similar along the lines of the enhancement request [1]. >> >> Tomcat already has al

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-16 Thread Mark Thomas
Konstantin Kolinko wrote: >2012/6/16 Mark Thomas : >> >>> URLs are needed per Servlet API, so they cannot be removed. Does our >>> "jndi" schema need DirContext as underlying implementation? >> >> Our jndi scheme was used to provide access to

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-16 Thread Mark Thomas
On 16/06/2012 19:18, Mark Thomas wrote: > > > Konstantin Kolinko wrote: > >> 2012/6/16 Mark Thomas : >>> >>>> URLs are needed per Servlet API, so they cannot be removed. >>>> Does our "jndi" schema need DirContext as underlying >

Re: [VOTE] Release Apache Tomcat 7.0.28

2012-06-17 Thread Mark Thomas
On 16/06/2012 10:04, Rainer Jung wrote: > Most noteable observation: File conf/web.xml now is open 9 times in > parallel (9 file descriptors), was 4 times in 7.0.27. I see 9 open file handle in Windows but this drops to zero once I force a full GC. On this basis, I'm not concerned but it would be

Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2012-06-18 Thread Mark Thomas
On 18/06/2012 09:27, Konstantin Kolinko wrote: > I am OK to disable the validation for this file, but I I think it > would be better to unwrap the first line of those values. It will be a > bit more ugly but it will avoid problems if there is someone whose > editor is configured to auto-trim the li

[RESULT][VOTE] Release Apache Tomcat 7.0.28

2012-06-18 Thread Mark Thomas
The result of the vote was as follows: Binding +1: markt, mturk, rjung, olamy, kkolinko, pero No other votes were cast. The vote therefore passes. I'll proceed as follows: - move release to dist - wait for mirrors to sync - update website - wait for website changes to sync - announce the releas

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.28

2012-06-18 Thread Mark Thomas
On 18/06/2012 14:16, Olivier Lamy wrote: > 2012/6/18 Mark Thomas : >> The result of the vote was as follows: >> >> Binding +1: >> markt, mturk, rjung, olamy, kkolinko, pero >> >> No other votes were cast. >> >> The vote therefore passes. >&

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Mark Thomas
On 19/06/2012 06:16, Michael Roberts wrote: > Hi, I have been playing with the web sockets support in 7.0.27. I have > some comments and, as requested in the readme, am sending them to the dev > list. Thanks. Much appreciated. > Caveat: it's been a while since .27, so perhaps some of these issue

Re: svn commit: r1351637 - in /tomcat/site/trunk/xdocs: doap_Tomcat.rdf download-70.xml index.xml migration-7.xml oldnews.xml whichversion.xml

2012-06-19 Thread Mark Thomas
On 19/06/2012 11:37, Konstantin Kolinko wrote: > 2012/6/19 : >> Author: markt >> Date: Tue Jun 19 10:09:52 2012 >> New Revision: 1351637 >> >> URL: http://svn.apache.org/viewvc?rev=1351637&view=rev >> Log: >> Prep main site for 7.0.28 release >> >> Modified: >>tomcat/site/trunk/xdocs/doap_Tomc

[ANN] Apache Tomcat 7.0.28 released

2012-06-19 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.28. Apache Tomcat is an open source software implementation of the Java Servlet and JavaServer Pages technologies. This release is includes may improvements as well as a number of bug fixes compared to version 7.0.27

Re: Plans for 6.0.36?

2012-06-19 Thread Mark Thomas
On 19/06/2012 14:03, Konstantin Kolinko wrote: > Hi! > > Previous version of Tomcat 6 was released in December 2011. > There are a number of changes already committed and a number of > nominations in the STATUS file. > > I think it is about time to start preparing for the next Tomcat 6.0 release.

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Mark Thomas
On 19/06/2012 10:20, Mark Thomas wrote: > On 19/06/2012 06:16, Michael Roberts wrote: >> Hi, I have been playing with the web sockets support in 7.0.27. I have >> some comments and, as requested in the readme, am sending them to the dev >> list. > > Thanks. Much appr

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Mark Thomas
On 19/06/2012 18:02, Michael Roberts wrote: >> >> 3) As mentioned, the chat example maintains a list of connections. Connections (MessageInbound instances) are added to this list when connections are established. However, they are never removed when the connection is closed, so

Testing Tomcat 6 Maven deploy

2012-06-21 Thread Mark Thomas
All, Just in case you happen to see a 6.0.36 release staged on Nexus... I am migrating the Maven deploy scripts changes in Tomcat 7 to Tomcat 6. As part of this, I'll be doing a few deploys to Nexus to test things but I'll be dropping them rather than releasing them to Maven central. Cheers, Ma

Re: Testing Tomcat 6 Maven deploy

2012-06-21 Thread Mark Thomas
On 21/06/2012 10:31, Mark Thomas wrote: > All, > > Just in case you happen to see a 6.0.36 release staged on Nexus... > > I am migrating the Maven deploy scripts changes in Tomcat 7 to Tomcat 6. > As part of this, I'll be doing a few deploys to Nexus to test things but

Re: Testing Tomcat 6 Maven deploy

2012-06-21 Thread Mark Thomas
On 21/06/2012 10:57, Mark Thomas wrote: > On 21/06/2012 10:31, Mark Thomas wrote: >> All, >> >> Just in case you happen to see a 6.0.36 release staged on Nexus... >> >> I am migrating the Maven deploy scripts changes in Tomcat 7 to Tomcat 6. >> As part of thi

Re: Testing Tomcat 6 Maven deploy

2012-06-21 Thread Mark Thomas
On 21/06/2012 11:25, Konstantin Kolinko wrote: > 2012/6/21 Mark Thomas : >> On 21/06/2012 10:57, Mark Thomas wrote: >>> On 21/06/2012 10:31, Mark Thomas wrote: >>>> All, >>>> >>>> Just in case you happen to see a 6.0.36 release staged on Nexu

Re: Testing Tomcat 6 Maven deploy

2012-06-21 Thread Mark Thomas
On 21/06/2012 11:30, Mark Thomas wrote: > On 21/06/2012 11:25, Konstantin Kolinko wrote: >> 2012/6/21 Mark Thomas : >>> On 21/06/2012 10:57, Mark Thomas wrote: >>>> On 21/06/2012 10:31, Mark Thomas wrote: >>>>> All, >>>>> >>&

Re: svn commit: r1352454 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-06-24 Thread Mark Thomas
On 23/06/2012 18:02, Konstantin Kolinko wrote: > 2012/6/21 : >> Author: markt >> Date: Thu Jun 21 08:42:27 2012 >> New Revision: 1352454 >> >> URL: http://svn.apache.org/viewvc?rev=1352454&view=rev >> Log: >> Vote >> >> Modified: >>tomcat/tc6.0.x/trunk/STATUS.txt >> > >> @@ -156,14 +156,17 @@

Re: [OT] Moving entire directory structures in svn

2012-06-25 Thread Mark Thomas
On 25/06/2012 17:42, Christopher Schultz wrote: > $ mkdir src/newpackage > $ svn add src/newpackage Skip the above 2 lines > $ svn mv src/oldpackage src/newpackage $ svn log > src/newpackage/some/source/file/in/There.java You are all set. Mark -

Re: writing tomcat filters

2012-06-26 Thread Mark Thomas
On 25/06/2012 23:04, Varrun Ramani wrote: > Hi > > I am in the process developing a web application firewall(WAF) for > tomcat similar to what mod security does, and am planning to use the > filter API already present in tomcat to intercept requests and do the > filtering. While going through the

Re: svn commit: r1353709 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/ssl-howto.xml

2012-06-26 Thread Mark Thomas
On 26/06/2012 17:56, Konstantin Kolinko wrote: > 2012/6/25 : >> - The example above will throw an error if you have the APR and the Tomcat >> Native libraries in your path, >> - as Tomcat will try to use the APR connector. The APR connector uses >> different attributes for >> - SSL keys and

Timing for 7.0.29

2012-06-26 Thread Mark Thomas
I'm sure circumstances will conspire against me but I am currently planning to start the 7.0.29 release process early next week. That aligns with my general aim of getting a release out at the start of each month and there are some regressions in 7.0.28 that I'd rather fix sooner than later. Mark

Re: svn commit: r1354200 - in /tomcat/trunk/java: javax/servlet/jsp/PageContext.java org/apache/jasper/runtime/JspContextWrapper.java org/apache/jasper/runtime/JspFactoryImpl.java org/apache/jasper/ru

2012-06-26 Thread Mark Thomas
On 26/06/2012 21:19, Konstantin Kolinko wrote: > 2012/6/27 : >> Author: markt >> Date: Tue Jun 26 20:06:21 2012 >> New Revision: 1354200 >> >> URL: http://svn.apache.org/viewvc?rev=1354200&view=rev >> Log: >> Simplify. >> >> Modified: >>tomcat/trunk/java/javax/servlet/jsp/PageContext.java > >

Re: Timing for 7.0.29

2012-06-26 Thread Mark Thomas
n't investigated the validity of the last two but they look reasonable at first glance. Mark > > On 6/26/2012 3:11 PM, Mark Thomas wrote: >> I'm sure circumstances will conspire against me but I am currently >> planning to start the 7.0.29 release process early next

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-06-27 Thread Mark Thomas
On 27/06/2012 05:48, Konstantin Kolinko wrote: > 2012/6/27 : >> The Buildbot has detected a new failure on builder tomcat-trunk while >> building ASF Buildbot. >> Full details are available at: >> http://ci.apache.org/builders/tomcat-trunk/builds/3129 >> >> Buildbot URL: http://ci.apache.org/ >>

Re: Shouldn't Servlet 3.0 file upload delete temporary files after request completes

2012-06-27 Thread Mark Thomas
On 27/06/2012 17:19, Konstantin Kolinko wrote: > Hi! > > I was experimenting with Servlet 3.0 file upload. What seems odd is > that after request is processed the uploaded files are still present > in the work directory of the web application. > > The only way to reliably delete those files is wh

Re: Starting on 3.1 implementation

2012-06-27 Thread Mark Thomas
On 27/06/2012 20:16, Filip Hanik (mailing lists) wrote: > As some of you noticed, I added in the stubs for Servlet 3.1 yesterday. > > I'm planning on starting on 3.1 features, mainly the non blocking > read/writes. > In Tomcat, we already have an implementation of this in the sandbox > http://svn

Re: Starting on 3.1 implementation

2012-06-27 Thread Mark Thomas
On 27/06/2012 20:49, Filip Hanik (mailing lists) wrote: >> My current focus on Tomcat 8 is re-factoring the resources to remove all >> the JNDI stuff. After that, I'll probably look at the HTTP upgrade bit. > > [Filip Hanik] > Interesting, what's up with JNDI, prolly something I missed from an e

<    3   4   5   6   7   8   9   10   11   12   >