On 12/05/2012 23:14, Konstantin Kolinko wrote:
> 2012/5/13 <ma...@apache.org>:
>> Author: markt
>> Date: Sat May 12 20:51:24 2012
>> New Revision: 1337643
>> + if (inner instanceof RequestFacade) {
>> + ((RequestFacade) req).doUpgrade(inbound);
>
> inner.doUpgrade(), not req.
Doh.
>
>> + } else {
>> + resp.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
>
> It would be hard to find what is the cause of an issue if it is just a
> generic error 500.
>
> Maybe just throw a ServletException and let the ErrorReportValve to
> handle the rest?
> Well, just blatantly casting to RequestFacade will do effectively the same.
I'll add a message.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
