On 19/06/2012 18:02, Michael Roberts wrote:
>>
>>
>>>> 3) As mentioned, the chat example maintains a list of connections.
>>>> Connections (MessageInbound instances) are added to this list when
>>>> connections are established.  However, they are never removed when the
>>>> connection is closed, so the list grows.  The broadcast method silently
>>>> ignores the IOException presumably caused by writing to these
>> connections.
>>>
>>> Opps. We'll get that fixed.
>>
>> I don't see this in the code or when I test it. Could you explain the
>> circumstances in which this happens please?
> 
> 
> Wups, I am wrong on this.  I was looking at a modified example of Chat, and
> when I went back and looked at the original version, the call to remove was
> there in the onClose method.  It is still silently ignoring the exception
> caught in broadcast() however.

Indeed. Any exception there is probably enough to drop the connection.
I'll make that change unless someone objects.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to