Re: SPDY support

2012-02-14 Thread Mark Thomas
On 14/02/2012 20:47, Costin Manolache wrote: > On Tue, Feb 14, 2012 at 9:36 AM, Mark Thomas wrote: > >> On 14/02/2012 08:29, Costin Manolache wrote: >>> Ok, took a bit to get the Apr polling to work and add some minimal tests. >>> >>> Please take anoth

Re: SPDY support

2012-02-14 Thread Mark Thomas
On 14/02/2012 21:03, Costin Manolache wrote: > BTW - one thing that may simplify the existing code is replacing > SocketWrapper with a simple SocketWrapper, and having JIO and APR > define their own SocketWrapper - like NIO does. Worth adding to the 8.0.x TODO list. > It would also save a lot of

Re: SPDY support

2012-02-15 Thread Mark Thomas
r > compression, which is another requirement ). Thanks. The fog is starting to lift now. >>> On Tue, Feb 14, 2012 at 9:36 AM, Mark Thomas wrote: >>>> > I hope the new interface does - it's just a small extension to Handler ( > the main method is > present in

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 03:53, Costin Manolache wrote: > Uploaded another take. > > This time I'm just adding > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.java > > which is just a Handler - like AjpConnectionHandler, > Http11ConnectionHandler. > > I believe t

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 16:11, Costin Manolache wrote: > After I submit, I'll give a try to changing SocketWrapper (non-generic, > add read/write), in the git. If you don't like it - easy to drop the branch, > but I think it'll simplify the old connectors enough to compensate for the > extra complexity I'm a

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 19:58, Costin Manolache wrote: > In spdy I'm using a SpdyFrame class ( spdy allow data frames to be > fragmented any > way you want by intermediary - so even if I receive a huge frame, I can > split it > in buffer-sized frames - I believe you can do the same for websocket, as > long

Re: AccessLogValve enhancement

2012-02-15 Thread Mark Thomas
On 15/02/2012 21:23, Mark Claassen wrote: > We would like to use the flexibility of the standard logging mechanism for > the AccessLogValue. I could find no way to do this. Looking at the > AccessLogValve code in Tomcat 7, it seems it would really would not be hard > to add. I added org.apache.j

Re: SPDY support

2012-02-16 Thread Mark Thomas
On 16/02/2012 01:44, Costin Manolache wrote: > That doesn't mean the application must receive the entire message as one > byte[] > or as a Stream. > You can have a very large fragment but still read it in smaller buffers and > notify > the user of message start and for each fragment ( I guess like

Maven meta-data still incomplete for Tomcat 6

2012-02-17 Thread Mark Thomas
Jean-Frederic, Post [1] the Tomcat 6 Maven metadata is still incomplete. I thought the point of going through all that upheaval was to resolve [2]. How come things are still broken and what is the plan to fix [2]? If anyone knows how to poke Nexus to include all versions in the metadata rather th

[VOTE] Release Apache Tomcat 7.0.26

2012-02-17 Thread Mark Thomas
The proposed Apache Tomcat 7.0.26 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.26/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-020/ The svn tag is: http://svn.apache.org/r

Re: WebSocket progress report

2012-02-17 Thread Mark Thomas
On 16/02/2012 04:01, Petr Praus wrote: > Hello, attached is our patch. It applies cleanly on top of current trunk > rev. 1244719. It has rudimentary support for fragmentation (callback > after last frame), supports close messages and ping/pong. Sorry for not > sending a patchset but I thought it wo

Re: svn commit: r1245804 - /tomcat/trunk/java/org/apache/catalina/websocket/WsInputStream.java

2012-02-17 Thread Mark Thomas
On 17/02/2012 23:18, ma...@apache.org wrote: > Author: markt > Date: Fri Feb 17 23:18:36 2012 > New Revision: 1245804 > > URL: http://svn.apache.org/viewvc?rev=1245804&view=rev > Log: > Implement fragmentation support. Unfragmented messages still work > correctly. > Still trying to figure out how

Re: [VOTE] Release Apache Tomcat 7.0.26

2012-02-18 Thread Mark Thomas
On 17/02/2012 20:00, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.26 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.26/ > The Maven staging repo is: > https://repository.apache.org/co

Re: AccessLogValve enhancement

2012-02-19 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19/02/2012 17:20, Christopher Schultz wrote: > Mark, > > On 2/15/12 4:33 PM, Mark Thomas wrote: >> I also be +1 to considering making this the sole way >> AccessLogValve logging may be output. > > The only possible rea

Re: WebSocket progress report

2012-02-20 Thread Mark Thomas
ilures we'd get with the current code :) What we can do is to provide the necessary servlet that AutoBahn needs to talk to as part of the examples web app. That way, anyone can run the test suite with minimal effort. > On Fri, Feb 17, 2012 at 14:50, Mark Thomas wrote: > >> On

Re: WebSocket progress report

2012-02-20 Thread Mark Thomas
On 20/02/2012 10:04, Mark Thomas wrote: > On 20/02/2012 02:55, Petr Praus wrote: >> but I wanted to ask - have you considered using Autobahn for >> testing? It's rather extensive opensource websocket testing suite. > > I haven't. I just took a quick look. Looks lik

Re: WebSocket progress report

2012-02-20 Thread Mark Thomas
I have used. You'll also get credit in the changelog along with the other folks that have contributed code to the WebSocket impl. Based on progress today, things should move along pretty quickly. Next step is to get ping/pong working. Mark > > Petr > > On Mon, Feb 20, 2012

Re: WebSocket progress report

2012-02-20 Thread Mark Thomas
On 20/02/2012 22:19, Mark Thomas wrote: > Based on progress today, things should move along pretty quickly. > Next step is to get ping/pong working. Yep. Progress has been pretty quick. Ping/pong tests (section 2) now all pass as do sections 3 (reserved bits) and 4 (opcodes). There are

[RESULT] [VOTE] Release Apache Tomcat 7.0.26

2012-02-21 Thread Mark Thomas
Binding votes: +1: mturk, markt, hgomez, yoavs, olamy, rjung Non-binding votes: +1: kfujino The vote therefore passes. I'll move the bits shortly and announce once the mirrors have sync'd. Mark - To unsubscribe, e-mail: dev-un

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-02-21 Thread Mark Thomas
On 21/02/2012 14:49, Konstantin Kolinko wrote: > Note that Buildbot fails as well. > > The error is in TestWebSocket, > [[[ > Testcase: testSimple took 3.875 sec > FAILED > null > junit.framework.AssertionFailedError > at > org.apache.catalina.websocket.TestWebSocket.readMessage(TestW

Re: svn commit: r1291507 - in /tomcat/trunk/java/org/apache/catalina/websocket: StreamInbound.java WsInputStream.java WsOutbound.java

2012-02-21 Thread Mark Thomas
On 21/02/2012 16:31, Konstantin Kolinko wrote: > Regarding StreamInbound#doClose(), doPing(), doPong() Thanks for the review. > > 1. in doClose(): > status = status + is.read(); > There is no check whether is.read() is not -1 above. Added. > 2.All 3 methods have such loops: > while

[ANN] Apache Tomcat 7.0.26 released

2012-02-22 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.26 This release is primarily a bug fix release and includes numerous bug fixes compared to version 7.0.25. The notable bug fixes include: * Improved @HandlesTypes processing which no longer loads all classes on web

Re: SPDY support

2012-02-22 Thread Mark Thomas
on may be required. > Any concerns with it ? Depends on why it is required. Mark > > Costin > > On Thu, Feb 16, 2012 at 2:11 PM, Mark Thomas wrote: > >> On 16/02/2012 01:44, Costin Manolache wrote: >>> That doesn't mean the application must receive the e

Re: SPDY support

2012-02-22 Thread Mark Thomas
On 22/02/2012 18:41, Costin Manolache wrote: > On Wed, Feb 22, 2012 at 10:27 AM, Konstantin Kolinko > wrote: > >> 2012/2/22 Costin Manolache : >>> On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas wrote: >>> >>>> On 22/02/2012 16:51, Costin Manolache wrot

Re: Tomcat with mod_jk becomes irresponsive after working for awhile

2012-02-22 Thread Mark Thomas
On 22/02/2012 19:02, Ofer Israeli wrote: > All, This is the dev list, not the users list. This question does not belong on this list. Further, I see you already posted to the users list. Please do not cross post. Mark > > I have a deployment on Windows 2003 Server using Apache 2.2.16, > Tomcat

Re: WebSocket progress report

2012-02-23 Thread Mark Thomas
On 23/02/2012 01:32, Petr Praus wrote: > On Mon, Feb 20, 2012 at 16:19, Mark Thomas wrote: >> Haven't looked too hard at those yet. Assuming Java can tell the UTF-8 >> is invalid then handling that should be easy. >> > Yes, except that the java CharsetDecoder di

WebSocket TODOs

2012-02-23 Thread Mark Thomas
All, The bulk of the WebSocket implementation is complete. There are, however, still quite a few TODOs. 1. Autobahn failure of test 7.5.1 (close handling) 2. Autobahn UTF-8 failures. Invalid UTF-8 is not being detected by the Reader. Needs further investigating. 3. Autobhan performance failures

Re: svn commit: r1292891 - /tomcat/trunk/bin/daemon.sh

2012-02-23 Thread Mark Thomas
On 23/02/2012 19:07, sebb wrote: > On 23 February 2012 19:00, Konstantin Kolinko wrote: >> 2012/2/23 : >>> - case "$o" in >>> + case "$o=1" in >> >> What the above line is about? > > I wondered the same myself; > it so happens that the "=" key is next to the "Backspace" key, so I > suspect th

Re: svn commit: r1292891 - /tomcat/trunk/bin/daemon.sh

2012-02-23 Thread Mark Thomas
On 23/02/2012 19:33, Mladen Turk wrote: > On 02/23/2012 08:00 PM, Konstantin Kolinko wrote: >> 2012/2/23: >> Maybe: >> while [ -n "$1" ] >> (though both variants should work work) >> > > Some solaris shells misbehave on -n. > >>> do >>> - case "$o" in >>> + case "$o=1" in >> >> What the abo

Re: svn commit: r1292995 - /tomcat/trunk/java/org/apache/catalina/websocket/WsOutbound.java

2012-02-23 Thread Mark Thomas
On 23/02/2012 23:00, Konstantin Kolinko wrote: > 2012/2/24 : >> Author: markt >> Date: Thu Feb 23 22:28:32 2012 >> New Revision: 1292995 >> >> URL: http://svn.apache.org/viewvc?rev=1292995&view=rev >> Log: >> Review comments on r1292776 from kkolinko >> >> Modified: >>tomcat/trunk/java/org/apa

Re: WebSocket TODOs

2012-02-23 Thread Mark Thomas
On 23/02/2012 12:42, Mark Thomas wrote: > All, > > The bulk of the WebSocket implementation is complete. There are, > however, still quite a few TODOs. > > 1. Autobahn failure of test 7.5.1 (close handling) Fixed. > 2. Autobahn UTF-8 failures. Invalid UTF-8 is not being det

Re: DO NOT REPLY [Bug 52757] China Shoes On www.chinajordansshoes.com

2012-02-24 Thread Mark Thomas
On 24/02/2012 02:23, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=52757 > > Chuck Caldarale changed: > >What|Removed |Added > > Status|

Re: WebSocket TODOs

2012-02-24 Thread Mark Thomas
On 24/02/2012 06:15, Jonathan Drake wrote: > On 2012/02/23 17:24, "Mark Thomas" wrote: > >> On 23/02/2012 12:42, Mark Thomas wrote: >>> All, >>> >>> The bulk of the WebSocket implementation is complete. There are, >>> however, still qu

Re: WebSocket TODOs

2012-02-25 Thread Mark Thomas
On 25/02/2012 13:32, ma...@apache.org wrote: > Mark Thomas wrote: >>> 5. Threading. Fix the TODOs associated around multiple threads >>> trying >> to >>> send messages at the same time. > > Still to do. > >>> 6. Profiling. Take a loo

Re: WebSocket TODOs

2012-02-26 Thread Mark Thomas
On 26/02/2012 00:43, Mark Thomas wrote: > On 25/02/2012 13:32, ma...@apache.org wrote: >> Mark Thomas wrote: > >>>> 5. Threading. Fix the TODOs associated around multiple threads >>>> trying >>> to >>>> send messages at the same time.

WebSocket status

2012-02-28 Thread Mark Thomas
WebSocket is working with good performance and passing all Autobahn tests on BIO, NIO and APR. Currently, all three connectors using blocking IO throughout so there is a one to one mapping between threads and connections. Therefore, scalability is not what it could be for NIO and APR. The remaini

Re: WebSocket status

2012-02-28 Thread Mark Thomas
On 28/02/2012 16:58, Filip Hanik - Dev Lists wrote: > On 2/28/2012 4:08 AM, Mark Thomas wrote: >> WebSocket is working with good performance and passing all Autobahn >> tests on BIO, NIO and APR. >> >> Currently, all three connectors using blocking IO throughout so there

Re: WebSocket status

2012-02-28 Thread Mark Thomas
On 28/02/2012 18:53, Filip Hanik - Dev Lists wrote: > On 2/28/2012 11:39 AM, Mark Thomas wrote: >> You may also be able to help with some problems I am having getting >> non-blocking behaviour between messages with NIO. I'm not 100% clear >> what is happening yet, but I

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 28/02/2012 21:29, Mark Thomas wrote: > On 28/02/2012 18:53, Filip Hanik - Dev Lists wrote: >> On 2/28/2012 11:39 AM, Mark Thomas wrote: > >>> You may also be able to help with some problems I am having getting >>> non-blocking behaviour between messages with NIO.

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 11:31, Mark Thomas wrote: > On 28/02/2012 21:29, Mark Thomas wrote: >> On 28/02/2012 18:53, Filip Hanik - Dev Lists wrote: >>> On 2/28/2012 11:39 AM, Mark Thomas wrote: >> >>>> You may also be able to help with some problems I am having getting

Re: svn commit: r1295286 - in /tomcat/trunk/java/org/apache/catalina/websocket: LocalStrings.properties WsFrame.java

2012-03-01 Thread Mark Thomas
On 01/03/2012 03:56, Konstantin Kolinko wrote: > 2012/3/1 : >> Author: markt >> Date: Wed Feb 29 21:24:59 2012 >> New Revision: 1295286 >> Modified: tomcat/trunk/java/org/apache/catalina/websocket/WsFrame.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/websoc

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 15:03, Filip Hanik - Dev Lists wrote: > >> I have a draft patch [1] that seems to fix this. A similar change would >> be required for the Comet part of Poller.processKey() >> >> Thoughts and/or comments? Not knowing the NIO code very well, there >> might be a better way to achieve th

Re: WebSocket status

2012-03-01 Thread Mark Thomas
axSize = 2097152; private int charBufferMaxSize = 2097152; I normally multiple those by 16. The buffers need to be 16M plus a bit for the headers so I allow a large margin ;) Mark > > Filip > > On 3/1/2012 9:42 AM, Mark Thomas wrote: >> On 01/03/2012 15:03, Filip Hanik - Dev Li

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 18:01, Filip Hanik - Dev Lists wrote: > Alright, now that I'm all squared away with Autobahn and test cases > running. Is there a specific unit test you have to produce this behavior? > That would help me for digging through it. Assuming you are running trunk, then what you'll curren

Re: WebSocket status

2012-03-01 Thread Mark Thomas
o it can just be uncommented to run the Autobahn tests. I'll try and do that shortly. Mark > > Filip > > On 3/1/2012 10:13 AM, Filip Hanik - Dev Lists wrote: >> Mark, what buffer size are you referring to increase for the web >> socket tests to all pass? >>

Re: WebSocket status

2012-03-01 Thread Mark Thomas
On 01/03/2012 18:22, Costin Manolache wrote: > On Thu, Mar 1, 2012 at 9:54 AM, Mark Thomas wrote: > >> On 01/03/2012 17:13, Filip Hanik - Dev Lists wrote: >>> Mark, what buffer size are you referring to increase for the web socket >>> tests to all pass? >>

Re: svn commit: r1295724 - in /tomcat/trunk/webapps/examples/WEB-INF: classes/websocket/EchoMessage.java web.xml

2012-03-01 Thread Mark Thomas
On 01/03/2012 18:27, fha...@apache.org wrote: > Author: fhanik > Date: Thu Mar 1 18:27:56 2012 > New Revision: 1295724 > > URL: http://svn.apache.org/viewvc?rev=1295724&view=rev > Log: > Allow the examples to configure the buffer on the fly Guess you beat me to it. The config needs to be comment

Re: svn commit: r1295978 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11NioProtocol.java upgrade/UpgradeNioProcessor.java

2012-03-02 Thread Mark Thomas
On 01/03/2012 23:47, Filip Hanik - Dev Lists wrote: > Thanks for that John, I'll fix that too. That probably explains the Comet failures we have been seeing in the unit tests. Excellent. Mark > > Filip > > On 3/1/2012 4:42 PM, Johno Crawford wrote: >> On 2/03/2012 12:05 AM, fha...@apache.org w

Re: WebSocket status

2012-03-02 Thread Mark Thomas
On 01/03/2012 22:55, Filip Hanik - Dev Lists wrote: > You can't register on a selector using another thread. Bingo. That explains it. Is that documented anywhere? I don't recall reading it but I may well have missed it. Looking at the code, it looks like HTTP would have been unaffected which is go

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-02 Thread Mark Thomas
On 02/03/2012 00:13, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-trunk/builds/2802 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for t

Re: svn commit: r1296172 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocol.java ajp/AbstractAjpProtocol.java http11/Http11AprProtocol.java http11/Http11NioProtocol.java http11/Http11Protocol

2012-03-02 Thread Mark Thomas
On 02/03/2012 13:17, Johno Crawford wrote: > Hi Mark, > > Quick question regarding web socket socket states, using the BIO > connector I have observed the socket state never transitions to > UPGRADED.. Is this the expected behaviour? Short answer: yes. Longer answer: In this case state is the st

Re: DO NOT REPLY [Bug 52815] ROOT Service

2012-03-03 Thread Mark Thomas
On 03/03/2012 13:06, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=52815 I got fed up of the spam. The user has been blocked (again) and the issue deleted. I'm sufficiently fed up that I'm going hunting in the access logs for some IP addresses. If I find a suitab

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-06 Thread Mark Thomas
On 06/03/2012 21:27, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-trunk/builds/2816 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for t

Re: svn commit: r1297914 - in /tomcat: tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/filters/ trunk/webapps/examples/WEB-INF/classes/websocket/snake/ trunk/webapps/examples/websocket/

2012-03-07 Thread Mark Thomas
On 07/03/2012 11:01, Konstantin Kolinko wrote: > 2012/3/7 : >> Author: markt >> Date: Wed Mar 7 09:42:27 2012 >> New Revision: 1297914 >> >> URL: http://svn.apache.org/viewvc?rev=1297914&view=rev >> Log: >> Fix line-endings >> >> Modified: >> >> tomcat/tc5.5.x/trunk/container/catalina/src/sha

Re: WebSocket status

2012-03-08 Thread Mark Thomas
On 08/03/2012 09:12, Johno Crawford wrote: > What's next / left on the TODO list Mark? Anything I can help out with? Porting the generic HTTP upgrade followed by the WebSocket code to 7.0.x. I don't think there is much for you to do there. WebSocket needs some documentation. My plan was to keep i

Re: svn commit: r1298590 - in /tomcat/trunk/java/org/apache/catalina/realm: RealmBase.java X509SubjectDnRetriever.java

2012-03-09 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/03/2012 14:33, Christopher Schultz wrote: > Mark, > > On 3/8/12 4:25 PM, ma...@apache.org wrote: >> Author: markt Date: Thu Mar 8 21:25:31 2012 New Revision: >> 1298590 >> >> URL: http://svn.apache.org/viewvc?rev=1298590&view=rev Log: Fix >> v

Re: WebSocket status

2012-03-14 Thread Mark Thomas
On 14/03/2012 10:15, Johno Crawford wrote: > On 8/03/2012 9:10 PM, Mark Thomas wrote: >> On 08/03/2012 09:12, Johno Crawford wrote: >>> What's next / left on the TODO list Mark? Anything I can help out with? >> Porting the generic HTTP upgrade followed by the WebSoc

Re: WebSockets in Tomcat 6

2012-03-15 Thread Mark Thomas
2. Performance of Comet is similar to the non Comet > implementation 3. It took me 4 hours to do this migration, so it's > definitely very easy to work with Comet once you have the bulk work > done (the WebSocket protocol impl by Mark Thomas) > > The test suite report is at &g

Re: svn commit: r1300997 - in /tomcat/trunk/webapps/docs: project.xml web-socket-howto.xml

2012-03-15 Thread Mark Thomas
On 15/03/2012 14:32, Konstantin Kolinko wrote: > 2012/3/15 : >> Author: markt >> Date: Thu Mar 15 14:21:32 2012 >> New Revision: 1300997 >> >> URL: http://svn.apache.org/viewvc?rev=1300997&view=rev >> Log: >> Document WebSocket support >> >> Added: >>tomcat/trunk/webapps/docs/web-socket-howto.

Re: svn commit: r1301284 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/ webapps/examples/WEB-INF/ webapps/examples/WEB-INF/classes/websocket/ webapps/examples/WEB-INF/classes/websocket/chat/ webapps/exa

2012-03-19 Thread Mark Thomas
On 16/03/2012 19:17, Johno Crawford wrote: > On 16/03/2012 12:57 AM, ma...@apache.org wrote: >> Author: markt >> Date: Thu Mar 15 23:57:00 2012 >> New Revision: 1301284 > > Looks like chat.html missed the changeset? It did. My bad. I forgot to svn add before the commit. Fixed now. Mark ---

Re: svn commit: r1302359 - in /tomcat/trunk: bin/ conf/ java/javax/servlet/jsp/resources/ java/javax/servlet/resources/

2012-03-19 Thread Mark Thomas
On 19/03/2012 10:25, ma...@apache.org wrote: > Author: markt > Date: Mon Mar 19 10:25:25 2012 > New Revision: 1302359 > > URL: http://svn.apache.org/viewvc?rev=1302359&view=rev > Log: > Correct some svn keyword placeholders Hmm. These changes should not have been necessary. The $KeywordName$ shou

Re: svn commit: r1302359 - in /tomcat/trunk: bin/ conf/ java/javax/servlet/jsp/resources/ java/javax/servlet/resources/

2012-03-19 Thread Mark Thomas
On 19/03/2012 10:58, Konstantin Kolinko wrote: > 2012/3/19 Mark Thomas : >> On 19/03/2012 10:25, ma...@apache.org wrote: >>> Author: markt >>> Date: Mon Mar 19 10:25:25 2012 >>> New Revision: 1302359 >>> >>> URL: http://svn.apache.org/vie

Re: svn commit: r1302359 - in /tomcat/trunk: bin/ conf/ java/javax/servlet/jsp/resources/ java/javax/servlet/resources/

2012-03-19 Thread Mark Thomas
On 19/03/2012 11:05, Konstantin Kolinko wrote: > 2012/3/19 Konstantin Kolinko : >> 2012/3/19 Mark Thomas : >>> On 19/03/2012 10:25, ma...@apache.org wrote: >>>> Author: markt >>>> Date: Mon Mar 19 10:25:25 2012 >>>> New Revision: 1302359 >&g

Re: Release JK 1.2.34

2012-03-19 Thread Mark Thomas
On 19/03/2012 14:48, Mladen Turk wrote: > Hi, > > I plan to tag 1.2.34 tomorrow cause we have one regression > and few long lasting bugs fixed. > > I'd appreciate if you can check the httpd builds from trunk > since I concentrated mainly on IIS. > > BTW, should we remove/revoke 1.2.33 or just go

Re: Release JK 1.2.34

2012-03-19 Thread Mark Thomas
On 19/03/2012 14:55, Mark Thomas wrote: > On 19/03/2012 14:48, Mladen Turk wrote: >> Hi, >> >> I plan to tag 1.2.34 tomorrow cause we have one regression >> and few long lasting bugs fixed. >> >> I'd appreciate if you can check the httpd builds from

Re: Release JK 1.2.34

2012-03-19 Thread Mark Thomas
On 19/03/2012 15:07, Mladen Turk wrote: > On 03/19/2012 03:57 PM, Mark Thomas wrote: >> On 19/03/2012 14:55, Mark Thomas wrote: >>> On 19/03/2012 14:48, Mladen Turk wrote: >>>> Hi, >>>> >>>> I plan to tag 1.2.34 tomorrow cause we ha

Re: svn commit: r1302649 - /tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

2012-03-20 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/03/2012 01:35, Christopher Schultz wrote: > Mark, > > On 3/19/12 4:46 PM, ma...@apache.org wrote: >> Author: markt Date: Mon Mar 19 20:46:15 2012 New Revision: >> 1302649 >> >> URL: http://svn.apache.org/viewvc?rev=1302649&view=rev Log: Make >>

Re: svn commit: r1242101 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/util/ExtensionValidator.java webapps/docs/changelog.xml

2012-03-20 Thread Mark Thomas
On 20/03/2012 15:41, Konstantin Kolinko wrote: > 1). Why isn't is starting with this.getParentClassLoader(); ? > > The actual shared classloader is the one used in > WebappLoader#createClassLoader(). I'd say that calling > Server.getParentClassLoader() will be closer to the truth here. > > E.g.

Re: [debug] ( javajni.c:195 ) Invalid RuntimeLib should be a warning or error?

2012-03-20 Thread Mark Thomas
On 20/03/2012 21:54, Nick Williams wrote: > Thoughts? That is a general Commons Daemon issue rather than a Tomcat specific issue and would be best discussed over on the Commons lists. Mark - To unsubscribe, e-mail: dev-unsu

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-21 Thread Mark Thomas
On 21/03/2012 20:10, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-trunk/builds/2877 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for t

Re: svn commit: r1303587 - in /tomcat/trunk/test/org/apache/catalina/tribes: ./ group/ group/interceptors/ test/channel/

2012-03-21 Thread Mark Thomas
On 21/03/2012 21:46, ma...@apache.org wrote: > Author: markt > Date: Wed Mar 21 21:46:18 2012 > New Revision: 1303587 > > URL: http://svn.apache.org/viewvc?rev=1303587&view=rev > Log: > First stab at keeping concurrent runs of the tribes unit tests from > interfering. That appears to have done t

Re: buildbot failure in ASF Buildbot on tomcat-7-trunk

2012-03-22 Thread Mark Thomas
On 22/03/2012 10:04, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-7-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-7-trunk/builds/493 > > Buildbot URL: http://ci.apache.org/ > > Buildslave fo

Re: svn commit: r1304011 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-03-22 Thread Mark Thomas
On 22/03/2012 19:47, ma...@apache.org wrote: > Author: markt > Date: Thu Mar 22 19:47:58 2012 > New Revision: 1304011 > > URL: http://svn.apache.org/viewvc?rev=1304011&view=rev > Log: > Still process events when closing to ensure that Comet connections that are > in use when the poller is stopped

Re: svn commit: r1304040 - /tomcat/tc7.0.x/trunk/

2012-03-22 Thread Mark Thomas
On 22/03/2012 20:33, ma...@apache.org wrote: > Author: markt > Date: Thu Mar 22 20:33:54 2012 > New Revision: 1304040 > > URL: http://svn.apache.org/viewvc?rev=1304040&view=rev > Log: > Observed strange NPE while running tests. This isn't much more than a guess > at what might have caused it. >

Re: svn commit: r1300154 [1/2] - in /tomcat/trunk: ./ java/org/apache/coyote/ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/

2012-03-23 Thread Mark Thomas
On 23/03/2012 01:41, Konstantin Kolinko wrote: > 2012/3/13 : >> Author: markt >> Date: Tue Mar 13 14:39:24 2012 >> New Revision: 1300154 > 1) It seems that quoted text handling (" TOKEN" > construct) is slightly wrong in its handling of backslash character. Agreed. Fixed. > 2) RFC2616: ch.3.7

Re: svn commit: r1304011 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-03-23 Thread Mark Thomas
Konstantin Kolinko wrote: >2012/3/23 Konstantin Kolinko : >> 2012/3/22  : >> >>> URL: http://svn.apache.org/viewvc?rev=1304011&view=rev >> >> Comparing (1) and (2), >>  both are terminating the loop, but the (2)nd block has >> "selector.close()" call and (1)st does not have the call. I suspect

Move to svnpubsub Was: svn commit: r1305109 [1/6] - ...

2012-03-25 Thread Mark Thomas
On 25/03/2012 20:52, ma...@apache.org wrote: > Author: markt > Date: Sun Mar 25 19:52:05 2012 > New Revision: 1305109 > > URL: http://svn.apache.org/viewvc?rev=1305109&view=rev > Log: > Add Tomcat 3.2 docs This is the start of the process to move the Tomcat web site to svnpubsub as mandated by th

Re: Move to svnpubsub Was: svn commit: r1305109 [1/6] - ...

2012-03-25 Thread Mark Thomas
On 25/03/2012 21:24, Konstantin Kolinko wrote: > 2012/3/26 Mark Thomas : >> On 25/03/2012 20:52, ma...@apache.org wrote: >>> Author: markt >>> Date: Sun Mar 25 19:52:05 2012 >>> New Revision: 1305109 >>> >>> URL: http://svn.apache.org/viewvc

Re: svn commit: r1305118 - in /tomcat/site/trunk/docs/tomcat-4.0-docs: ./ WEB-INF/ appdev/ appdev/sample/ appdev/sample/docs/ appdev/sample/src/ appdev/sample/src/mypackage/ appdev/sample/web/ appdev/

2012-03-25 Thread Mark Thomas
On 25/03/2012 21:30, ma...@apache.org wrote: > Author: markt > Date: Sun Mar 25 20:30:06 2012 > New Revision: 1305118 > > URL: http://svn.apache.org/viewvc?rev=1305118&view=rev > Log: > Add the Tomcat 4.0 docs > > > [This commit notification would consist of 180 parts, > which exceeds the limit

Re: SPDY support

2012-03-25 Thread Mark Thomas
On 25/03/2012 17:24, Costin Manolache wrote: > For Tomcat7 I'm proposing to only add hooks: 'beforeHandshake' callback in > Handler, and an optional NpnHandler class plus setters in protocol. > There is no Java7 or spdy dependency at all. Sounds good to me. > The main question is if it's ok to ad

Re: Move to svnpubsub Was: svn commit: r1305109 [1/6] - ...

2012-03-26 Thread Mark Thomas
a staging site you can use. Mark > > > 2012/3/25 Mark Thomas : >> On 25/03/2012 21:24, Konstantin Kolinko wrote: >>> 2012/3/26 Mark Thomas : >>>> On 25/03/2012 20:52, ma...@apache.org wrote: >>>>> Author: markt >>>>> Date: Su

Re: svn commit: r1305321 - in /tomcat/site/trunk/docs/maven-plugin-2.0-beta-1: ./ apidocs/ apidocs/org/ apidocs/org/apache/ apidocs/org/apache/tomcat/ apidocs/org/apache/tomcat/maven/ apidocs/org/apac

2012-03-26 Thread Mark Thomas
On 26/03/2012 13:02, ol...@apache.org wrote: > Author: olamy > Date: Mon Mar 26 12:01:12 2012 > New Revision: 1305321 > > URL: http://svn.apache.org/viewvc?rev=1305321&view=rev > Log: > import maven-plugin 2.0-beta-1 site for svnpub: really sorry for such > spamming :-) You don't want to include

Time for 7.0.27

2012-03-27 Thread Mark Thomas
The 7.0.x change log is looking long again and with the only open TC7 bugs in NEEDINFO state, I am going to start the process of rolling the 7.0.27 release. I'm not going to tag 7.0.27 until I've confirmed that all the various tests pass and they'll probably take a day or so to run. Mark ---

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-03-30 Thread Mark Thomas
Costin broke the unit tests for Gump when the jni classes were moved to a separate JAR. I've hopefully fixed this so we should be good to go with the next Gump run. The Maven publishing for the new JARs still needs to be fixed. Mark ---

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-03-30 Thread Mark Thomas
On 30/03/2012 19:41, Mark Thomas wrote: > The Maven publishing for the new JARs still needs to be fixed. Done. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: de

7.0.27 progress report

2012-03-30 Thread Mark Thomas
The unit tests for 7.0.x have completed twice in a row on both Linux and Windows. That is much better than what I was seeing a few days ago and comparable to previous releases. Next up the TCKs. That'll be tomorrows task. Mark -

[VOTE] Release Apache Tomcat 7.0.27

2012-03-31 Thread Mark Thomas
The proposed Apache Tomcat 7.0.27 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.27/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-132/ The svn tag is: http://svn.apache.org/r

Re: [VOTE] Release Apache Tomcat 7.0.27

2012-03-31 Thread Mark Thomas
On 31/03/2012 18:07, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.27 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.27/ > The Maven staging repo is: > https://repository.apache.org/co

Re: [VOTE] Release Apache Tomcat 7.0.27

2012-04-02 Thread Mark Thomas
On 01/04/2012 15:26, Rainer Jung wrote: >>- AJP via httpd + mod_jk to BIO, NIO and APR/native >>- AJP via httpd + mod_proxy_ajp to BIO, NIO and APR/native > > I'm curious: which mod_jk version did you use? 1.2.31 I am mainly concerned about the AJP implementation on the Java side but I s

Re: [VOTE] Release Apache Tomcat 7.0.27

2012-04-02 Thread Mark Thomas
On 02/04/2012 19:30, Mark Thomas wrote: > On 01/04/2012 15:26, Rainer Jung wrote: >>>- AJP via httpd + mod_jk to BIO, NIO and APR/native >>>- AJP via httpd + mod_proxy_ajp to BIO, NIO and APR/native >> >> I'm curious: which mod_jk version did you use?

Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-04 Thread Mark Thomas
On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote: > > > - Original Message - >> From: ma...@apache.org To: dev@tomcat.apache.org Sent: Thursday, >> March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 - >> /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/D

[RESULT][VOTE] Release Apache Tomcat 7.0.27

2012-04-04 Thread Mark Thomas
This vote passes. The votes were as follows: +1: markt (binding) rjung (binding) olamy (binding) kkolinko (binding) schultz fhanik (binding) I'll move the files to /dist, give the mirrors time to sync and then announce the release. Might happen later tonight, might be tomorrow. Mark -

Re: svn commit: r1309734 - in /tomcat/trunk: java/org/apache/catalina/startup/UserConfig.java webapps/docs/config/listeners.xml

2012-04-05 Thread Mark Thomas
On 05/04/2012 11:46, Konstantin Kolinko wrote: > 2012/4/5 : >> Author: kfujino >> Date: Thu Apr 5 10:08:38 2012 >> New Revision: 1309734 >> >> URL: http://svn.apache.org/viewvc?rev=1309734&view=rev >> Log: >> Add new attributes of enabled and disabled to UserConfig. > > The name "enabled" is usu

[ANN] Apache Tomcat 7.0.27 released

2012-04-05 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.27 This release is includes significant new features as well as a number of bug fixes compared to version 7.0.26. The notable changes include: * Support for the WebSocket protocol (RFC6455). Both streaming and messa

Re: svn commit: r1310541 - in /tomcat/trunk/test/javax: el/TestCompositeELResolver.java servlet/jsp/TestPageContext.java

2012-04-06 Thread Mark Thomas
On 06/04/2012 22:16, Konstantin Kolinko wrote: > 2012/4/6 : >> Author: markt >> Date: Fri Apr 6 18:44:19 2012 >> New Revision: 1310541 >> >> URL: http://svn.apache.org/viewvc?rev=1310541&view=rev >> Log: >> Don't use static imports > > ? > > 1. I would say that I'd prefer to use static imports

Re: svn commit: r1310707 - /tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java

2012-04-07 Thread Mark Thomas
On 07/04/2012 09:51, p...@apache.org wrote: > Author: pero > Date: Sat Apr 7 08:51:44 2012 > New Revision: 1310707 > > URL: http://svn.apache.org/viewvc?rev=1310707&view=rev > Log: > Send header with uppercase names Why? HTTP headers are case insensitive. Mark -

Re: svn commit: r1310712 - in /tomcat/tc7.0.x/trunk: res/maven/tomcat-catalina-ha.pom res/maven/tomcat-coyote.pom res/maven/tomcat-embed-jasper.pom res/maven/tomcat-util.pom webapps/docs/changelog.xml

2012-04-07 Thread Mark Thomas
On 07/04/2012 10:14, Peter Roßbach wrote: > cool remove a point of my TODO list > +1 > > I have checked that also new maven-ant-tasks-2.1.3 works. > How we can download this jar and jsch? I assume updating the init-maven task in the mvn-pub.xml will do that. Mark ---

Re: svn commit: r1310693 - in /tomcat/tc7.0.x/trunk: res/maven/tomcat-jasper.pom webapps/docs/changelog.xml

2012-04-07 Thread Mark Thomas
On 07/04/2012 14:02, Olivier Lamy wrote: > So as those poms are pushed to central repo I would prefer revert those. > We won't be able to use those poms in the maven plugin by example and > that will fail too people using this artifact. The poms are kept in sync with the versions that Tomcat ships

Re: svn commit: r1310693 - in /tomcat/tc7.0.x/trunk: res/maven/tomcat-jasper.pom webapps/docs/changelog.xml

2012-04-07 Thread Mark Thomas
Olivier Lamy wrote: >2012/4/7 Mark Thomas : >> On 07/04/2012 14:02, Olivier Lamy wrote: >>> So as those poms are pushed to central repo I would prefer revert >those. >>> We won't be able to use those poms in the maven plugin by example >and >>>

Re: Who wants my Cassandra session manager for Tomcat?

2012-04-10 Thread Mark Thomas
On 10/04/2012 19:38, Christopher Schultz wrote: > On 4/10/12 2:18 PM, Morten Jorgensen wrote: >> I would imagine that there are several architects out there that >> are experiencing similar problems, hence I want to share my >> work. > > I think the best place for this kind of thing is probably di

<    2   3   4   5   6   7   8   9   10   11   >