-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/03/2012 14:33, Christopher Schultz wrote: > Mark, > > On 3/8/12 4:25 PM, ma...@apache.org wrote: >> Author: markt Date: Thu Mar 8 21:25:31 2012 New Revision: >> 1298590 >> >> URL: http://svn.apache.org/viewvc?rev=1298590&view=rev Log: Fix >> various Checkstyle / Eclipse warnings and failures > > This built cleanly for me, and all (expected) tests passed. > > I saw the buildbot complaint, but I couldn't find any actual errors > in the build. The only thing I could make sense of was the javadoc > warnings, so I fixed those. > >> Modified: >> tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java?rev=1298590&r1=1298589&r2=1298590&view=diff >> >> ============================================================================== >> >> @@ -1440,7 +1440,7 @@ public abstract class RealmBase extends try >> { @SuppressWarnings("unchecked") Class<? extends >> X509UsernameRetriever> clazz = (Class<? extends >> X509UsernameRetriever>)Class.forName(className); - >> return (X509UsernameRetriever)clazz.newInstance(); + >> return clazz.newInstance(); > > This was actually intentional: I want the new object to be cast to > X509UsernameRetriever *here* so we can catch and re-throw an > exception with a nice error message. I didn't check the bytecode, > but I assumed that without a cast, no type-check would occur. > Working with Java's generics makes my head hurt.
Eclipse reports the cast is unnecessary which is what I would expect looking at the code. > Shall I make these same changes in 7.0.x? Consistency is good. Mark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPWhaYAAoJEBDAHFovYFnn8kQP/1FtUH8Vqle4aQqoItqBF9zR dOIewVIW738/VNXnUmEWBwzUAK/SnnikB7g6xdYxSfvHOhwO1DVIPdGz/13GjdSF GJK61H4iM8f3eRkmcLeFGo6oCbbxhMJyf2Q2tb1m+312PbfpyvvPDnBskDybIXvJ SQBFcycxEhyfEiIQCh0HfvhQafCA+rJz9Au9UtPny5oHSPAwoHDf0beR+X0Rc1xz gagUz7TeADBMi6nnsIRwI0TVZX7EZVaO7OiTXugX7PFY9xDC6d1Ff7QwJesRCYh8 /rAJMujSud3L+oBwYR4uACQenO9sdz/Vocr2v5INrRSeqv4kSleK6SrdH1Ngkv3D UHOJVnRIbK1akloq9NqoMdPXGA6G6JmAHZq13t+l7SSUrunOgUIec/PmQFAzkfDF pKA5zBnV9YCuNvTRM0HwIepT4CKATDCni9zJsDo7IE4LCLAIdp+McGff00pCq2yE kx5Ux91KmbJ78e61YryPz4oicHpTfn5N3bm0Nonb0hEY/cFzyNx2vdCP6RxwdgK0 0DP9pWtTsDfOUR49BdpiuT6CTnh5tvsxVeez46OduRfvwDS4aaH6LRMQiWgVnFf1 BjFTUFLJsW0QWJeMwpIp/7oUzh99/OCnOTF5bh8xXYlZco8/s2+Kj5SmbdijfSYs i/TV13gEEnC7+0lszHqd =d6q1 -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
