Re: svn commit: r1100940 - in /tomcat/trunk: java/org/apache/catalina/valves/LocalStrings.properties java/org/apache/catalina/valves/RemoteIpValve.java webapps/docs/changelog.xml webapps/docs/config/v

2011-05-09 Thread Konstantin Kolinko
er), nfe); > +} if (log.isDebugEnabled()){...} > +used by the client to connect to the proxy. If not specified, the > +default of null is used. Maybe treat an empty string as if it were he null. Is a

Re: svn commit: r1100992 - in /tomcat/trunk: java/org/apache/catalina/core/ApplicationSessionCookieConfig.java webapps/docs/changelog.xml

2011-05-09 Thread Konstantin Kolinko
I have seen applications where /webappname is not redirected to /webappname/ but is served as is. IIRC, that happens when there is no welcome file. If I understand correctly, this change will break them. Maybe make it conditional? For reference, discussion on users@ [1] http://markmail.org/mes

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-18 Thread Konstantin Kolinko
h them. There is a thread at dev@subversion that the first alpha/beta for 1.7.0 is tentatively scheduled on June 1. 3. Will we migrate our website to the new CMS? https://blogs.apache.org/infra/entry/the_asf_cms Have you thought whether you proposal will facilitate such migration, or impede it?

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-18 Thread Konstantin Kolinko
sages be forwarded to the mailing list? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1124644 - in /tomcat/trunk/webapps/docs: changelog.xml config/listeners.xml

2011-05-19 Thread Konstantin Kolinko
2011/5/19 : > Author: markt > Date: Thu May 19 09:43:59 2011 > New Revision: 1124644 > > URL: http://svn.apache.org/viewvc?rev=1124644&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51182 > Better organisation of listeners doc > Add JAAS/JMX listener info > Patch provided

Re: Fixing bug 33453

2011-05-23 Thread Konstantin Kolinko
o change JspCompilationContext class in this way. I think we usually add methods, but do not remove them. 2) In JspCompilationContext line 298 the change is s/"jar:file:"/"jar:jndi:"/. It might be needed, but I do not understand why. It looks like a separate (un)related issue.

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-24 Thread Konstantin Kolinko
the subdirectories inside of "m2-repository" can be removed and recreated when preparing 6.0.33 release (if they are needed e.g. as a staging area). Anyway, the current scope is dist at www.apache.org, which does not interfere with the area on tomcat.apache.o

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Konstantin Kolinko
looks OK but my small concern is that the invalid case is handled with a NumberFormatException here and it can be triggered by an external request. I have not tested it here, but general notion is that exception creation is expensive. Maybe we can use a cached copy of NumberFormatException, like

Re: [PROPOSAL] Enable session replication by default.

2011-06-07 Thread Konstantin Kolinko
nts of the Serializable interface. It will mean that some webapps will stop working in the default configuration. Thus we cannot assume that "distributable" flag is true by default. I suspect that specification implies that "distributable" flag defaults to false. I have n

Re: [PROPOSAL] Enable session replication by default.

2011-06-07 Thread Konstantin Kolinko
Version()); } if (webXmlVersion >= 3) { Just can be replaced with one line if (webXml.getMajorVersion() >= 3) { Note, that webXml.getVersion() never returns null. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-06-15 Thread Konstantin Kolinko
org.apache.catalina.core.TestAsyncContextImpl.validateAccessLog(TestAsyncContextImpl.java:1052) at org.apache.catalina.core.TestAsyncContextImpl.testListeners(TestAsyncContextImpl.java:628) Best regards, Konstantin Kolinko 2011/6/15 Bill Barker : > To whom it may engage... > > This is an automated request, but not an unsolicited one. F

Re: Embedding Tomcat 7 in Apache OFBiz

2011-06-16 Thread Konstantin Kolinko
dServlet(String, Class) b) If you want to change Tomcat code, file an issue in Bugzilla. It should be easy to fix: do not see why not to add parent!=null check there. Though I do not know whether it will fail further down the road. The same may be said about similar code in removeMapping() me

Re: [VOTE] Release Apache Tomcat 7.0.16

2011-06-16 Thread Konstantin Kolinko
ith all connectors separately I did not observe the issue. All other tests in the testsuite did run successfully: BIO, NIO, APR, with Oracle JDK 6u25 32-bit on Windows XP Best regards, Konstantin Kolinko - To unsubscribe, e-mail

Diagram for AsyncStateMachine.java

2011-06-18 Thread Konstantin Kolinko
ng it yet. Feel free to enjoy and comment. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Wiki spam prevention measure

2011-06-19 Thread Konstantin Kolinko
t here 7*24 to add people. 2) There is "PoweredBy" page that has hundred of different authors. I am not ready to manage those people. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat

Re: Diagram for AsyncStateMachine.java

2011-06-19 Thread Konstantin Kolinko
2011/6/19 Mark Thomas : > On 19/06/2011 01:15, Konstantin Kolinko wrote: >> I have redrawn the state diagram for trunk's >> org/apache/coyote/AsyncStateMachine.java. > > Why? I was trying to understand the logic behind the states and similarities between them, without lo

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Konstantin Kolinko
; > Funny, but I was actually trying to add $CATALINA_OPTS > to the version command, so we get consistent JVM behavior. > -d32/-d64 flag should go into JAVA_OPTS, so that stop command were using it as well. Maybe let version command to print out the content of JAVA_OPTS and CATALI

Re: OneLineFormatter by default?

2011-06-20 Thread Konstantin Kolinko
mentations there. If it were changed I'd prefer it to be in the configuration. Regarding grep: Some grep implementations (e.g. the GNU one) have --context, --before-context, --after-context options to print several lines of context for each match (section 2.1.5 in [1]

Re: svn commit: r1137803 - /tomcat/trunk/webapps/docs/changelog.xml

2011-06-20 Thread Konstantin Kolinko
y strict rule. There is no ordering by add/update/fix. Other fixed issues are added to the end of the list, chronologically. They eventually become mixed with the numbered issues. (I.e., numbered issues to not "pop up" wrt. others). Best regards, Konstantin Kolinko

Re: Overhauling setclasspath.(bat|sh)?

2011-06-21 Thread Konstantin Kolinko
ASEDIR is never ever used. It is used: set "JAVA_ENDORSED_DIRS=%BASEDIR%\endorsed" but given that it always is equal to CATALINA_HOME I think it is OK to replace it with CATALINA_HOME. Best regards, Konstantin Kolinko - To

Re: svn commit: r1137638 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11AprProtocol.java

2011-06-21 Thread Konstantin Kolinko
SocketState state = SocketState.CLOSED; >                 do { >                     if (processor.isAsync() || state == > SocketState.ASYNC_END) { > -                        state = processor.asyncDispatch(socket, status); > +                        state = processor.asy

Re: svn commit: r1137638 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11AprProtocol.java

2011-06-21 Thread Konstantin Kolinko
2011/6/21 Mark Thomas : > On 21/06/2011 13:00, Konstantin Kolinko wrote: >> Why setting socket reference in InputBuffer and OutputBuffer is >> "unnecessary" here in async processing, but is still present for the >> non-async case. > > Because during the process

Re: svn commit: r1138573 - in /tomcat/trunk: java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2011-06-22 Thread Konstantin Kolinko
s NoDefaultWebXml 3) use the value to short-circuit ContextConfig#getWebXmlSource(defaultWebXml, baseDir) to return null An alternative to 2)+3) is to put the constant into DefaultWebXmlListener, but I like 2)+3) better. Best regards, Konstantin Kolinko -

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Konstantin Kolinko
.sh to build a list of jars and define it as a system property. Summarizing: I do not mind to add support for name*.jar, but will think twice about anything else. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Multiple instances of the same Tomcat version (was: svn commit: r1139381)

2011-06-24 Thread Konstantin Kolinko
copies configuration files from existing installation of Tomcat and later uses the port specified there to stopping launched Tomcat. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@to

Re: Multiple instances of the same Tomcat version (was: svn commit: r1139381)

2011-06-25 Thread Konstantin Kolinko
2011/6/25 Konstantin Kolinko : > > Though I suspect that for running as a service that value can be "-1", thought > Sorry, I did not notice that shutdown port has already been changed. (I looked in the file, but did not notice that my "svn update" command had

Re: svn commit: r1139576 - in /tomcat/trunk/webapps/docs: changelog.xml project.xml upgrading.xml

2011-06-26 Thread Konstantin Kolinko
The list of revisions could be on tomcat.apache.org and retrieved via ajax. Or maybe it'd be better to make this form part of http://tomcat.apache.org/migration.html By the way, 1) using r2=HEAD works for me - may add that value to the list. 2) besides left-side menu, there is also a

Re: svn commit: r1140204 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2011-06-27 Thread Konstantin Kolinko
ified a bit. > +            for (String alias : charset.aliases()) { > +                encodingToCharsetCache.put(alias, charset); Should be: s/alias/alias.toLowerCase(Locale.US)/ > +            } >         } >     } I was wondering how slow is Charset.availableCharsets(). I

Re: JK 1.2.32 release kick

2011-06-27 Thread Konstantin Kolinko
2011/6/27 Mladen Turk : > Hi, > > I have a time slot available so I volunteer as a 1.2.32 RM. > Think we are good for a new release. > > Comments, objections? Sounds good. +1. Best regards, Konstantin Kolinko --

Re: svn commit: r1140467 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-06-28 Thread Konstantin Kolinko
oncurrentHashMap/HashMap/ as the map is >> -     immutable at runtime. Though that is not of much difference. >> - > > Konstantin, I left your vote in place as the changes are essentially > addressing your review comments but the comments did prompt a couple of &

Re: svn commit: r1140383 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-06-28 Thread Konstantin Kolinko
not introduce new variables that will be seen by user's code, unless those are prefixed with reserved prefix of "jsp_" ( "_jsp_") per JSP.9.1.2. That is because someone can declare a local variable with the same name.

Re: svn commit: r1140383 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-06-28 Thread Konstantin Kolinko
2011/6/28 Mark Thomas : > On 28/06/2011 11:38, Konstantin Kolinko wrote: >> 2011/6/28 Mark Thomas : >> >> There is one more problem: you cannot introduce new variables that >> will be seen by user's code, unless those are prefixed with reserved >> prefix of &q

Re: svn commit: r1140383 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-06-28 Thread Konstantin Kolinko
names of (pre)compiled jsps will change between minor versions. > I suppose we could add a > periodToUnderscore parameter to makeJavaIdentifier() and essnetially > have both approaches. The current one for file names, the n

Re: response.encodeURL("http://localhost:8080") produces an invalid URL?

2011-06-29 Thread Konstantin Kolinko
:8080;jsessionid=... is an invalid URL. I am +1 to use "/" as the path if it is an absolute URL, scheme is http or https and the path is empty. (I guess that there is a check for the scheme name already?). So that it becomes http://localhost:8080/;jsessionid=... Best regards, Konstantin Kol

Re: response.encodeURL("http://localhost:8080") produces an invalid URL?

2011-06-29 Thread Konstantin Kolinko
2011/6/29 Erik Bertelsen : > 2011/6/29 Konstantin Kolinko : > >> >> From HTTP standpoint it should be http://localhost:8080/ and in my >> experience browsers add the trailing slash automatically. I have not >> looked whether the actual HTTP spec is more

Re: svn commit: r1141388 - /tomcat/native/trunk/native/src/sslcontext.c

2011-06-29 Thread Konstantin Kolinko
gt;    tomcat/native/trunk/native/src/sslcontext.c > > -        cb_data->password[0] = '\0'; The above line inside the loop in the old code - I guess it was retrying without a password. With your change that retry is gone. Is that OK? (Just guessing, I do not kn

Re: Tagging 7.0.17

2011-07-01 Thread Konstantin Kolinko
t regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Multiple instances of the same Tomcat version (was: svn commit: r1139381)

2011-07-01 Thread Konstantin Kolinko
2011/6/25 Konstantin Kolinko : > 2011/6/25 Konstantin Kolinko : >> >> Though I suspect that for running as a service that value can be "-1", >> thought >> > > Sorry, I did not notice that shutdown port has already been changed. > (I looked in th

Re: [VOTE] Release Apache Tomcat 7.0.17

2011-07-03 Thread Konstantin Kolinko
ge it. BTW, an alternative could be to use sibling folders instead of nested ones, adding a suffix to the name, e.g.: "%ProgramFiles%\Apache Software Foundation\Tomcat 7.0_servicename" and remove the "_servicename" pa

Re: [VOTE] Release Apache Tomcat 7.0.17

2011-07-05 Thread Konstantin Kolinko
2011/7/3 Konstantin Kolinko : > 2011/7/3 Mark Thomas : > > 1) "Windows Service Name" field does not restrict you from putting > anything there. >(...) > > 2) Tomcat 7 now by default installs into > "%ProgramFiles%\Apache Software Foundation\Tomcat 7.0\Tomca

Re: svn commit: r1142953 - in /tomcat/trunk: java/javax/el/BeanELResolver.java webapps/docs/changelog.xml

2011-07-05 Thread Konstantin Kolinko
Resolver.getMethod() checks that - either the class declaring the method is public, or - the method is a public one declared in a public parent or public interface implemented by this class. Best regards, Konstantin Kolinko --

Re: svn commit: r1143134 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/GzipInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestGzipInterceptor.java

2011-07-05 Thread Konstantin Kolinko
m.arraycopy(tmp,0,result,0,length); > -        return result; > +        int length = 0; Just int length = gin.read(tmp); will save an iteration. > +        while (length > -1) { > +            bout.write(tmp, 0, length); > +            length = gin.read(tmp); >

Re: svn commit: r1135088 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2011-07-05 Thread Konstantin Kolinko
1. JavaDoc for the method has to be updated. It still says that the name is quoted. 2. If I understand correctly, the name _is_ used directly, in AbstractConnectionHandler.register(): ... ",worker=" + getProtocol().getName() + ",name=" ... and MBeanUtils.destroyMBean(Connector,Service) worker =

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Konstantin Kolinko
I have doubts regarding this change. If I understand correctly, recycle() (and thus recycleInternal()) is not called when several requests are processed in a row. So, in the old code sendfile is set to null before each request, in the new code it is set to null only once after connection is clo

Re: svn commit: r1135088 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2011-07-06 Thread Konstantin Kolinko
2011/7/6 Rainer Jung : > Hi Konstantin, > > On 06.07.2011 08:03, Konstantin Kolinko wrote: >> 1. JavaDoc for the method has to be updated. It still says that the >> name is quoted. > > Will fix. > >> 2. If I understand correc

Something is wrong with TC7 uninstaller (Windows)

2011-07-06 Thread Konstantin Kolinko
I have have not looked in the nsi file yet to confirm. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Something is wrong with TC7 uninstaller (Windows)

2011-07-06 Thread Konstantin Kolinko
2011/7/6 Konstantin Kolinko : > There is some bug in the uninstaller: > > It deleted *all* shortcuts from Windows Menu (both for me and for All Users), > not only Tomcat ones. > > I just noticed after rebooting, that none of my Startup shortcuts did > run -- they have bee

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Konstantin Kolinko
2011/7/6 Mark Thomas : > On 06/07/2011 08:55, Konstantin Kolinko wrote: >> I have doubts regarding this change. >> >> If I understand correctly,  recycle() (and thus recycleInternal()) is >> not called when several requests are processed in a row. > > Recycl

Re: svn commit: r1143488 - /tomcat/trunk/test/org/apache/tomcat/util/threads/TestLimitLatch.java

2011-07-06 Thread Konstantin Kolinko
StackTrace(); If you are really avoiding the exception as the commit message says, then the above catch should not be necessary? It just suppresses it. The issue was with the testcase and not with the latch itself? >             } catch (InterruptedException x) { >                 x.printSt

Re: svn commit: r1144061 - in /tomcat/trunk: build.xml modules/jdbc-pool/build.xml res/maven/mvn-pub.xml res/maven/tomcat-jdbc.pom webapps/docs/project.xml

2011-07-07 Thread Konstantin Kolinko
e jdbc-pool.html comes from? You forgot to commit it? Or is it supposed to be copied from elsewhere during build. 3) The documentation pages are listed not only in the menu that you updated, but also on the index.html page. Please update that one as well. Best regards, Konstantin Kolinko --

Blank extra access log entries with AJP connector in 7.0.18

2011-07-07 Thread Konstantin Kolinko
show stopper. This issue is observed with 7.0.17 as well. I have not tested 7.0.16 in this configuration. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Deploying Emboss in Opal2

2011-07-08 Thread Konstantin Kolinko
2011/7/8 jeroen vannevel : > I've installed Opal2 on my Tomcat 5.5.33 server and now I'd like to make th= > e emboss programs available in this. You are asking on a wrong mailing list. This is a question for the users@ list. - To

Re: [VOTE] Release Apache Tomcat 7.0.18

2011-07-09 Thread Konstantin Kolinko
se is r1135088 that has to be reverted. I feel sorry that I did not revert it immediately when I started Re:r1135088 discussion 4 days ago. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr.

Re: svn commit: r1144833 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-10 Thread Konstantin Kolinko
ad of "". > Nice catch. There is one more regression there: month names are now localized and may be printed not in English, but in other languages. 127.0.0.1 - - [09/июл/11:00:48:22 +0400] "GET /examples/ HTTP/1.1" 200 1156 Best regards, Konstantin Kolinko

Re: svn commit: r1144833 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-11 Thread Konstantin Kolinko
2011/7/11 Rainer Jung : > On 11.07.2011 01:24, Konstantin Kolinko wrote: >> 2011/7/10  : >>> Author: rjung >>> Date: Sun Jul 10 11:22:40 2011 >>> New Revision: 1144833 >>> >>> URL: http://svn.apache.org/viewvc?rev=1144833&view=rev >>

Re: Using juli DateFormatCache in AccessLogValve?

2011-07-11 Thread Konstantin Kolinko
se. I am mentioning them here just as a reminder. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Konstantin Kolinko
ession I would like to have the check optional, i.e. only > check if the configuration wants the attribute to be replicated. > > By default all attributes will be replicated as is today, but by > configuration one will be able to choose attributes to replicate using a > regexp again

Re: 7.0.18 installer does not work under windows with a custom service name

2011-07-11 Thread Konstantin Kolinko
2011/7/11 etienne massip : > It is, but it would have been accurate to tell me that the service did > already exist instead of leading me on permission issues. I filed https://issues.apache.org/bugzilla/show_bug.cgi?id=51496 Best regards, Konstantin K

Re: svn commit: r1144833 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-11 Thread Konstantin Kolinko
option you might end with '???' for a month name. BTW, ExtendedAccessLogValve#ElementTimestampStruct probably will have the same issue with locales. I have not tested it, though. Best regards, Konstantin Kolinko - To unsubscribe, e-

Re: Use canonical IPv6 text representation in logs

2011-07-11 Thread Konstantin Kolinko
r and Apache BCEL. b) original sources are processed through renaming filter and recompiled when Tomcat builds - such are Commons Logging, Commons Pool and Commons DBCP. As thus, your contribution to Tomcat can be independent from Commons. Best regards, Konstantin Kolinko

Re: Locale and SimpleDateFormat: creationdate in WebdavServlet

2011-07-11 Thread Konstantin Kolinko
be en_US. > > I don't know much about Webdav though ... > > Agreed? > > It is the last SDF that does not have a Locale and probably should have > one. The other cases seem OK. I agree. It uses 2-digit month, so it does not matter much, unless you have

Re: Use canonical IPv6 text representation in logs

2011-07-11 Thread Konstantin Kolinko
XML parameter? > 4. Global Tomcat system property? I do not like 2.,3. or 4. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: tomcat-native and OS/X

2011-07-13 Thread Konstantin Kolinko
t Tomcat 6 > still didn't detect it. > Is it 1.0.1.20 or 1.1.20.0? Was it always dylib (and not so)? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1146623 - in /tomcat/trunk: conf/catalina.properties webapps/docs/changelog.xml

2011-07-14 Thread Konstantin Kolinko
ing*.jar,\ It would be nice to add a Test to our testsuite to test that any ".jar" in this property value is followed by comma: either by (optional spaces and comma) or by (end of line). Best regards, Konstantin Kolinko -

Re: Casual proposal for change to WebappClassLoader.clearReferencesThreads

2011-07-14 Thread Konstantin Kolinko
learn how to take care of the problem by themselves. I think there is no need for this option that you are suggesting. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For addit

Re: How can i change JSESSIONIDSSO cookie name?

2011-07-15 Thread Konstantin Kolinko
2011/7/15 Mathan Karthik : > Hi Guys, > > I have JSESSIONIDSSO cookie related problem. > > Currently I'm running two web applications in the same machine, but using two > different tomcat servers. Both the applications has the same context path, > but port numbers are different. > > I've enabled

Re: [VOTE] Release Apache Tomcat 7.0.19

2011-07-15 Thread Konstantin Kolinko
.apache.org/viewvc?rev=1146623&view=rev I think it is worth mentioning. I filed a bug for one error encountered when testing one of our webapps. I have not investigated it further yet. It is not a stopper. https://issues.apache.org/bugzilla/show_bug.cgi

Re: svn commit: r1146623 - in /tomcat/trunk: conf/catalina.properties webapps/docs/changelog.xml

2011-07-21 Thread Konstantin Kolinko
2011/7/19 Rainer Jung : > On 14.07.2011 12:08, Konstantin Kolinko wrote: >> >> It would be nice to add a Test to our testsuite to test that any >> ".jar" in this property value is followed by comma: >> either by (optional spaces and comma) or by (end of

Re: svn commit: r1148216 - /tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java

2011-07-21 Thread Konstantin Kolinko
sageArray, 0, >                     flushMessageArray.length) < 0) { >                 throw new > IOException(sm.getString("ajpprocessor.failedflush")); > > > > - Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1149104 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/ExtendedAccessLogValve.java webapps/docs/config/valve.xml

2011-07-21 Thread Konstantin Kolinko
URL: http://svn.apache.org/viewvc?rev=1149104&view=rev >> Log: > ... * >> + * >> + * For UvNIX users, another field called checkExists is also >> + * available. If set to true, the log file's existence will be checked >> before >> + > ... Best reg

PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-22 Thread Konstantin Kolinko
t.de/blog/eclipseide/static_methods/ Are there any objections or comments? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-25 Thread Konstantin Kolinko
2011/7/22 Konstantin Kolinko : > Hi! > > I propose to update Tomcat 7 tests to use JUnit 4. > > One feature that I would like to use from there is to write failing > tests before fixing the code and annotate them with @Ignore so that > they are skipped until the

Re: PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-25 Thread Konstantin Kolinko
2011/7/22 Konstantin Kolinko : > * First step is to use these values in build.properties: > > junit.home=${base.path}/junit4.8.2 > junit.lib=${junit.home} > junit.jar=${junit.lib}/junit-4.8.2.jar > junit.loc=http://cloud.github.com/downloads/KentBeck/junit/junit4.8.2.zip >

Re: PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-25 Thread Konstantin Kolinko
2011/7/26 Konstantin Kolinko : > 2011/7/22 Konstantin Kolinko : >> * First step is to use these values in build.properties: >> * Next step is to convert existing tests to use JUnit 4 annotations. >> > > Completed for everything, > except test cases that are in org.apa

Re: svn commit: r1149665 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-07-25 Thread Konstantin Kolinko
with NioEndpoint$Poller.add(socket) and that method actually calls NioEndpoint$Poller.add(socket, SelectionKey.OP_READ); Is this change needed because att.getCometOps() has wrong value? Best regards, Konstantin Kolinko - To unsubscribe,

Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2011-07-26 Thread Konstantin Kolinko
kstyle sources repository and tomcat-trunk project. Let's see how next build runs. Best regards, Konstantin Kolinko 2011/7/26 Bill Barker : > To whom it may engage... > > This is an automated request, but not an unsolicited one. For > more information please visit http://gump.a

Re: Servlet 3.1, Tomcat 8 etc.

2011-07-26 Thread Konstantin Kolinko
re > supporting. With that in mind, should we announce end of support for > 5.5.x with the last release expected in ~12 months time? +1 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-07-28 Thread Konstantin Kolinko
sl.doTestCustomTrustManager(TestCustomSsl.java:135) at org.apache.tomcat.util.net.TestCustomSsl.testCustomTrustManager1(TestCustomSsl.java:83) Testcase: testCustomTrustManager2 took 2.24 sec ]]] I have not investigated the cause. Best regards, Konstantin Kolinko -

Re: TC 6/7 class loaders

2011-07-29 Thread Konstantin Kolinko
'll update class-loader-howto.html soon, because I see some typos/ glitches there. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.1.22

2011-08-01 Thread Konstantin Kolinko
y_report.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1152863 - in /tomcat/trunk: res/tomcat.nsi webapps/docs/changelog.xml

2011-08-01 Thread Konstantin Kolinko
1. There is one more place to fix -- search for "Uninstall.exe" -> lines 350-351. 2. I filed https://issues.apache.org/bugzilla/show_bug.cgi?id=51598 because a user may bypass this trick. Best regards, Konstantin Kolinko 2011/8/1 : > Author: markt > Date: Mon Aug  1

Re: svn commit: r1153081 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-08-02 Thread Konstantin Kolinko
server*.xml, res/tick*.bmp, res/main.ico, >             res/uninst.ico >   > http://people.apache.org/~markt/patches/2011-08-01-windows-installer-multiple-tc6.patch > +  http://svn.apache.org/viewvc?rev=1153075&view=rev r1152988 as well http://svn.apache.org/viewvc?rev=1152988&

Re: Replacing tcnative java classes by svn:externals?

2011-08-08 Thread Konstantin Kolinko
eated, what is the plan for jdbc-pool? Will it be copied over to the branch as well, or we can use externals pointing to trunk here? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: Replacing tcnative java classes by svn:externals?

2011-08-08 Thread Konstantin Kolinko
2011/8/8 Mark Thomas : > On 08/08/2011 12:09, Konstantin Kolinko wrote: >> 2011/8/6 Mark Thomas : >>> On 06/08/2011 19:51, Rainer Jung wrote: >>>> Anything I have overlooked? >>> >>> Tagging. >>> >>> If you use an external, you have

Re: Replacing tcnative java classes by svn:externals?

2011-08-09 Thread Konstantin Kolinko
nal, because that would bring in "/java/org/apache/tomcat/jni/.svn/**" into the source tree. Instead it should be some separate project, e.g. "modules/native" where "java" is a subdirectory inside of it. It follows that there will be changes in Eclipse project configurat

Re: svn commit: r1156530 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Response.java

2011-08-11 Thread Konstantin Kolinko
; -> & In general, I do not like this new feature. Does Apache HTTPD have it? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-19 Thread Konstantin Kolinko
     java.awt.Toolkit.getDefaultToolkit() triggered by a web > +        application do not result in a memory leak. > +        Defaults to false because an AWT thread is launched. > +       Best regards, Konstantin Kolinko --

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-19 Thread Konstantin Kolinko
2011/8/19 Christopher Schultz : > Konstantin, > > On 8/19/2011 12:34 PM, Konstantin Kolinko wrote: >> 2011/8/19  : >>> +    private boolean awtThreadProtection = false; >>> +    public boolean isAWTThreadProtection() { return awtThreadProtection; } >>&g

Re: svn commit: r1146005 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2011-08-22 Thread Konstantin Kolinko
magic string" should be a constant - as is done earlier in the file: > >  ... name.equals(Globals.DISPATCHER_REQUEST_PATH_ATTR) ... > You are right. Actually there are three magic strings used by sendfile (filename + range bounds). (It could not be done in r1146005 in order to reduce

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-23 Thread Konstantin Kolinko
ewvc?view=revision&revision=1159673 http://svn.apache.org/viewvc?view=revision&revision=1159680 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1159673 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2011-08-24 Thread Konstantin Kolinko
> > Sorry, it did not happen yet. > > I will do it in the next few hours unless someone has beaten me to it. > I did the forward-port, and replaced backport proposal in 6.0.x with one that includes documentation fix, Best regards, Konstantin Kolinko

Re: svn commit: r1161322 - in /tomcat/trunk/java/org/apache/catalina/connector: Connector.java LocalStrings.properties

2011-08-24 Thread Konstantin Kolinko
re any benefit to including the exception in the message as well > as the log output? I would have thought: > log.error(sm.getString( >        "coyoteConnector.protocolHandlerInstantiationFailed"), e); > > would be sufficient. > A little. The non-English messag

Re: DO NOT REPLY [Bug 51580] Severe error deploying WAR application (ExpandWar error)

2011-08-25 Thread Konstantin Kolinko
If it were reading UTF-8 characters as ISO-8859-1, wouldn't there be several '?'s, one for each byte? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1161566 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/listeners.xml

2011-08-25 Thread Konstantin Kolinko
by the Platform JMX/RMI server. >       Documentation part of this commit is wrong. You added attribute to a wrong listener. (rmiServerPortPlatform ...) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Grant Olivier Lamy commit karma to the Tomcat repo (for the Maven plugin)

2011-08-25 Thread Konstantin Kolinko
2011/8/25 Mark Thomas : > Subject says it all. > > Here is my +1 to start this off. > +1 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e

Re: svn commit: r1161613 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-08-25 Thread Konstantin Kolinko
e loaded by JDK 1.4 as is? If it can, it is OK to update TC5.5 to use it directly. I do not have JDK 1.4 installed to test it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1157874 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2011-08-25 Thread Konstantin Kolinko
> +                    if (pool.size()>0) { > +                        con = pool.poll(1000, TimeUnit.MILLISECONDS); > +                    } >                 } //while >             } catch (InterruptedException ex) { >                 Thread.interrupted(); > Best regards, Konstantin Kolinko ---

Re: svn commit: r1157874 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2011-08-26 Thread Konstantin Kolinko
2011/8/25 Konstantin Kolinko : >> URL: http://svn.apache.org/viewvc?rev=1157874&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51583 > > 1) I think that because of this change the " while (con != null) {" > loop may run infinite

Re: Possible bug in Tomcat Date header handling

2011-08-26 Thread Konstantin Kolinko
charset=ISO-8859-1 Date: Fri, 26 Aug 2011 16:40:02 GMT Connection: close Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.21

2011-08-29 Thread Konstantin Kolinko
not available. 2. The version of Tomcat-Native 1.1.22 binaries included in the release does not have support for IPv6. It was already reported on users@. http://tomcat.markmail.org/thread/725hgflbavb7rlkw Best regards, Konstantin Kolinko --

<    2   3   4   5   6   7   8   9   10   11   >