2011/7/6 Mark Thomas <ma...@apache.org>:
> On 06/07/2011 08:55, Konstantin Kolinko wrote:
>> I have doubts regarding this change.
>>
>> If I understand correctly,  recycle() (and thus recycleInternal()) is
>> not called when several requests are processed in a row.
>
> Recycle is called between every request, keeping in mind that a Comet
> request may involve multiple reads and writes and that Async requests
> may have multiple writes.

I do not have much time to dig at the moment,
but my understanding was that recycle() clears the input buffer. Thus
it cannot be called when there is data in it.  The method that is
called between requests when there are data is prepareRequest().

All this happens while looping inside process() call.

>
>> So, in the old code sendfile is set to null before each request,  in
>> the new code it is set to null only once after connection is closed.
>
> I don't think so. If you have some analysis that suggests otherwise,
> please share it.
>

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to