2011/8/25 Mark Thomas <ma...@apache.org>:
> On 25/08/2011 00:46, kkoli...@apache.org wrote:
>> Author: kkolinko
>> Date: Wed Aug 24 23:46:50 2011
>> New Revision: 1161322
>>
>> URL: http://svn.apache.org/viewvc?rev=1161322&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51713
>> Improve message that is logged if there is a typo in the value of protocol
>> in a <Connector> element.
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/connector/Connector.java
>> tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties
>>
>> Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=1161322&r1=1161321&r2=1161322&view=diff
>> ==============================================================================
>> --- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original)
>> +++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Wed Aug
>> 24 23:46:50 2011
>> @@ -74,9 +74,8 @@ public class Connector extends Lifecycle
>> Class<?> clazz = Class.forName(protocolHandlerClassName);
>> this.protocolHandler = (ProtocolHandler) clazz.newInstance();
>> } catch (Exception e) {
>> - log.error
>> - (sm.getString
>> - ("coyoteConnector.protocolHandlerInstantiationFailed", e));
>> + log.error(sm.getString(
>> + "coyoteConnector.protocolHandlerInstantiationFailed",
>> e), e);
>
> Is there any benefit to including the exception in the message as well
> as the log output? I would have thought:
> log.error(sm.getString(
> "coyoteConnector.protocolHandlerInstantiationFailed"), e);
>
> would be sufficient.
>
A little. The non-English messages here already have "{0}", so I was
choosing between adding it here and removing it from them.
I'll update the fix.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
