greeng00se opened a new pull request, #650:
URL: https://github.com/apache/tomcat/pull/650
hello 😄
I was looking at the code for the Request class in coyote.
Removed unnecessary brackets for consistency with the other code.
e.g. `contentLength = (clB == null || clB.isNull())
wonyongChoi05 opened a new pull request, #651:
URL: https://github.com/apache/tomcat/pull/651
Simplified the SSL certificate population logic by removing the unnecessary
null check and using an ArrayList for dynamic array management. The code is now
more concise and readable, and it efficie
Build status: BUILD FAILED: failed compile (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/112/builds/557
Blamelist: xxeol2
Build Text: failed compile (failure)
Status Detected: new failure
Build Source Stamp: [branch main] d0b655d8316bcef78b84255a9d8ee2f7cd78d649
aooohan closed pull request #650: Removed unnecessary brackets
URL: https://github.com/apache/tomcat/pull/650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
aooohan commented on PR #649:
URL: https://github.com/apache/tomcat/pull/649#issuecomment-1706095437
This change doesn't make any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
aooohan closed pull request #649: Eliminating duplicate execution of
checkFacade logic
URL: https://github.com/apache/tomcat/pull/649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
aooohan commented on PR #650:
URL: https://github.com/apache/tomcat/pull/650#issuecomment-1706094596
This change doesn't make any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
aooohan commented on PR #651:
URL: https://github.com/apache/tomcat/pull/651#issuecomment-1706113147
This change doesn't make any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
aooohan closed pull request #651: Refactor SSL certificate population method
URL: https://github.com/apache/tomcat/pull/651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/44/builds/919
Blamelist: lihan , xxeol2
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch 10.1.x] a95d18861ccaa30a4264bcf97fb3e8a2e0f06de9
Steps:
worker_p
https://bz.apache.org/bugzilla/show_bug.cgi?id=63690
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
markt-asf commented on PR #650:
URL: https://github.com/apache/tomcat/pull/650#issuecomment-1706269180
The change is trivial but it makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
markt-asf merged PR #650:
URL: https://github.com/apache/tomcat/pull/650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 29a0ee94dc Removed unnecessary brackets
29a0ee94dc is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new e1f6784991 Removed unnecessary brackets
e1f678499
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 09f6abfa71 Removed unnecessary brackets
09f6abfa71
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 28cf6b3c9b Removed unnecessary brackets
28cf6b3c9b
markt-asf commented on PR #649:
URL: https://github.com/apache/tomcat/pull/649#issuecomment-1706282024
The change makes sense to me. It removes a duplicate call to `checkFacade()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
markt-asf merged PR #649:
URL: https://github.com/apache/tomcat/pull/649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 3cbca9ce51 Eliminating duplicate execution of checkFa
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new d62e52a8a4 Eliminating duplicate execution of che
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new be8ea48d54 Eliminating duplicate execution of check
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 8500ae8fe1 Eliminating duplicate execution of check
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005
--- Comment #29 from Rainer Jung ---
I don't have a solution ready in the direction that Michael mentions. Because
we don't call a linker directly and we don't want to. Linker flags are not
standardized. That's one reason for using libtool.
So
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005
--- Comment #30 from Mark Thomas ---
Sounds good to me. Tx.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr..
This is an automated email from the ASF dual-hosted git repository.
rjung pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new eda74b19e Apache: Only export the main mod
markt-asf commented on PR #651:
URL: https://github.com/apache/tomcat/pull/651#issuecomment-1706340615
The switch to using a wildcard import would need to be reverted as would the
changes to blank lines between methods.
The null check is necessary in some form and it is more concise than
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005
--- Comment #31 from Rainer Jung ---
I checked the libtool code. It provides the option -export-symbols-regexp,
which was suggested and which I know committed, and it also provides
-export-symbols with a file name containing the symbols. The im
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new f650ea788d Simplify code. Based on PR #651 by wonyong
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new bf9b81c68e Simplify code. Based on PR #651 by won
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 840180fe73 Simplify code. Based on PR #651 by wonyo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 7716ebb4bf Simplify code. Based on PR #651 by wonyo
wonyongChoi05 commented on PR #651:
URL: https://github.com/apache/tomcat/pull/651#issuecomment-1706354873
> The switch to using a wildcard import would need to be reverted as would
the changes to blank lines between methods. The null check is necessary in some
form and it is more concise t
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/112/builds/558
Blamelist: greeng00se , xxeol2
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch main] 3cbca9ce51cd917aa18034ee212ec6351a2bee6c
Steps:
work
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005
--- Comment #32 from Michael Osipov ---
(In reply to Rainer Jung from comment #31)
> I checked the libtool code. It provides the option -export-symbols-regexp,
> which was suggested and which I know committed, and it also provides
> -export-sym
I saw we use for older versions
in the changelog, but since the last version this is missing. Is this an
oversight, or did we change the style sheet? Should we have the
"subsection" everywhere or remove everywhere? Any ideas?
Thanks and regards,
Rainer
--
On 05/09/2023 11:40, Rainer Jung wrote:
I saw we use for older versions
in the changelog, but since the last version this is missing. Is this an
oversight, or did we change the style sheet? Should we have the
"subsection" everywhere or remove everywhere? Any ideas?
Probably an oversight
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new 5720446db Fix typo
5720446db is described
iamjooon2 opened a new pull request, #652:
URL: https://github.com/apache/tomcat/pull/652
Hello!
i deleted needless brackets for consistency with the other code.
Thx :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
Am 05.09.23 um 12:50 schrieb Mark Thomas:
On 05/09/2023 11:40, Rainer Jung wrote:
I saw we use for older versions
in the changelog, but since the last version this is missing. Is this
an oversight, or did we change the style sheet? Should we have the
"subsection" everywhere or remove eve
This is an automated email from the ASF dual-hosted git repository.
rjung pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new 5a6e393f5 Status: Improve XSS hardening. (
This is an automated email from the ASF dual-hosted git repository.
rjung pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new 369da3135 Restructure subsections in chang
Am 05.09.23 um 13:18 schrieb Rainer Jung:
Am 05.09.23 um 12:50 schrieb Mark Thomas:
On 05/09/2023 11:40, Rainer Jung wrote:
I saw we use for older versions
in the changelog, but since the last version this is missing. Is this
an oversight, or did we change the style sheet? Should we have
Mark,
I'm not a big fan of this type of PR, this kind of change in the form of a
code change and only a line or two, and I've noticed that the last few PRs
have come from the same place 'woowacourse', which I personally suspect is
what they need to accomplish, eg: task, and since tomcat has a long
On Tue, Sep 5, 2023 at 1:48 PM Han Li wrote:
>
> Mark,
>
> I'm not a big fan of this type of PR, this kind of change in the form of a
> code change and only a line or two, and I've noticed that the last few PRs
> have come from the same place 'woowacourse', which I personally suspect is
> what the
Build status: BUILD FAILED: retry lost connection compile (retry)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/37/builds/665
Blamelist: Mark Thomas
Build Text: retry lost connection compile (retry)
Status Detected: retry build
Build Source Stamp: [branch 9.0.x] 7716ebb4bf11
On 05/09/2023 13:14, Rémy Maucherat wrote:
On Tue, Sep 5, 2023 at 1:48 PM Han Li wrote:
Mark,
I'm not a big fan of this type of PR, this kind of change in the form of a
code change and only a line or two, and I've noticed that the last few PRs
have come from the same place 'woowacourse', whic
woosung1223 opened a new pull request, #653:
URL: https://github.com/apache/tomcat/pull/653
Hi there!
I found unnecessary code in the Response class.
Currently, it seems that only headers of Content-Length or Content-Type are
called Special Headers.
However, as you can s
xxeol2 opened a new pull request, #654:
URL: https://github.com/apache/tomcat/pull/654
This PR is closely related to https://github.com/apache/tomcat/pull/649.
Prevent double execution of the checkFacade() logic when invoking the
isCommitted() method.
thanks !! 😁
--
This is an a
ingpyo opened a new pull request, #655:
URL: https://github.com/apache/tomcat/pull/655
Hello,
I have fixed a typo in the Tomcat codebase by changing "CookiePreocessor" to
"CookieProcessor" for better code clarity and correctness.
--
This is an automated message from the Apache Git Serv
On 05/09/2023 14:16, Mark Thomas wrote:
I think one way to address a lot of these concerns would be to enable
UnnecessaryParenthesesCheck, fix all the issues we want to fix and
disable the check for the ones we don't. I'll take a look at this this
afternoon.
I don't think this will work.
Th
xxeol2 commented on PR #654:
URL: https://github.com/apache/tomcat/pull/654#issuecomment-1706706294
I'm curious if following code changes would introduce any side effects.
### Origin
```java
public ServletOutputStream getOutputStream() throws IOException {
checkFacade();
Mark Thomas 于2023年9月5日周二 21:17写道：
> On 05/09/2023 13:14, Rémy Maucherat wrote:
> > On Tue, Sep 5, 2023 at 1:48 PM Han Li wrote:
> >>
> >> Mark,
> >>
> >> I'm not a big fan of this type of PR, this kind of change in the form
> of a
> >> code change and only a line or two, and I've noticed that th
markt-asf commented on PR #652:
URL: https://github.com/apache/tomcat/pull/652#issuecomment-1706738930
We have started to get a lot of PRs removing single instances of unnecessary
parentheses. While we are generally in favour of this sort of clean-up, one PR
per instance is not scaleable an
markt-asf merged PR #655:
URL: https://github.com/apache/tomcat/pull/655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new ab221875a3 Fix a comment typo
ab221875a3 is described
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new a64de1919c Fix a comment typo
a64de1919c is descr
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 4a0c094925 Fix a comment typo
4a0c094925 is describ
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new d50ad76523 Fix a comment typo
d50ad76523 is describ
markt-asf commented on PR #653:
URL: https://github.com/apache/tomcat/pull/653#issuecomment-1706758159
Those checks were added for performance reasons. They were significantly
quicker than calling `checkSpecialHeader()`. Unless a benchmark (as a unit
test) is provided that demonstrates that
markt-asf merged PR #654:
URL: https://github.com/apache/tomcat/pull/654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from ab221875a3 Fix a comment typo
add ff53af8b69 Eliminating duplicate execution of checkFacade logic in
ResponseFacade
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new a2a9445b16 Eliminating duplicate execution of che
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new e81815aa16 Eliminating duplicate execution of check
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new e92bc0e8e8 Eliminating duplicate execution of check
markt-asf commented on PR #654:
URL: https://github.com/apache/tomcat/pull/654#issuecomment-1706766432
Nice catch. Tx for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
xxeol2 commented on PR #654:
URL: https://github.com/apache/tomcat/pull/654#issuecomment-1706772038
@markt-asf
I was wondering if I shouldn't avoid duplicate calls to `checkFacade()` in
the `getOutputStream()` and `getWriter()` methods!
https://github.com/apache/tomcat/pull/654#issuecomm
woosung1223 closed pull request #653: unnecessary work is done before
determining if it is a special header
URL: https://github.com/apache/tomcat/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
woosung1223 commented on PR #653:
URL: https://github.com/apache/tomcat/pull/653#issuecomment-1706779668
> Those checks were added for performance reasons. They were significantly
quicker than calling checkSpecialHeader(). Unless a benchmark (as a unit test)
is provided that demonstrates th
iamjooon2 closed pull request #652: Remove unnecessary brackets
URL: https://github.com/apache/tomcat/pull/652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
Build status: BUILD FAILED: failed Snapshot deployed to ASF Maven snapshot
repository (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/112/builds/561
Blamelist: xxeol2
Build Text: failed Snapshot deployed to ASF Maven snapshot repository (failure)
Status Detected: ne
greeng00se opened a new pull request, #656:
URL: https://github.com/apache/tomcat/pull/656
Existing code calls getConfiguredSessionCookieName even if the context is
empty.
In getConfiguredSessionCookieName, only act to get the session cookie if the
context is non-null.
I think
greeng00se closed pull request #656: Optimization when call
getSessionCookieName & getSessionUriParamName
URL: https://github.com/apache/tomcat/pull/656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
markt-asf commented on PR #654:
URL: https://github.com/apache/tomcat/pull/654#issuecomment-1706867922
Those refactorings look OK. Please submit another PR for those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xxeol2 opened a new pull request, #657:
URL: https://github.com/apache/tomcat/pull/657
https://github.com/apache/tomcat/pull/654#issuecomment-1706706294
This was discussed in the comments above!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
greeng00se commented on PR #656:
URL: https://github.com/apache/tomcat/pull/656#issuecomment-1706941221
I didn't think about when neither priority 1 nor 2 is present in pr, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Jaeyoung22 opened a new pull request, #658:
URL: https://github.com/apache/tomcat/pull/658
Although I totally agree that there could be some unnecessary parentheses to
aid the readability of the code, I think that the unity of the code is still
important for readability.
### Conditio
parkmuhyeun opened a new pull request, #659:
URL: https://github.com/apache/tomcat/pull/659
## Description
This PR made the following two modifications
- Unify constant delimiters
- Refactoring for better readability
## Explanation
### Unify constant delimiters
markt-asf commented on code in PR #657:
URL: https://github.com/apache/tomcat/pull/657#discussion_r1316282831
##
java/org/apache/catalina/connector/ResponseFacade.java:
##
@@ -111,23 +111,19 @@ public String getCharacterEncoding() {
@Override
public ServletOutputStre
markt-asf commented on code in PR #659:
URL: https://github.com/apache/tomcat/pull/659#discussion_r1316303250
##
java/org/apache/catalina/manager/StatusTransformer.java:
##
@@ -375,33 +375,33 @@ protected static void writeProcessorState(PrintWriter
writer,
switch (st
parkmuhyeun commented on PR #659:
URL: https://github.com/apache/tomcat/pull/659#issuecomment-1707218270
I reverted the stage constants back and modified the switch statements to
use the constants that were originally there!
--
This is an automated message from the Apache Git Service.
To
greeng00se opened a new pull request, #660:
URL: https://github.com/apache/tomcat/pull/660
### Description
Optimization when call getSessionCookieName & getSessionUriParamName
### Explanation
Existing code calls getConfiguredSessionCookieName even if the context is
empty
greeng00se commented on PR #650:
URL: https://github.com/apache/tomcat/pull/650#issuecomment-1707230523
@markt-asf thx for merge my first contribution 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
greeng00se commented on PR #656:
URL: https://github.com/apache/tomcat/pull/656#issuecomment-1707231871
sorry. Case 3 is not considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
markt-asf commented on PR #660:
URL: https://github.com/apache/tomcat/pull/660#issuecomment-1707256734
Saving a single function call is unlikely to make any difference. I'd expect
the compiler to optimise that.
Changes that reduce duplication and/or improve the readability of the code
greeng00se commented on PR #660:
URL: https://github.com/apache/tomcat/pull/660#issuecomment-1707265409
@markt-asf
Thanks for the nice comment.
I hadn't considered that partial compiler optimisation.
I agree, readable code should be a priority and I moved the null-check logic
to a
On 21/08/2023 13:17, Mark Thomas wrote:
On 21/08/2023 02:53, Sebastian Lövdahl wrote:
Hi,
I have been using the RSS feeds linked from
https://tomcat.apache.org/lists.html for following this and other
Tomcat-related lists
(https://tomcat.markmail.org/atom/+list:org%2Eapache%2Etomcat%2Edev),
https://markmail.org has been permanently shut down and will no longer be
available.
https://stackoverflow.com/questions/76878371/how-do-you-access-markmail
On 2023/09/05 20:37:47 Mark Thomas wrote:
> On 21/08/2023 13:17, Mark Thomas wrote:
> > On 21/08/2023 02:53, Sebastian Lövdahl wrote:
> >> Hi
xxeol2 commented on code in PR #657:
URL: https://github.com/apache/tomcat/pull/657#discussion_r1316480032
##
java/org/apache/catalina/connector/ResponseFacade.java:
##
@@ -111,23 +111,19 @@ public String getCharacterEncoding() {
@Override
public ServletOutputStream
Jaeyoung22 closed pull request #658: Unify conditional statement format for
some constants in http1 package
URL: https://github.com/apache/tomcat/pull/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Jaeyoung22 closed pull request #658: Unify conditional statement format for
some constants in http1 package
URL: https://github.com/apache/tomcat/pull/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Jaeyoung22 opened a new pull request, #661:
URL: https://github.com/apache/tomcat/pull/661
Although I totally agree that there could be some unnecessary parentheses to
aid the readability of the code, I think that the unity of the code is still
important for readability.
### Conditio
parkmuhyeun commented on PR #659:
URL: https://github.com/apache/tomcat/pull/659#issuecomment-1707461772
Oh, sorry. I missed that one! I've fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
iamjooon2 closed pull request #652: Remove unnecessary brackets
URL: https://github.com/apache/tomcat/pull/652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
iamjooon2 commented on PR #652:
URL: https://github.com/apache/tomcat/pull/652#issuecomment-1707507180
@markt-asf I just saw [!This PR](https://github.com/apache/tomcat/pull/650)
and removed some brackets too
Regret for comment 'Automated tools'😕
--
This is an automated message fro
Jaeyoung22 commented on PR #658:
URL: https://github.com/apache/tomcat/pull/658#issuecomment-1707535138
This Pull Request UNINTENTIONALLY sended because of github incident :( So I
closed this PR and resend.
--
This is an automated message from the Apache Git Service.
To respond to the mes
wonyongChoi05 opened a new pull request, #662:
URL: https://github.com/apache/tomcat/pull/662
Hello! Thank you for the PR. Upon reviewing these changes, I've noticed a
significant improvement in code readability. This enhanced readability stands
out and will make a substantial difference in
https://bz.apache.org/bugzilla/show_bug.cgi?id=67235
Bug ID: 67235
Summary: NPE (NullPointerException) occurs in
AsyncContextImpl.decrementInProgressAsyncCount after
version 10.1.12.
Product: Tomcat 10
Version: un
https://bz.apache.org/bugzilla/show_bug.cgi?id=67235
brigh...@toss.im changed:
What|Removed |Added
OS||All
Hardware|PC
100 matches
Mail list logo
