parkmuhyeun opened a new pull request, #659: URL: https://github.com/apache/tomcat/pull/659
## Description This PR made the following two modifications - Unify constant delimiters - Refactoring for better readability ## Explanation ### Unify constant delimiters Constants managed in the Constants class in the coyote package are separated by _ for better readability. The Constants class in the ajp and http2 packages is fine, but the Constants class in the coyote and http11 packages has constants that break uniformity, so I fixed them. - TRANSFERENCODING -> TRASNFER_ENCODING - STAGE_ENDINPUT -> STAGE_END_INPUT - STAGE_ENDOUTPUT -> STAGE_END_OUTPUT - STAGE_KEEPALIVE -> STAGE_KEEP_ALIVE ### Refactoring for better readability I found a switch statement in the StatusTransformer class with a magic number. I planned to refactor it, thinking it would be more readable if it was separated into constants. I could have used the constants from coyote's Constants class as the comment says, but statusTransformer is now in the catalina package, which is a different package. So I added the relevant constants to the Constants class in the catalina package and used them. +Also, I noticed that coyote's Constants constants are only used within the coyote package. ## Comments This is my first PR, so please let me know if there's anything wrong! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
