On 05/09/2023 14:16, Mark Thomas wrote:
I think one way to address a lot of these concerns would be to enable
UnnecessaryParenthesesCheck, fix all the issues we want to fix and
disable the check for the ones we don't. I'll take a look at this this
afternoon.
I don't think this will work.
There are certainly lots of places where the parentheses are obviously
unnecessary. However, there are cases for most for the tokens that
checkstyle checks where we may want to keep the parentheses. These are
also numerous enough we probably don't want to have to litter the code
with //CHECKSTYLE:OFF //CHECKSTYLE:ON
We can certainly fix the obvious instances as we find them but a one-off
global fix with checkstyle and Eclipse formatting looks unlikely.
That brings us back to what to do about the PRs. I understand the
concerns but I also worry about alienating contributors.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
