This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new e92bc0e8e8 Eliminating duplicate execution of checkFacade logic in 
ResponseFacade (#654)
e92bc0e8e8 is described below

commit e92bc0e8e899d663c8bc984fada3d129771dd59c
Author: xxeol2 <jhj01...@naver.com>
AuthorDate: Tue Sep 5 23:46:21 2023 +0900

    Eliminating duplicate execution of checkFacade logic in ResponseFacade 
(#654)
    
    Eliminating duplicate execution of checkFacade logic in ResponseFacade
---
 java/org/apache/catalina/connector/ResponseFacade.java | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/java/org/apache/catalina/connector/ResponseFacade.java 
b/java/org/apache/catalina/connector/ResponseFacade.java
index c2a8e968b4..6f7b45aafa 100644
--- a/java/org/apache/catalina/connector/ResponseFacade.java
+++ b/java/org/apache/catalina/connector/ResponseFacade.java
@@ -194,7 +194,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void setContentLength(int len) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -204,7 +203,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void setContentLengthLong(long length) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -214,7 +212,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void setContentType(String type) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -243,7 +240,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void flushBuffer() throws IOException {
-        checkFacade();
         if (isFinished()) {
             return;
         }
@@ -287,7 +283,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void setLocale(Locale loc) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -304,7 +299,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void addCookie(Cookie cookie) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -373,7 +367,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void setDateHeader(String name, long date) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -388,7 +381,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void addDateHeader(String name, long date) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -403,7 +395,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void setHeader(String name, String value) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -413,7 +404,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void addHeader(String name, String value) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -423,7 +413,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void setIntHeader(String name, int value) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -433,7 +422,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void addIntHeader(String name, int value) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -443,7 +431,6 @@ public class ResponseFacade implements HttpServletResponse {
 
     @Override
     public void setStatus(int sc) {
-        checkFacade();
         if (isCommitted()) {
             return;
         }
@@ -508,7 +495,6 @@ public class ResponseFacade implements HttpServletResponse {
 
 
     private void checkCommitted(String messageKey) {
-        checkFacade();
         if (isCommitted()) {
             throw new IllegalStateException(sm.getString(messageKey));
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to