markt-asf commented on PR #653: URL: https://github.com/apache/tomcat/pull/653#issuecomment-1706758159
Those checks were added for performance reasons. They were significantly quicker than calling `checkSpecialHeader()`. Unless a benchmark (as a unit test) is provided that demonstrates that these checks are unnecessary, this PR is unlikely to be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
