DO NOT REPLY [Bug 46041] Tomcat service is terminated unexpectedly (tcnative-1.dll)

2008-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46041 Marcin Zajaczkowski <[EMAIL PROTECTED]> changed: What|Removed |Added Version|unspecified |1.1.4

[JNI/native]: recvfrom vs recvFrom

2008-10-21 Thread Lorenz Breu
Hi folks, I am new to this stuff, so please bear with me... I am working on some extensions to the APR transport in the MINA project. I was trying to use Socket.recvFrom() from the org.apache.tomcat.jni package and kept getting UnsatisfiedLink errors... I think I tracked the problem to a case mis

DO NOT REPLY [Bug 46047] New: Issue when using include directive inside tag files that are inside jar files

2008-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46047 Summary: Issue when using include directive inside tag files that are inside jar files Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Linux Status

svn commit: r706574 - /tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java

2008-10-21 Thread mturk
Author: mturk Date: Tue Oct 21 03:47:24 2008 New Revision: 706574 URL: http://svn.apache.org/viewvc?rev=706574&view=rev Log: Fix API function name recvFrom -> recvfrom. Modified: tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java Modified: tomcat/connectors/trunk/jni/java/org

Re: [JNI/native]: recvfrom vs recvFrom

2008-10-21 Thread Mladen Turk
Lorenz Breu wrote: Hi folks, Socket.class and the native network.c files. The java code specifies a recvFrom() method (capital F) whereas the native code defines a recvfrom() function (all lowercase)... A quick rebuild of the tomcat sources after renaming the java method recvfrom() seems to have

[JNI/native] retrieving the port of the remote end of a socket

2008-10-21 Thread Lorenz Breu
Glad I could help ;) Maybe somebody can give me a hint now. I am trying to retrieve the port of the sender of a datagram using recvfrom() as shown below: protected SocketAddress receive(Long handle, IoBuffer buffer) throws Exception { /*initialize a new byte array for now. Is the data c

svn commit: r706626 - /tomcat/container/tags/tc4.1.x/TOMCAT_4_1_38/

2008-10-21 Thread markt
Author: markt Date: Tue Oct 21 06:42:22 2008 New Revision: 706626 URL: http://svn.apache.org/viewvc?rev=706626&view=rev Log: Tagging 4.1.38 Added: tomcat/container/tags/tc4.1.x/TOMCAT_4_1_38/ - copied from r706625, tomcat/container/branches/tc4.1.x/ ---

svn commit: r706629 - /tomcat/servletapi/tags/servlet2.3-jsp1.2-tc4.x/TOMCAT_4_1_38/

2008-10-21 Thread markt
Author: markt Date: Tue Oct 21 06:42:58 2008 New Revision: 706629 URL: http://svn.apache.org/viewvc?rev=706629&view=rev Log: Tagging 4.1.38 Added: tomcat/servletapi/tags/servlet2.3-jsp1.2-tc4.x/TOMCAT_4_1_38/ - copied from r706628, tomcat/servletapi/branches/servlet2.3-jsp1.2-tc4.x/ -

svn commit: r706627 - /tomcat/connectors/tags/tc4.1.x/TOMCAT_4_1_38/

2008-10-21 Thread markt
Author: markt Date: Tue Oct 21 06:42:34 2008 New Revision: 706627 URL: http://svn.apache.org/viewvc?rev=706627&view=rev Log: Tagging 4.1.38 Added: tomcat/connectors/tags/tc4.1.x/TOMCAT_4_1_38/ - copied from r706626, tomcat/connectors/trunk/

svn commit: r706628 - /tomcat/jasper/tags/tc4.1.x/TOMCAT_4_1_38/

2008-10-21 Thread markt
Author: markt Date: Tue Oct 21 06:42:46 2008 New Revision: 706628 URL: http://svn.apache.org/viewvc?rev=706628&view=rev Log: Tagging 4.1.38 Added: tomcat/jasper/tags/tc4.1.x/TOMCAT_4_1_38/ - copied from r706627, tomcat/jasper/branches/tc4.1.x/ -

Re: Tomcat connection pool contribution

2008-10-21 Thread Filip Hanik - Dev Lists
if there are no objections, I'll start integrating this into trunk tonight or tomorrow, Filip Filip Hanik - Dev Lists wrote: gentlemen, having run into issues with performance around commons-dbcp as number of logical cpus increase, no such method exceptions using newer JDKs, I've made a sma

Re: Tomcat connection pool contribution

2008-10-21 Thread Remy Maucherat
On Tue, 2008-10-21 at 08:09 -0600, Filip Hanik - Dev Lists wrote: > if there are no objections, I'll start integrating this into trunk > tonight or tomorrow, -1. Tomcat does not do connection pools. Commons-pool/-dbcp is used instead, so you should contribute your code to the right project, I th

Re: Tomcat connection pool contribution

2008-10-21 Thread Yoav Shapira
Filip, On Tue, Oct 21, 2008 at 10:09 AM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > if there are no objections, I'll start integrating this into trunk tonight or > tomorrow, I've read the bug in Bugzilla and looked at the code. I understand why you want a new connection pool implement

svn commit: r706633 - /tomcat/container/branches/tc4.1.x/build.properties.default

2008-10-21 Thread markt
Author: markt Date: Tue Oct 21 07:09:14 2008 New Revision: 706633 URL: http://svn.apache.org/viewvc?rev=706633&view=rev Log: Update version for next release Modified: tomcat/container/branches/tc4.1.x/build.properties.default Modified: tomcat/container/branches/tc4.1.x/build.properties.defau

Re: Tomcat connection pool contribution

2008-10-21 Thread Costin Manolache
I think there is a solution that would make everyone happy :-) - put this code and everything that depends on it in a separate module ( separate == different release cycle and binary ). I don't know if it should be in a separate svn tree, probably would be better. Then you can cut a release - and

Re: Tomcat connection pool contribution

2008-10-21 Thread Henri Gomez
> My primary concern is to have the dependency right - the new module can > depend on tomcat, > but tomcat should not have any direct dep. on the new code. I wouldn't mind > if all the existing JDBC > related components would move to the new module as well :-). Costin is a long time supporter of m

Re: Tomcat connection pool contribution

2008-10-21 Thread Remy Maucherat
On Tue, 2008-10-21 at 10:19 -0400, Yoav Shapira wrote: > However, I don't think we should stick a connection pool > implementation in Tomcat proper. It should go in Commons DbUtils, or > DBCP, or another existing project. Heck, it can even start out on > Google Code, idealy with an ASL license. >

svn commit: r706648 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-10-21 Thread remm
Author: remm Date: Tue Oct 21 08:02:10 2008 New Revision: 706648 URL: http://svn.apache.org/viewvc?rev=706648&view=rev Log: - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=7066

Re: Tomcat connection pool contribution

2008-10-21 Thread Filip Hanik - Dev Lists
Remy and Yoav, I totally understand where you are coming from, and I have thought about it for while before I suggested adding it here 1. commons-dbcp is very stagnant, they are not even accepting performance improvement patches https://issues.apache.org/jira/browse/POOL-75 2. Remy's comment

Re: Tomcat connection pool contribution

2008-10-21 Thread Yoav Shapira
On Tue, Oct 21, 2008 at 11:15 AM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > I hear both of your concerns, and I will withdraw the proposal, thanks for > speaking up These are all good comments. Is it possible to package up in a way that core Tomcat does not depend on it, like Costin s

Re: Tomcat connection pool contribution

2008-10-21 Thread Remy Maucherat
On Tue, 2008-10-21 at 09:15 -0600, Filip Hanik - Dev Lists wrote: > Remy and Yoav, I totally understand where you are coming from, and I > have thought about it for while before I suggested adding it here > > 1. commons-dbcp is very stagnant, they are not even accepting > performance improvement

Re: Tomcat connection pool contribution

2008-10-21 Thread Tim Funk
Oddly enough - I started reading the code today. There are some minor tweaks without digging too deep into the code: ProxyConnection.java This should be CLOSE_VAL.equals(method.getName()) if (CLOSE_VAL==method.getName()) { PoolProperties protected String name = "Filip Connection Pool["+(poolCou

Re: Tomcat connection pool contribution

2008-10-21 Thread Leon Rosenberg
On Tue, Oct 21, 2008 at 5:15 PM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > Remy and Yoav, I totally understand where you are coming from, and I have > thought about it for while before I suggested adding it here > 4. Going with the little piece of code (8classes) elsewhere is a bit moot

Re: Tomcat connection pool contribution

2008-10-21 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > Remy and Yoav, I totally understand where you are coming from, and I > have thought about it for while before I suggested adding it here > > 1. commons-dbcp is very stagnant, they are not even accepting > performance improvement patches > https://issues.apache.org/

Re: Tomcat connection pool contribution

2008-10-21 Thread Filip Hanik - Dev Lists
Yoav Shapira wrote: On Tue, Oct 21, 2008 at 11:15 AM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: I hear both of your concerns, and I will withdraw the proposal, thanks for speaking up These are all good comments. Is it possible to package up in a way that core Tomcat does not

Re: Tomcat connection pool contribution

2008-10-21 Thread Filip Hanik - Dev Lists
Tim Funk wrote: Oddly enough - I started reading the code today. There are some minor tweaks without digging too deep into the code: ProxyConnection.java This should be CLOSE_VAL.equals(method.getName()) if (CLOSE_VAL==method.getName()) { . aren't method names in the constant pool? PoolProp

Re: Tomcat connection pool contribution

2008-10-21 Thread Markus Schönhaber
Mark Thomas: > Filip Hanik - Dev Lists wrote: >> 2. Remy's comment -"Tomcat does not do connection pools" >> We sure do, the fact that we ship with one, means we do connection >> pools. and we are in the job of refactoring commons-dbcp, and now you >> can't even compile Tomcat with JDK 1.6, nor ru

Re: Tomcat connection pool contribution

2008-10-21 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Remy and Yoav, I totally understand where you are coming from, and I have thought about it for while before I suggested adding it here 1. commons-dbcp is very stagnant, they are not even accepting performance improvement patches https://issue

Re: Tomcat connection pool contribution

2008-10-21 Thread Filip Hanik - Dev Lists
Markus Schönhaber wrote: Mark Thomas: Filip Hanik - Dev Lists wrote: 2. Remy's comment -"Tomcat does not do connection pools" We sure do, the fact that we ship with one, means we do connection pools. and we are in the job of refactoring commons-dbcp, and now you can't even compile

Re: Tomcat connection pool contribution

2008-10-21 Thread Costin Manolache
I would go one step further and not ship jdbc-related components in the basic distro :-), and bundle dbcp and jdbc-related code as a separate module. If someone is using a database - there are few setup steps anyways, and downloading a separate tomcat module may be the easiest of them. From a tom

Re: Tomcat connection pool contribution

2008-10-21 Thread Costin Manolache
On Tue, Oct 21, 2008 at 9:00 AM, Filip Hanik - Dev Lists <[EMAIL PROTECTED] > wrote: > Yoav Shapira wrote: > >> On Tue, Oct 21, 2008 at 11:15 AM, Filip Hanik - Dev Lists >> <[EMAIL PROTECTED]> wrote: >> >> >>> I hear both of your concerns, and I will withdraw the proposal, thanks >>> for speaking

[VOTE] Release build 4.1.38

2008-10-21 Thread Mark Thomas
The source tarball and other packages are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.38/ According to the release process, the 4.1.38 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Cheers, Mark - To

DO NOT REPLY [Bug 46051] New: Servlet response writer does not respect line.separator system property

2008-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46051 Summary: Servlet response writer does not respect line.separator system property Product: Tomcat 6 Version: unspecified Platform: All OS/Version: All Status:

svn commit: r706696 - in /tomcat/trunk: java/org/apache/tomcat/bayeux/ test/org/apache/cometd/bayeux/samples/ webapps/cometd/ webapps/cometd/WEB-INF/ webapps/cometd/examples/simplechat/

2008-10-21 Thread fhanik
Author: fhanik Date: Tue Oct 21 11:07:04 2008 New Revision: 706696 URL: http://svn.apache.org/viewvc?rev=706696&view=rev Log: work on the bayeux samples Added: tomcat/trunk/test/org/apache/cometd/bayeux/samples/BayeuxStockTicker.java tomcat/trunk/webapps/cometd/examples/simplechat/ticker.

DO NOT REPLY [Bug 42409] Extra response headers not sent when using custom error page

2008-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42409 Brian Curnow <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED

svn commit: r706726 - /tomcat/trunk/webapps/cometd/examples/simplechat/ticker.html

2008-10-21 Thread fhanik
Author: fhanik Date: Tue Oct 21 12:16:15 2008 New Revision: 706726 URL: http://svn.apache.org/viewvc?rev=706726&view=rev Log: improve the stock ticker example Modified: tomcat/trunk/webapps/cometd/examples/simplechat/ticker.html Modified: tomcat/trunk/webapps/cometd/examples/simplechat/ticke

DO NOT REPLY [Bug 46051] Servlet response writer does not respect line.separator system property

2008-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46051 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-10-21 12:23:58 PST --- The change is http://svn.apache.org/viewvc?view=rev&revision=298149 I am tempted to leave this as is. Whilst strict adherence to the PrintWriter interface

svn commit: r706729 - /tomcat/trunk/webapps/cometd/examples/simplechat/ticker.html

2008-10-21 Thread fhanik
Author: fhanik Date: Tue Oct 21 12:27:36 2008 New Revision: 706729 URL: http://svn.apache.org/viewvc?rev=706729&view=rev Log: fancier now Modified: tomcat/trunk/webapps/cometd/examples/simplechat/ticker.html Modified: tomcat/trunk/webapps/cometd/examples/simplechat/ticker.html URL: http://s

DO NOT REPLY [Bug 46051] Servlet response writer does not respect line.separator system property

2008-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46051 --- Comment #2 from Chris Hubick <[EMAIL PROTECTED]> 2008-10-21 12:50:48 PST --- I see where you are coming from, and somewhat agree - though I think there is value in strict adherance to the API. The decision is yours - I just wanted

[VOTE/SENSUS] connection pool

2008-10-21 Thread Filip Hanik - Dev Lists
Let's get a feel for what we think we should do. Based on https://issues.apache.org/bugzilla/show_bug.cgi?id=46038 I believe (pick only one): a. [ ] It doesn't belong here, take it elsewhere b. [ ] Bring it here, we'll ship it with next major version of Tomcat c. [ ] Bring it here, we'll make i

Re: [VOTE/SENSUS] connection pool

2008-10-21 Thread Yoav Shapira
On Tue, Oct 21, 2008 at 4:05 PM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > Let's get a feel for what we think we should do. > > Based on > https://issues.apache.org/bugzilla/show_bug.cgi?id=46038 > > I believe (pick only one): > > a. [ ] It doesn't belong here, take it elsewhere > b. [ ]

Re: [VOTE/SENSUS] connection pool

2008-10-21 Thread Costin Manolache
On Tue, Oct 21, 2008 at 1:05 PM, Filip Hanik - Dev Lists <[EMAIL PROTECTED] > wrote: > Let's get a feel for what we think we should do. > > Based on > https://issues.apache.org/bugzilla/show_bug.cgi?id=46038 > > I believe (pick only one): > > a. [ ] It doesn't belong here, take it elsewhere > b. [

svn commit: r706762 - /tomcat/sandbox/bz-svn/

2008-10-21 Thread markt
Author: markt Date: Tue Oct 21 13:45:40 2008 New Revision: 706762 URL: http://svn.apache.org/viewvc?rev=706762&view=rev Log: testing svn-bz client side integration Added: tomcat/sandbox/bz-svn/ (with props) Propchange: tomcat/sandbox/bz-svn/

svn commit: r706763 - /tomcat/sandbox/bz-svn/test.txt

2008-10-21 Thread markt
Author: markt Date: Tue Oct 21 13:47:40 2008 New Revision: 706763 URL: http://svn.apache.org/viewvc?rev=706763&view=rev Log: Test Added: tomcat/sandbox/bz-svn/test.txt (with props) Added: tomcat/sandbox/bz-svn/test.txt URL: http://svn.apache.org/viewvc/tomcat/sandbox/bz-svn/test.txt?rev=7

svn commit: r706764 - /tomcat/sandbox/bz-svn/test.txt

2008-10-21 Thread markt
Author: markt Date: Tue Oct 21 13:48:30 2008 New Revision: 706764 URL: http://svn.apache.org/viewvc?rev=706764&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46051 This is the only sentence I entered in the log message. Modified: tomcat/sandbox/bz-svn/test.txt Modified:

Re: [VOTE/SENSUS] connection pool

2008-10-21 Thread Filip Hanik - Dev Lists
Filip Hanik - Dev Lists wrote: Let's get a feel for what we think we should do. Based on https://issues.apache.org/bugzilla/show_bug.cgi?id=46038 I believe (pick only one): a. [ ] It doesn't belong here, take it elsewhere b. [ ] Bring it here, we'll ship it with next major version of Tomcat c.

Re: [VOTE/SENSUS] connection pool

2008-10-21 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > Let's get a feel for what we think we should do. > > Based on > https://issues.apache.org/bugzilla/show_bug.cgi?id=46038 > > I believe (pick only one): > > a. [ ] It doesn't belong here, take it elsewhere > b. [ ] Bring it here, we'll ship it with next major vers

Re: [VOTE/SENSUS] connection pool

2008-10-21 Thread Remy Maucherat
On Tue, 2008-10-21 at 14:05 -0600, Filip Hanik - Dev Lists wrote: > c. [X] Bring it here, we'll make it an independent module with its own > release cycle And it could replace dbcp once it is tested, but you should probably look at moving the code elsewhere eventually. Rémy --