Remy and Yoav, I totally understand where you are coming from, and I
have thought about it for while before I suggested adding it here
1. commons-dbcp is very stagnant, they are not even accepting
performance improvement patches
https://issues.apache.org/jira/browse/POOL-75
2. Remy's comment -"Tomcat does not do connection pools"
We sure do, the fact that we ship with one, means we do connection
pools. and we are in the job of refactoring commons-dbcp, and now you
can't even compile Tomcat with JDK 1.6, nor run it with JDK 1.6 since
the java.sql API's are not implemented. a user doesn't care of this is a
project from elsewhere, he/she just feels it is a hinder.
3. Yoav's comment - "I don't want to bloat Tomcat with extra stuff"
Depends on the definition of bloating, our hacks around commons-dbcp,
the size of the library (commons-dbcp-193k, new pool-36k) itself, and
the build script
we've already bloated our system with crud from commons-dbcp, not
working properly here
Look at the build script for commons-dbcp->tomcat-dbcp, that is *code*,
and that is bloat.
4. Going with the little piece of code (8classes) elsewhere is a bit
moot, the code is complete, it's not gonna attract a community based on
8classes. And that is why it would be awkward putting it anywhere else,
its not like this code is gonna grow and evolve into a large organic
project, hence within the ASF, it would be considered dead even before
it started.
I hear both of your concerns, and I will withdraw the proposal,
thanks for speaking up
Filip
Yoav Shapira wrote:
Filip,
On Tue, Oct 21, 2008 at 10:09 AM, Filip Hanik - Dev Lists
<[EMAIL PROTECTED]> wrote:
if there are no objections, I'll start integrating this into trunk tonight or
tomorrow,
I've read the bug in Bugzilla and looked at the code. I understand
why you want a new connection pool implementation, and I like what
you've done with it, code-wise. In fact, I'd probably like to use it
myself. (I use c3p0, which I like better than DBCP, but that's
another story).
However, I don't think we should stick a connection pool
implementation in Tomcat proper. It should go in Commons DbUtils, or
DBCP, or another existing project. Heck, it can even start out on
Google Code, idealy with an ASL license.
I don't want to bloat Tomcat with extra stuff, no matter how good.
I'd much rather remove stuff and keep the core way smaller. I really
like what Costin is doing with his "Tomcat lite."
Of course, that's just my personal opinion. But I wanted to speak up
because I'm pretty close to a -1 on this one.
Yoav
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
