I think there is a solution that would make everyone happy :-) - put this code and everything that depends on it in a separate module ( separate == different release cycle and binary ). I don't know if it should be in a separate svn tree, probably would be better.
Then you can cut a release - and with a bit of tricks may work with existing tomcat5 or 6. Regarding scope - yes, maybe moving it to commons would be better, but the essential question is who's going to maintain it. If other projects pick it up - no problem with moving it, but as long as tomcat is the main user and you probably the main maintainer, it's better to keep it in tomcat ( and hopefully other tomcat people get enough familiarity with the code to be able to vote +1 on releasing it :-). My primary concern is to have the dependency right - the new module can depend on tomcat, but tomcat should not have any direct dep. on the new code. I wouldn't mind if all the existing JDBC related components would move to the new module as well :-). Costin On Tue, Oct 21, 2008 at 7:19 AM, Yoav Shapira <[EMAIL PROTECTED]> wrote: > Filip, > > On Tue, Oct 21, 2008 at 10:09 AM, Filip Hanik - Dev Lists > <[EMAIL PROTECTED]> wrote: > > if there are no objections, I'll start integrating this into trunk > tonight or tomorrow, > > I've read the bug in Bugzilla and looked at the code. I understand > why you want a new connection pool implementation, and I like what > you've done with it, code-wise. In fact, I'd probably like to use it > myself. (I use c3p0, which I like better than DBCP, but that's > another story). > > However, I don't think we should stick a connection pool > implementation in Tomcat proper. It should go in Commons DbUtils, or > DBCP, or another existing project. Heck, it can even start out on > Google Code, idealy with an ASL license. > > I don't want to bloat Tomcat with extra stuff, no matter how good. > I'd much rather remove stuff and keep the core way smaller. I really > like what Costin is doing with his "Tomcat lite." > > Of course, that's just my personal opinion. But I wanted to speak up > because I'm pretty close to a -1 on this one. > > Yoav > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
