(tomcat) branch 10.1.x updated: Adding nonstandard support for c:set and c:remove

2025-04-23 Thread jengebr
This is an automated email from the ASF dual-hosted git repository. jengebr pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 9192fc8a84 Adding nonstandard support for

(tomcat) branch 11.0.x updated: Adding nonstandard support for c:set and c:remove

2025-04-23 Thread jengebr
This is an automated email from the ASF dual-hosted git repository. jengebr pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 67df11e33d Adding nonstandard support for

(tomcat) branch 9.0.x updated: Adding nonstandard support for c:set and c:remove

2025-04-18 Thread jengebr
This is an automated email from the ASF dual-hosted git repository. jengebr pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 285b8215eb Adding nonstandard support for c:set

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-16 Thread via GitHub
jengebr merged PR #842: URL: https://github.com/apache/tomcat/pull/842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-16 Thread via GitHub
handle, as long as it + * reports it accurately to the caller by returning false. For example, the + * initial implementation for c:set excludes support for body content. c:set + * tags with body content will be generated with the standard code and tags

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-16 Thread via GitHub
jengebr commented on code in PR #842: URL: https://github.com/apache/tomcat/pull/842#discussion_r2046912039 ## java/org/apache/jasper/runtime/JspRuntimeLibrary.java: ## @@ -957,4 +957,21 @@ public static void releaseTag(Tag tag, InstanceManager instanceManager) { }

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-16 Thread via GitHub
cannot handle, as long as it + * reports it accurately to the caller by returning false. For example, the + * initial implementation for c:set excludes support for body content. c:set + * tags with body content will be generated with the standard code and tags

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-16 Thread via GitHub
handle, as long as it + * reports it accurately to the caller by returning false. For example, the + * initial implementation for c:set excludes support for body content. c:set + * tags with body content will be generated with the standard code and tags

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-16 Thread via GitHub
jengebr commented on code in PR #842: URL: https://github.com/apache/tomcat/pull/842#discussion_r2046872254 ## java/org/apache/jasper/runtime/JspRuntimeLibrary.java: ## @@ -957,4 +957,21 @@ public static void releaseTag(Tag tag, InstanceManager instanceManager) { }

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-16 Thread via GitHub
cannot handle, as long as it + * reports it accurately to the caller by returning false. For example, the + * initial implementation for c:set excludes support for body content. c:set + * tags with body content will be generated with the standard code and tags

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-15 Thread via GitHub
jengebr commented on PR #842: URL: https://github.com/apache/tomcat/pull/842#issuecomment-2806882710 > Thinking long term, I am wondering whether we need to provide the ability for users to customise these optimisations. If we do then we can add something like a `GeneratorFactory` and users

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-15 Thread via GitHub
handle, as long as it + * reports it accurately to the caller by returning false. For example, the + * initial implementation for c:set excludes support for body content. c:set + * tags with body content will be generated with the standard code and tags

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-15 Thread via GitHub
jengebr commented on code in PR #842: URL: https://github.com/apache/tomcat/pull/842#discussion_r2045072065 ## java/org/apache/jasper/runtime/JspRuntimeLibrary.java: ## @@ -957,4 +957,21 @@ public static void releaseTag(Tag tag, InstanceManager instanceManager) { }

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-15 Thread via GitHub
+ * reports it accurately to the caller by returning false. For example, the + * initial implementation for c:set excludes support for body content. c:set + * tags with body content will be generated with the standard code and tags + * without body content will be

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-10 Thread via GitHub
jengebr commented on PR #842: URL: https://github.com/apache/tomcat/pull/842#issuecomment-2794646560 > While only targeting `c:set/c:remove` - Do you also need to check the tag belongs to `http://java.sun.com/jsp/jstl/core` ? I suspect the user wouldn't enable the flag then use a different

Re: [PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-10 Thread via GitHub
funkman commented on PR #842: URL: https://github.com/apache/tomcat/pull/842#issuecomment-2794610781 While only targeting `c:set/c:remove` - Do you also need to check the tag belongs to `http://java.sun.com/jsp/jstl/core` ? I suspect the user wouldn't enable the flag then use a different li

[PR] Adding nonstandard support for c:set and c:remove [tomcat]

2025-04-04 Thread via GitHub
jengebr opened a new pull request, #842: URL: https://github.com/apache/tomcat/pull/842 Enables optimized, non-standard behavior for the most common JSP tags, when configured to do so. **Unit tests pending** **Off by default.** When activated, the code generation to call `

(tomcat) branch 9.0.x updated: Add Java 25 support for JSP compilation

2025-03-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9f8e044e48 Add Java 25 support for JSP compilation

(tomcat) branch 10.1.x updated: Add Java 25 support for JSP compilation

2025-03-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new eb1a3629ab Add Java 25 support for JSP

(tomcat) branch 11.0.x updated: Add Java 25 support for JSP compilation

2025-03-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 43473e3da0 Add Java 25 support for JSP

(tomcat) branch main updated: Add Java 25 support for JSP compilation

2025-03-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d27f738616 Add Java 25 support for JSP compilation

Re: [PR] Added support for JDBC 4.3 beginRequest and endRequest methods. [tomcat]

2025-03-12 Thread via GitHub
fmeheust commented on PR #677: URL: https://github.com/apache/tomcat/pull/677#issuecomment-2718315476 Hi @aooohan and @ahai-code this contribution has been approved for a while, is it possible to have an idea on when it will be comitted? Thank you! -- This is an automated message from th

[Bug 69610] New: Consider implementing support for upgrade-insecure-requests request header and conditional HSTS

2025-03-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69610 Bug ID: 69610 Summary: Consider implementing support for upgrade-insecure-requests request header and conditional HSTS Product: Tomcat 11 Version: unspecified

(tomcat) branch main updated: Add back wine support for building the Windows installer.

2025-03-10 Thread rjung
This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 9559e1b623 Add back wine support for building the

(tomcat) branch 9.0.x updated: Add back wine support for building the Windows installer.

2025-03-10 Thread rjung
This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 3388715b21 Add back wine support for building the

(tomcat) branch 10.1.x updated: Add back wine support for building the Windows installer.

2025-03-10 Thread rjung
This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 9dc5126fe3 Add back wine support for building

(tomcat) branch 11.0.x updated: Add back wine support for building the Windows installer.

2025-03-10 Thread rjung
This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 56bbec8d0d Add back wine support for building

(tomcat) branch 9.0.x updated: Add support for encodedReverseSolidusHandling

2025-01-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2b43c51d43 Add support for

(tomcat) branch 10.1.x updated: Add support for encodedReverseSolidusHandling

2025-01-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 6b58e0213c Add support for

(tomcat) branch 11.0.x updated: Add support for encodedReverseSolidusHandling

2025-01-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 696a2515d6 Add support for

(tomcat) branch main updated: Add support for encodedReverseSolidusHandling

2025-01-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 79d5e047aa Add support for

(tomcat) 01/19: Remove WebDAV lock null support for compliance with RFC 4918

2024-10-22 Thread remm
null support for compliance with RFC 4918 Section 7.3 and annex D deprecate lock nulls and define a new behavior. http://www.webdav.org/specs/rfc4918.html#lock-null Instead a lock on a non existing resource will create an empty file locked with a regular lock, which is of course

(tomcat) 01/18: Remove WebDAV lock null support for compliance with RFC 4918

2024-10-22 Thread remm
null support for compliance with RFC 4918 Section 7.3 and annex D deprecate lock nulls and define a new behavior. http://www.webdav.org/specs/rfc4918.html#lock-null Instead a lock on a non existing resource will create an empty file locked with a regular lock, which is of course

(tomcat) 01/18: Remove WebDAV lock null support for compliance with RFC 4918

2024-10-22 Thread remm
null support for compliance with RFC 4918 Section 7.3 and annex D deprecate lock nulls and define a new behavior. http://www.webdav.org/specs/rfc4918.html#lock-null Instead a lock on a non existing resource will create an empty file locked with a regular lock, which is of course

(tomcat) branch main updated: Remove WebDAV lock null support for compliance with RFC 4918

2024-10-17 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 82a1f68561 Remove WebDAV lock null support for

(tomcat) branch 9.0.x updated: Add support for server and serverRemoveAppProvidedValues to h2

2024-09-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 3701d8468d Add support for server and

(tomcat) branch 10.1.x updated: Add support for server and serverRemoveAppProvidedValues to h2

2024-09-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 748c584f8c Add support for server and

(tomcat) branch 11.0.x updated: Add support for server and serverRemoveAppProvidedValues to h2

2024-09-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new a5bc1e4841 Add support for server and

(tomcat) branch main updated: Add support for server and serverRemoveAppProvidedValues to h2

2024-09-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new dcb4e3f347 Add support for server and

(tomcat) 01/02: Add support for the Elvis operator

2024-08-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1242677516fb4bc2a5b41a92f2bf7b56945b492f Author: Mark Thomas AuthorDate: Mon Aug 12 19:54:31 2024 +0100 Add support

(tomcat) branch 9.0.x updated: Refactor JreCompat support for Subject.callAs() to remove Jre18Compat

2024-07-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2306c78ced Refactor JreCompat support for

(tomcat) branch 10.1.x updated: Refactor JreCompat support for Subject.callAs() to remove Jre18Compat

2024-07-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new b6f23b4dda Refactor JreCompat support for

(tomcat) branch main updated: Refactor JreCompat support for Subject.callAs() to remove Jre18Compat

2024-07-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 1bb5cb19b7 Refactor JreCompat support for

(tomcat) 01/02: Add JreCompat support for Subject.callAs()

2024-07-25 Thread markt
JreCompat support for Subject.callAs() With the changes coming in Java 23 we need to move away from Subject.doAs() but the replacement isn't available in Java 17. Hence use JreCompat. --- .../org/apache/tomcat/util/compat/Jre18Compat.java | 71 ++ .../org/apache/t

(tomcat) 01/02: Add JreCompat support for Subject.callAs()

2024-07-25 Thread markt
JreCompat support for Subject.callAs() With the changes coming in Java 23 we need to move away from Subject.doAs() but the replacement isn't available in Java 17. Hence use JreCompat. --- .../org/apache/tomcat/util/compat/Jre18Compat.java | 71 ++ .../org/apache/t

Re: (tomcat) 01/03: Add JreCompat support for Subject.callAs()

2024-07-25 Thread Mark Thomas
a2384804c527c64290cfae1fa988f1f394890e91 Author: Mark Thomas AuthorDate: Wed Jul 24 17:51:24 2024 +0100 Add JreCompat support for Subject.callAs() With the changes coming in Java 23 we need to move away from Subject.doAs() but the replacement isn't available in Java 17. Hence use JreC

Re: (tomcat) 01/03: Add JreCompat support for Subject.callAs()

2024-07-25 Thread Mark Thomas
a2384804c527c64290cfae1fa988f1f394890e91 Author: Mark Thomas AuthorDate: Wed Jul 24 17:51:24 2024 +0100 Add JreCompat support for Subject.callAs() With the changes coming in Java 23 we need to move away from Subject.doAs() but the replacement isn't available in Java 17. Hence use JreCompat. --- .../org/a

Re: (tomcat) 01/03: Add JreCompat support for Subject.callAs()

2024-07-25 Thread Rémy Maucherat
> Author: Mark Thomas > AuthorDate: Wed Jul 24 17:51:24 2024 +0100 > > Add JreCompat support for Subject.callAs() > > With the changes coming in Java 23 we need to move away from > Subject.doAs() but the replacement isn't available in Java 17. Hence use > Jre

Re: (tomcat) 01/03: Add JreCompat support for Subject.callAs()

2024-07-25 Thread Michael Osipov
; Author: Mark Thomas > AuthorDate: Wed Jul 24 17:51:24 2024 +0100 > > Add JreCompat support for Subject.callAs() > > With the changes coming in Java 23 we need to move away from > Subject.doAs() but the replacement isn't available in Java 17. Hence use >

(tomcat) 01/03: Add JreCompat support for Subject.callAs()

2024-07-25 Thread markt
support for Subject.callAs() With the changes coming in Java 23 we need to move away from Subject.doAs() but the replacement isn't available in Java 17. Hence use JreCompat. --- .../org/apache/tomcat/util/compat/Jre18Compat.java | 71 ++ .../org/apache/t

(tomcat) 07/08: Add HTTP/2 support for early hints

2024-07-19 Thread markt
support for early hints --- java/org/apache/coyote/http2/Stream.java | 16 ++ java/org/apache/coyote/http2/StreamProcessor.java | 3 +- .../apache/coyote/http2/TestStreamProcessor.java | 66 ++ 3 files changed, 83 insertions(+), 2 deletions(-) diff --git a/java

Re: (tomcat) 06/07: Add HTTP/2 support for early hints

2024-07-19 Thread Mark Thomas
AuthorDate: Thu Jul 4 16:53:21 2024 +0100 Add HTTP/2 support for early hints --- java/org/apache/coyote/http2/Stream.java | 16 ++ java/org/apache/coyote/http2/StreamProcessor.java | 3 +- .../apache/coyote/http2/TestStreamProcessor.java | 66 ++ 3

Re: (tomcat) 06/07: Add HTTP/2 support for early hints

2024-07-19 Thread Koteswararao Gundapaneni
f/tomcat.git > > commit ae22fadba4b94152fa5cc1d015ed2058f21e3164 > Author: Mark Thomas > AuthorDate: Thu Jul 4 16:53:21 2024 +0100 > > Add HTTP/2 support for early hints > --- > java/org/apache/coyote/http2/Stream.java | 16 ++ > java/org/apache/

(tomcat) 06/07: Add HTTP/2 support for early hints

2024-07-19 Thread markt
support for early hints --- java/org/apache/coyote/http2/Stream.java | 16 ++ java/org/apache/coyote/http2/StreamProcessor.java | 3 +- .../apache/coyote/http2/TestStreamProcessor.java | 66 ++ 3 files changed, 83 insertions(+), 2 deletions(-) diff --git a/java

(tomcat) 08/09: Add HTTP/2 support for early hints

2024-07-19 Thread markt
support for early hints --- java/org/apache/coyote/http2/Stream.java | 16 ++ java/org/apache/coyote/http2/StreamProcessor.java | 3 +- .../apache/coyote/http2/TestStreamProcessor.java | 67 ++ 3 files changed, 84 insertions(+), 2 deletions(-) diff --git a/java

[Bug 57830] Add support for ProxyProtocol

2024-07-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57830 Mark Thomas changed: What|Removed |Added Component|Catalina|Connectors --- Comment #26 from Mark Tho

[Bug 57830] Add support for ProxyProtocol

2024-07-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57830 Mark Thomas changed: What|Removed |Added Version|8.0.21 |unspecified Product|Tomcat 8

(tomcat) branch 9.0.x updated: Add support for re-keying with TLS 1.3

2024-06-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 76c5cce6f0 Add support for re-keying with TLS 1.3

(tomcat) branch 10.1.x updated: Add support for re-keying with TLS 1.3

2024-06-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 3344c17cef Add support for re-keying with TLS

(tomcat) branch main updated: Add support for re-keying with TLS 1.3

2024-06-14 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 3197862639 Add support for re-keying with TLS 1.3

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-11 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2161659043 I merged the PR and tried to comment out the exclusion lines as agreed above, but that breaks with a different error and does not allow to build. I think that it's best to leave things

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-11 Thread via GitHub
ChristopherSchultz commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2161585676 My preference is for the ide-idea ant target to work for *most people*. _Most people_ are not Tomcat developers, but people who have downloaded our sources and are building them l

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-11 Thread via GitHub
isapir merged PR #731: URL: https://github.com/apache/tomcat/pull/731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-11 Thread via GitHub
dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160442520 The change we could make so that all opinions are generally satisfied are: 1. Move the exclusions from `res/ide-support/idea/compiler.xml` to `res/ide-support/idea/tomcat.iml` commente

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-11 Thread via GitHub
markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160396222 > Since IDE support is [configured](https://github.com/apache/tomcat/blob/main/build.xml#L3830) with build.java.version, which currently is [17](https://github.com/apache/tomcat/blob/main

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-11 Thread via GitHub
dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160286872 > IMO it is reasonable to expect a user that is developing on the latest version of Tomcat, i.e. the main branch, to be using the latest Java SDK, which will work with the Experimental featu

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-10 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2159528473 Thank you for your input on this @markt-asf - it makes sense to me, and is consistent with my proposed solution. > - Eclipse is configured to use the same Java version as the build (Jav

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-10 Thread via GitHub
markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2157847935 I'm not an Idea user so I have no strong view on this. I'd be happy with whatever consensus the Idea users reach. I am an Eclipse user and the approach I use there (which I think the

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-06 Thread via GitHub
rmannibucau commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151570300 Assuming using uses the highest java version sounds okish but shouldnt preview mode be enabled if the packages are not excluded, otherwise it leads to the same output: it does not work i

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-06 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151559998 @dsoumis Tomcat 11 takes advantage of new technology. The build script checks if the Java version is 22 and if so it compiles the Panama packages. This is for a development environment

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-05 Thread via GitHub
dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151524740 @isapir My expectation was that "ant ide-intellij" should work out of the box without requiring any adjustments. Currently, to use an SDK version lower than 22, you must exclude `/java/o

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-05 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2150273321 @dsoumis But now you are completely excluding `/java/org/apache/tomcat/util/net/openssl/panama` and `/java/org/apache/tomcat/util/openssl`? It might "work" on Java 17 but new technology woul

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-05 Thread via GitHub
dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2149133573 On second thoughts, I believe ide-support should strictly follow build.xml rules. As build.xml [excludes](https://github.com/apache/tomcat/blob/main/build.xml#L1014) openssl and panama

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-03 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2145709893 Strange, I don't have those settings ![image](https://github.com/apache/tomcat/assets/885907/22b3d25e-3b20-4ede-b80d-60a9da90c081) But OK, I will revert the latest change. Feel

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-03 Thread via GitHub
dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144545354 @isapir It doesn't work for me. After pulling your patch I am getting errors such as: `java: java.lang.foreign.Arena is a preview API and is disabled by default. (use --enable-preview

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-02 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144252838 @dsoumis I pushed a patch that sets the Language Level to Experimental: https://github.com/apache/tomcat/commit/f8eecc13b53fdca998565455d3c27e9b9a6cd8dc Can you pull it and check if

Re: [PR] Fix ide-support for idea [tomcat]

2024-06-02 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144037801 @dsoumis I got it to work by setting the Project's `Language level` to "X - Experimental features" ![image](https://github.com/apache/tomcat/assets/885907/41c6646c-a767-48d3-ad2b-c8b2d

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142686031 That isn't it then. I think we need someone else with Idea (or who can set it up) to test this. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142631865 22.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142625138 Hmm. Exactly which version of Java 22 are you using? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142611198 @markt-asf Compilation errors with Java22 (compile target is 22 as well as Java 22 being used): > > /home/dsoumis/Programs/github/tomcat/java/org/apache/tomcat/util/net/openssl/pa

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142584248 I'm not an Idea user but I'd expect that code to compile using Java 22. Not much help I know but those packages aren't showing any errors in Eclipse with Java 22. What is the error

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142552727 @dsoumis I agree that it's weird, but my concern is that it would break other environments that work. Let's wait for Remy/Mark/others to chime in as they are more familiar with how thi

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142542693 @isapir It seemed weird to me, but even with Java 22 defined in Intellij the compilation didn't succeed. Maybe something else is missing as well. +1 For adding a comment in the output --

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142532017 @dsoumis It won't compile if the Java version etc. are not compatible with that code. This is not making it useless. Perhaps a better change would be to add a comment about it in the output,

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142501404 Intellij won't compile the sources if those exclusions are not made, making the "ant ide-intellij" step useless. In case it's not the right thing to do, we should

Re: [PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142442782 These lines were commented out on purpose, so that they are available if you need them but not enabled by default. I am not sure that uncommenting them is the right thing to do. The fi

[PR] Fix ide-support for idea [tomcat]

2024-05-31 Thread via GitHub
dsoumis opened a new pull request, #731: URL: https://github.com/apache/tomcat/pull/731 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: (tomcat) branch main updated: Add support for shallow copies when using WebDAV

2024-05-23 Thread Mark Thomas
On 23/05/2024 12:53, Konstantin Kolinko wrote: вт, 21 мая 2024 г. в 14:55, : The following commit(s) were added to refs/heads/main by this push: new 4176706761 Add support for shallow copies when using WebDAV 4176706761 is described below commit 4176706761242851b14be303daf2a00ef385ee49

(tomcat) 01/02: Add support for shallow copies when using WebDAV

2024-05-23 Thread markt
dex 956a1af8fc..541b3a9613 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -105,6 +105,13 @@ issues do not "pop up" wrt. others). --> + + + +Add support for shallow copies when using WebDAV. (markt) + + +

Re: (tomcat) branch main updated: Add support for shallow copies when using WebDAV

2024-05-23 Thread Konstantin Kolinko
вт, 21 мая 2024 г. в 14:55, : > > The following commit(s) were added to refs/heads/main by this push: > new 4176706761 Add support for shallow copies when using WebDAV > 4176706761 is described below > > commit 4176706761242851b14be303daf2a00ef385ee49 > Author: Mark Thom

(tomcat) branch 10.1.x updated: Add support for shallow copies when using WebDAV

2024-05-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 22a5e178b3 Add support for shallow copies when

(tomcat) branch main updated: Add support for shallow copies when using WebDAV

2024-05-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 4176706761 Add support for shallow copies when using

(tomcat) branch 9.0.x updated: Add support for Java 23

2024-04-29 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 29c214ce03 Add support for Java 23 29c214ce03 is

(tomcat) branch 10.1.x updated: Add support for Java 23

2024-04-29 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new f8ea6383c2 Add support for Java 23 f8ea6383c2 is

(tomcat) 02/02: Add support for Java 23

2024-04-29 Thread markt
r.getMessage("jsp.warning.unknown.targetVM", opt)); settings.put(CompilerOptions.OPTION_TargetPlatform, CompilerOptions.VERSION_17); diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 6e0838465d..53f60a70d2 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/cha

(tomcat) branch 10.1.x updated: Add support for timescales with time-taken access log token. (#721)

2024-04-26 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new a7e9d7da69 Add support for timescales with

(tomcat) branch main updated: Add support for timescales with time-taken access log token. (#721)

2024-04-26 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new e9046d96a6 Add support for timescales with time

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

2024-04-26 Thread via GitHub
ChristopherSchultz merged PR #721: URL: https://github.com/apache/tomcat/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

2024-04-24 Thread via GitHub
ChristopherSchultz commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1578085100 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char

  1   2   3   4   5   6   7   8   9   10   >