jengebr commented on code in PR #842: URL: https://github.com/apache/tomcat/pull/842#discussion_r2046912039
########## java/org/apache/jasper/runtime/JspRuntimeLibrary.java: ########## @@ -957,4 +957,21 @@ public static void releaseTag(Tag tag, InstanceManager instanceManager) { } } + + public static void nonstandardSetTag(jakarta.servlet.jsp.PageContext pageContext, String var, Object value) { + if (value == null) { + pageContext.removeAttribute(var); + } else { + pageContext.setAttribute(var, value); + } + } + Review Comment: I verified this by comparison to the JSTL tag and realized I missed some logic to clean up the VariableMapper. I added that as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org