isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2161659043
I merged the PR and tried to comment out the exclusion lines as agreed above, but that breaks with a different error and does not allow to build. I think that it's best to leave things as they are for now for the following reasons: 1. As @markt-asf pointed out this script is used rather rarely 2. As @ChristopherSchultz and @dsoumis pointed out most users might not have preview features enabled 3. In 3 months Java 23 will become GA and could make these issues obsolete, so we can update the SDK level then 4. We are spending a lot of time on something that is not used that much A more efficient process might be to add some instructions or pointers in the comments or target output -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
